From: Jan Beulich Date: Wed, 7 Mar 2012 23:45:44 +0000 (+0000) Subject: netfilter: xt_LOG: don't use xchg() for simple assignment X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f3d229c68bb47170f04f81e51c9ed5d4286cebdb;p=mv-sheeva.git netfilter: xt_LOG: don't use xchg() for simple assignment At least on ia64 the (bogus) use of xchg() here results in the compiler warning about an unused expression result. As only an assignment is intended here, convert it to such. Signed-off-by: Jan Beulich Acked-by: Eric Dumazet Signed-off-by: Pablo Neira Ayuso --- diff --git a/include/net/netfilter/xt_log.h b/include/net/netfilter/xt_log.h index 7e1544e8f70..9d9756cca01 100644 --- a/include/net/netfilter/xt_log.h +++ b/include/net/netfilter/xt_log.h @@ -47,7 +47,7 @@ static void sb_close(struct sbuff *m) if (likely(m != &emergency)) kfree(m); else { - xchg(&emergency_ptr, m); + emergency_ptr = m; local_bh_enable(); } }