From: Amit Nagal <helloin.amit@gmail.com>
Date: Tue, 27 Sep 2011 17:41:58 +0000 (-0400)
Subject: HID: hidraw: open count should not increase if error
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f554ff80339b4005856e6a86454d6ea2bb962ee5;p=linux-beck.git

HID: hidraw: open count should not increase if error

In hidraw_open, if hid_hw_power returns with error, hidraw device open count
should not increase.

Signed-off-by: Amit Nagal <helloin.amit@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---

diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index a8c2b7b6220a..6d65d4e35120 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -272,8 +272,10 @@ static int hidraw_open(struct inode *inode, struct file *file)
 	dev = hidraw_table[minor];
 	if (!dev->open++) {
 		err = hid_hw_power(dev->hid, PM_HINT_FULLON);
-		if (err < 0)
+		if (err < 0) {
+			dev->open--;
 			goto out_unlock;
+		}
 
 		err = hid_hw_open(dev->hid);
 		if (err < 0) {