From: Andreas Gruenbacher Date: Wed, 19 Feb 2014 09:49:07 +0000 (+0100) Subject: drbd: Fix future possible NULL pointer dereference X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f597f6b8dfaa033be3b3b755e6c0ab3caee96dcd;p=linux-beck.git drbd: Fix future possible NULL pointer dereference Right now every resource has exactly one connection. But we are preparing for dynamic connections. I.e. in the future thre can be resources without connections. However smatch points this out as 'variable dereferenced before check', which is correct. This issue was introduced in drbd: get_one_status(): Iterate over resource->devices instead of connection->peer_devices Reported-by: Dan Carpenter Signed-off-by: Andreas Gruenbacher Signed-off-by: Philipp Reisner Signed-off-by: Jens Axboe --- diff --git a/drivers/block/drbd/drbd_nl.c b/drivers/block/drbd/drbd_nl.c index 2086b12d3f75..526414bc2cab 100644 --- a/drivers/block/drbd/drbd_nl.c +++ b/drivers/block/drbd/drbd_nl.c @@ -2776,7 +2776,7 @@ static int nla_put_drbd_cfg_context(struct sk_buff *skb, if (device && nla_put_u32(skb, T_ctx_volume, device->vnr)) goto nla_put_failure; - if (nla_put_string(skb, T_ctx_resource_name, connection->resource->name)) + if (nla_put_string(skb, T_ctx_resource_name, resource->name)) goto nla_put_failure; if (connection) { if (connection->my_addr_len &&