From: Greg Kroah-Hartman Date: Thu, 10 May 2012 18:37:18 +0000 (-0700) Subject: USB: gadget: ci13xx_udc: fix potential crash in irq handler X-Git-Tag: v3.5-rc1~149^2~105 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f639554b8a3a4aac18193a0c98a4639d432c48f0;p=karo-tx-linux.git USB: gadget: ci13xx_udc: fix potential crash in irq handler As pointed out by Dan Carpenter, we should not be trying to call dev_err() on a structure that was previously determined to be NULL, that's just foolish and asking for trouble. So just delete the message, it's not going to do anyone any good to have it anyway. This problem was caused by 0f089094cde5: "usb: gadget: ci13xxx: replace home-brewed logging with dev_{err,warn,info}" Reported-by: Dan Carpenter Cc: Alexander Shishkin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c index 560b539b9def..5bd95b0a23d7 100644 --- a/drivers/usb/gadget/ci13xxx_udc.c +++ b/drivers/usb/gadget/ci13xxx_udc.c @@ -2719,10 +2719,8 @@ static irqreturn_t udc_irq(int irq, void *data) trace(udc ? udc->dev : NULL, ""); - if (udc == NULL) { - dev_err(udc->dev, "ENODEV"); + if (udc == NULL) return IRQ_HANDLED; - } spin_lock(&udc->lock);