From: Laurent Pinchart Date: Fri, 7 Mar 2014 22:47:03 +0000 (+0100) Subject: iommu/omap: Fix 'no page for' debug message in flush_iotlb_page() X-Git-Tag: next-20140428~32^2^2~2 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f7129a0e4d5835b7851208d35984bc80116f1ed0;p=karo-tx-linux.git iommu/omap: Fix 'no page for' debug message in flush_iotlb_page() The flush_iotlb_page() function prints a debug message when no corresponding page was found in the TLB. That condition is incorrectly checked and always resolves to true, given that the for_each_iotlb_cr() loop is never interrupted and always reaches obj->nr_tlb_entries. Given that we can't have two TLB entries for the same VA, break from the loop when a match is found. Signed-off-by: Laurent Pinchart Acked-by: Suman Anna --- diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index 78f32d13dd66..b5787f151dfc 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -394,6 +394,7 @@ static void flush_iotlb_page(struct omap_iommu *obj, u32 da) __func__, start, da, bytes); iotlb_load_cr(obj, &cr); iommu_write_reg(obj, 1, MMU_FLUSH_ENTRY); + break; } } pm_runtime_put_sync(obj->dev);