From: Lee Jones Date: Fri, 19 Jul 2013 07:44:50 +0000 (+0100) Subject: mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memory for sysfs X-Git-Tag: next-20130912~124^2^2~2 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f840e23bcf16068eeffe8991ac38b58b82160e43;p=karo-tx-linux.git mfd: ab8500-debugfs: Apply a check for -ENOMEM after allocating memory for sysfs The AB8500 debugfs driver allocates memory for a new sysfs entry, but fails to apply the proper post-allocation checks. If the device were to run out of memory, the allocation would return NULL. Without the correct checks the driver will continue to populate NULL->[show|store|...], which would obviously cause a pointer dereference Oops. Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index a0afa64b471b..fe8189c4385a 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -2800,6 +2800,9 @@ static ssize_t ab8500_subscribe_write(struct file *file, */ dev_attr[irq_index] = kmalloc(sizeof(struct device_attribute), GFP_KERNEL); + if (!dev_attr[irq_index]) + return -ENOMEM; + event_name[irq_index] = kmalloc(count, GFP_KERNEL); sprintf(event_name[irq_index], "%lu", user_val); dev_attr[irq_index]->show = show_irq;