From: Elena Oat <oat.elena@gmail.com>
Date: Thu, 27 Feb 2014 10:26:52 +0000 (+0200)
Subject: Staging: usbip: Fix the warning of unchecked sscanf return value.
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f8cfc0230909077d2e378c829ffeb7bdf71a890e;p=linux-beck.git

Staging: usbip: Fix the warning of unchecked sscanf return value.

The return value of sscanf in stub_dev.c is not checked. This patch
adds the checking of the return value.

Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index b0bfd3430d47..60a3e3fe4dcb 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -87,13 +87,16 @@ static ssize_t store_sockfd(struct device *dev, struct device_attribute *attr,
 	int sockfd = 0;
 	struct socket *socket;
 	ssize_t err = -EINVAL;
+	int rv;
 
 	if (!sdev) {
 		dev_err(dev, "sdev is null\n");
 		return -ENODEV;
 	}
 
-	sscanf(buf, "%d", &sockfd);
+	rv = sscanf(buf, "%d", &sockfd);
+	if (rv != 1)
+		return -EINVAL;
 
 	if (sockfd != -1) {
 		dev_info(dev, "stub up\n");