From: Simon Glass <sjg@chromium.org>
Date: Wed, 16 Mar 2016 13:45:33 +0000 (-0600)
Subject: mkimage: Correct file being closed twice in fit_extract_data()
X-Git-Tag: KARO-TXSD-2017-03-15~1434
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=f980ca3411bac50aa64be3c8fd4c436adfa7cb13;p=karo-tx-uboot.git

mkimage: Correct file being closed twice in fit_extract_data()

The code flows through to the end of the function, so we don't need another
close() before this. Remove it.

Reported-by: Coverity (CID: 138503)

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
---

diff --git a/tools/fit_image.c b/tools/fit_image.c
index 31aa43cab3..8a93ea33f9 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -446,8 +446,6 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname)
 		ret = -EIO;
 		goto err;
 	}
-	close(fd);
-
 	ret = 0;
 
 err: