From: Tony Battersby <tonyb@cybernetics.com>
Date: Thu, 11 Oct 2007 04:09:04 +0000 (-0700)
Subject: [NET]: sanitize kernel_accept() error path
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=fa8705b00aeca19d91a1437b8a5cf865999b28f6;p=linux-beck.git

[NET]: sanitize kernel_accept() error path

If kernel_accept() returns an error, it may pass back a pointer to
freed memory (which the caller should ignore).  Make it pass back NULL
instead for better safety.

Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/socket.c b/net/socket.c
index d2336472f494..379b3a390755 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -2235,6 +2235,7 @@ int kernel_accept(struct socket *sock, struct socket **newsock, int flags)
 	err = sock->ops->accept(sock, *newsock, flags);
 	if (err < 0) {
 		sock_release(*newsock);
+		*newsock = NULL;
 		goto done;
 	}