From: Takashi Iwai Date: Thu, 2 Jun 2016 08:42:11 +0000 (+0200) Subject: ALSA: hda - Turn off loopback mixing as default X-Git-Tag: v4.8-rc1~84^2~2^2~19 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=fabc16fe9a92709c284325fbd14805fa410dc1d3;p=karo-tx-linux.git ALSA: hda - Turn off loopback mixing as default So far, we enabled the loopback mixing control as default, as this behavior made somewhat compatible with the earlier HD-audio drivers for Realtek & co. However, it's getting annoying as we've got more and more bug reports about the noise coming from the loopback route. Since the loopback mixing is used fairly rarely and often harmful (e.g. using PA), let's get rid of the default turn-on lines. Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 320445f3bf73..7e785487c67b 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -2492,10 +2492,6 @@ static int create_loopback_mixing_ctl(struct hda_codec *codec) if (!snd_hda_gen_add_kctl(spec, NULL, &loopback_mixing_enum)) return -ENOMEM; spec->have_aamix_ctl = 1; - /* if no explicit aamix path is present (e.g. for Realtek codecs), - * enable aamix as default -- just for compatibility - */ - spec->aamix_mode = !has_aamix_out_paths(spec); return 0; }