From: Guenter Roeck <guenter.roeck@ericsson.com>
Date: Thu, 8 Dec 2011 18:01:25 +0000 (-0800)
Subject: hwmon: (f75375s) Fix value range for PWM modes
X-Git-Tag: next-20111220~71^2~3
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=fc48c92552d3f3085a9fc7241195dbf9dd636c67;p=karo-tx-linux.git

hwmon: (f75375s) Fix value range for PWM modes

Accepted value range for PWM modes was 0..4, even though only 0..3 is
subsequently used. Limit permitted value range to 0..3 to avoid unpredictable
behavior.

Cc: Riku Voipio <riku.voipio@iki.fi>
Reviewed-by: Bjoern Gerhart <oss@extracloud.de>
Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
---

diff --git a/drivers/hwmon/f75375s.c b/drivers/hwmon/f75375s.c
index 316c29a0b318..777a665164f9 100644
--- a/drivers/hwmon/f75375s.c
+++ b/drivers/hwmon/f75375s.c
@@ -309,7 +309,7 @@ static int set_pwm_enable_direct(struct i2c_client *client, int nr, int val)
 	struct f75375_data *data = i2c_get_clientdata(client);
 	u8 fanmode;
 
-	if (val < 0 || val > 4)
+	if (val < 0 || val > 3)
 		return -EINVAL;
 
 	fanmode = f75375_read8(client, F75375_REG_FAN_TIMER);