From: Philipp Zabel
Date: Tue, 5 Aug 2014 17:00:12 +0000 (-0300)
Subject: [media] coda: skip calling coda_find_codec in encoder try_fmt_vid_out
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=fcf59764b99c7daa9b0876fe65d1393e6b759673;p=linux-beck.git
[media] coda: skip calling coda_find_codec in encoder try_fmt_vid_out
We know that it will return NULL in this case, so we can just as well
skip it altogether.
Signed-off-by: Philipp Zabel
Signed-off-by: Kamil Debski
Signed-off-by: Mauro Carvalho Chehab
---
diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
index 6760e346f969..4e85e387f905 100644
--- a/drivers/media/platform/coda/coda-common.c
+++ b/drivers/media/platform/coda/coda-common.c
@@ -426,14 +426,15 @@ static int coda_try_fmt_vid_out(struct file *file, void *priv,
struct v4l2_format *f)
{
struct coda_ctx *ctx = fh_to_ctx(priv);
- const struct coda_codec *codec;
+ const struct coda_codec *codec = NULL;
/* Determine codec by encoded format, returns NULL if raw or invalid */
- codec = coda_find_codec(ctx->dev, f->fmt.pix.pixelformat,
- V4L2_PIX_FMT_YUV420);
- if (!codec && ctx->inst_type == CODA_INST_DECODER) {
- codec = coda_find_codec(ctx->dev, V4L2_PIX_FMT_H264,
+ if (ctx->inst_type == CODA_INST_DECODER) {
+ codec = coda_find_codec(ctx->dev, f->fmt.pix.pixelformat,
V4L2_PIX_FMT_YUV420);
+ if (!codec)
+ codec = coda_find_codec(ctx->dev, V4L2_PIX_FMT_H264,
+ V4L2_PIX_FMT_YUV420);
if (!codec)
return -EINVAL;
}