From: Prasad Joshi <prasadjoshi.linux@gmail.com>
Date: Fri, 31 Aug 2012 03:25:21 +0000 (+0530)
Subject: ASoC: spear: correct the check for NULL dma_buffer pointer
X-Git-Tag: next-20120904~56^2~1^2
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=fd4fb262b31ecb06bf93defb036e72b33ddf0200;p=karo-tx-linux.git

ASoC: spear: correct the check for NULL dma_buffer pointer

The if condition
	if (!buf && !buf->area)

checks if the buf pointer is NULL and then dereferences it again to
check if the buffer area is NULL, resulting in possible NULL
dereference.

Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

diff --git a/sound/soc/spear/spear_pcm.c b/sound/soc/spear/spear_pcm.c
index 97c2cac8e92c..8c7f23729446 100644
--- a/sound/soc/spear/spear_pcm.c
+++ b/sound/soc/spear/spear_pcm.c
@@ -138,7 +138,7 @@ static void spear_pcm_free(struct snd_pcm *pcm)
 			continue;
 
 		buf = &substream->dma_buffer;
-		if (!buf && !buf->area)
+		if (!buf || !buf->area)
 			continue;
 
 		dma_free_writecombine(pcm->card->dev, buf->bytes,