From: Johan Hovold <johan@hovoldconsulting.com>
Date: Thu, 19 Mar 2015 15:46:16 +0000 (+0100)
Subject: greybus: ap: clean up svc link management error path
X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~1672
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=fe4c0e548aea5f4bc2df967db69d7d0b509327ef;p=karo-tx-linux.git

greybus: ap: clean up svc link management error path

Return immediately on bundle-init failure when processing SVC link up.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
---

diff --git a/drivers/staging/greybus/ap.c b/drivers/staging/greybus/ap.c
index 10f3b4d2443d..ea197ac57b52 100644
--- a/drivers/staging/greybus/ap.c
+++ b/drivers/staging/greybus/ap.c
@@ -149,11 +149,13 @@ static void svc_management(struct svc_function_unipro_management *management,
 		ret = gb_bundle_init(intf,
 				management->link_up.interface_id,
 				management->link_up.device_id);
-		if (ret)
+		if (ret) {
 			dev_err(hd->parent,
 				"error %d initializing interface %hhu bundle %hhu\n",
 				ret, management->link_up.module_id,
 				management->link_up.interface_id);
+			return;
+		}
 		break;
 	default:
 		dev_err(hd->parent, "Unhandled UniPro management message\n");