From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date: Tue, 31 May 2011 10:38:07 +0000 (+0900)
Subject: fat: Fix corrupt inode flags when remove ATTR_SYS flag
X-Git-Tag: v2.6.35.14~104
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ff7cb9c3fe433028969fe28b5a542a0477b252b3;p=karo-tx-linux.git

fat: Fix corrupt inode flags when remove ATTR_SYS flag

commit 1adffbae22332bb558c2a29de19d9aca391869f6 upstream.

We are clearly missing '~' in fat_ioctl_set_attributes().

Reported-by: Dmitry Dmitriev <dimondmm@yandex.ru>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---

diff --git a/fs/fat/file.c b/fs/fat/file.c
index 990dfae022e5..f2880571b3b0 100644
--- a/fs/fat/file.c
+++ b/fs/fat/file.c
@@ -102,7 +102,7 @@ static int fat_ioctl_set_attributes(struct file *file, u32 __user *user_attr)
 		if (attr & ATTR_SYS)
 			inode->i_flags |= S_IMMUTABLE;
 		else
-			inode->i_flags &= S_IMMUTABLE;
+			inode->i_flags &= ~S_IMMUTABLE;
 	}
 
 	fat_save_attrs(inode, attr);