From: Chen Gang Date: Sun, 26 May 2013 07:01:46 +0000 (+0000) Subject: MIPS: Ralink: Use strlcpy() instead of strncpy(). X-Git-Tag: next-20130607~101^2~4 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=ff8f130cca8f2a4edb2f68f35d84c0291a5c4b53;p=karo-tx-linux.git MIPS: Ralink: Use strlcpy() instead of strncpy(). 'compatible' is used by strlen() in __of_device_is_compatible(). Ensure strings are always '\0' terminated. 'of_ids is not a structure in "include/uapi/*", so no need to initialize it completly; using strlcpy() instead of strncpy() will do. Signed-off-by: Chen Gang Acked-by: John Crispin Cc: juhosg@openwrt.org Cc: linux-mips@linux-mips.org Cc: Linux-Arch Patchwork: https://patchwork.linux-mips.org/patch/5330/ Signed-off-by: Ralf Baechle --- diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c index fb1569580def..508f28fe19a5 100644 --- a/arch/mips/ralink/of.c +++ b/arch/mips/ralink/of.c @@ -104,7 +104,7 @@ static int __init plat_of_setup(void) if (!of_have_populated_dt()) panic("device tree not present"); - strncpy(of_ids[0].compatible, soc_info.compatible, len); + strlcpy(of_ids[0].compatible, soc_info.compatible, len); strncpy(of_ids[1].compatible, "palmbus", len); if (of_platform_populate(NULL, of_ids, NULL, NULL))