]> git.karo-electronics.de Git - linux-beck.git/log
linux-beck.git
8 years agoiio: ina2xx: Remove trace_printk debug statments
Andrew F. Davis [Wed, 24 Feb 2016 17:38:47 +0000 (11:38 -0600)]
iio: ina2xx: Remove trace_printk debug statments

These are generally for devlopment use only, remove these
from performance-critical code, convert to dev_dbg elswhere.

Signed-off-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: ina2xx: Fix whitespace and re-order code
Andrew F. Davis [Wed, 24 Feb 2016 17:38:46 +0000 (11:38 -0600)]
iio: ina2xx: Fix whitespace and re-order code

Group of probably overly rigorous whitespace and code cleanups.
 - Alphabetize includes
 - Assign to variables in the order they are defined
 - Alignment issues
 - Group alike statements together
 - Use helper macros

Signed-off-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: potentiometer: add TI tpl0102 support
Matt Ranostay [Mon, 22 Feb 2016 01:32:15 +0000 (17:32 -0800)]
iio: potentiometer: add TI tpl0102 support

Add support for the TI family of digital potentiometers.

Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: mpu6050: remove trailing whitespaces
Matt Ranostay [Thu, 18 Feb 2016 05:58:23 +0000 (21:58 -0800)]
iio: imu: mpu6050: remove trailing whitespaces

removed several trailing whitespaces before assignment operations

Signed-off-by: Matt Ranostay <matt.ranostay@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio:pressure:ms5611: power regulator support
Grégor Boirie [Wed, 17 Feb 2016 17:52:51 +0000 (18:52 +0100)]
iio:pressure:ms5611: power regulator support

Add support for an optional regulator which, if found into device-tree,
will power on device at probing time.
The regulator is declared into ms5611 DTS entry as a "vdd-supply" property.

Signed-off-by: Gregor Boirie <gregor.boirie@parrot.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio:pressure:ms5611: use probed device name
Grégor Boirie [Wed, 17 Feb 2016 17:52:50 +0000 (18:52 +0100)]
iio:pressure:ms5611: use probed device name

Use name of probed device instead of driver's one when registering device.

Signed-off-by: Gregor Boirie <gregor.boirie@parrot.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio:pressure:ms5611: fix ms5607 temp compensation
Gregor Boirie [Wed, 17 Feb 2016 17:52:49 +0000 (18:52 +0100)]
iio:pressure:ms5611: fix ms5607 temp compensation

Computation of sens2 was wrong and is fixed by this patch, sens2 should be:
    2 * (t - 2000)^2
See page 8 of ms5607 datasheet here:
    http://www.meas-spec.com/product/pressure/MS5607-02BA03.aspx

Signed-off-by: Gregor Boirie <gregor.boirie@parrot.com>
Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
Acked-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: inv_mpu6050: Fix alignment with open parenthesis
Daniel Baluta [Thu, 18 Feb 2016 15:53:12 +0000 (17:53 +0200)]
iio: imu: inv_mpu6050: Fix alignment with open parenthesis

This makes code consistent around inv_mpu6050 driver and
fixes the following checkpatch.pl warning:
CHECK: Alignment should match open parenthesis

Note that there were few cases were it was not possible to
fix this due to making the line too long, but we can live with that.

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: inv_mpu6050: Fix code indent for if statement
Daniel Baluta [Thu, 18 Feb 2016 15:53:11 +0000 (17:53 +0200)]
iio: imu: inv_mpu6050: Fix code indent for if statement

This fixes the following checkpatch.pl warning:

WARNING: suspect code indent for conditional statements (8, 24)
+       if (kfifo_len(&st->timestamps) >
[...]
+                       goto flush_fifo;

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: inv_mpu6050: Delete space before comma
Daniel Baluta [Thu, 18 Feb 2016 15:53:10 +0000 (17:53 +0200)]
iio: imu: inv_mpu6050: Delete space before comma

This fixes the following checkpatch.pl warning:

ERROR: space prohibited before that ',' (ctx:WxE)
.shift = 0 ,

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: inv_mpu6050: Remove unnecessary parentheses
Daniel Baluta [Thu, 18 Feb 2016 15:53:09 +0000 (17:53 +0200)]
iio: imu: inv_mpu6050: Remove unnecessary parentheses

Fixes the following checkpatch warning:
CHECK: Unnecessary parentheses around cpm->package.elements[i]

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: inv_mpu6050: Fix newlines to make code easier to read
Daniel Baluta [Thu, 18 Feb 2016 15:53:08 +0000 (17:53 +0200)]
iio: imu: inv_mpu6050: Fix newlines to make code easier to read

This fixes the following checkpatch.pl warnings:
* WARNING: Missing a blank line after declarations
* CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: inv_mpu6050: Fix Yoda conditions
Daniel Baluta [Thu, 18 Feb 2016 15:53:07 +0000 (17:53 +0200)]
iio: imu: inv_mpu6050: Fix Yoda conditions

This fixes the following checkpatch warning:
* WARNING: Comparisons should place the constant
  on the right side of the test

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Acked-by: Crt Mori <cmo@melexis.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: imu: inv_mpu6050: Fix multiline comments style
Daniel Baluta [Thu, 18 Feb 2016 15:53:06 +0000 (17:53 +0200)]
iio: imu: inv_mpu6050: Fix multiline comments style

The preffered style for long (multi-line) comments is:

/*
 * this is a multiline
 * comment
 */

This also fixes checkpatch.pl warning:
WARNING: Block comments use * on subsequent lines

Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: chemical: atlas-ph-sensor: use regmap_bulk_read
Matt Ranostay [Mon, 15 Feb 2016 02:59:07 +0000 (18:59 -0800)]
iio: chemical: atlas-ph-sensor: use regmap_bulk_read

Replaced i2c_smbus_read_i2c_block_data() with regmap_bulk_read()
function call. This is to make the driver code more consistent.

Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: hmc5843: Move hmc5843 out of staging
Cristina Moraru [Sun, 14 Feb 2016 22:37:39 +0000 (00:37 +0200)]
iio: hmc5843: Move hmc5843 out of staging

This patch moves hmc5843 driver from staging/iio/magnetometer
to iio/magnetometer, updates the corresponding Makefiles and
moves the hmc5843* entries to the 'Industrial I/O support ->
Magnetometer sensors' menu.

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: hmc5843: Add ABI documentation file for hmc5843
Cristina Moraru [Sun, 14 Feb 2016 22:37:38 +0000 (00:37 +0200)]
iio: hmc5843: Add ABI documentation file for hmc5843

Add ABI file documenting hmc5843 non-standard attributes
meas_conf and meas_conf_available for bias current
configuration.

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: hmc5843: Add attributes for measurement config of bias current
Cristina Moraru [Sun, 14 Feb 2016 22:37:37 +0000 (00:37 +0200)]
iio: hmc5843: Add attributes for measurement config of bias current

Change static attribute meas_conf for bias current configuration
to channel attribute in_magn_meas_conf and also add
in_magn_meas_conf_available attribute to view available configurations.

This patch solves functionality bug: driver was using same function
hmc5843_set_measurement_configuration for setting bias current config
for all device types but the function was returning -EINVAL for any
setting >= 0x03 although, for sensor HMC5983, value 3 is valid.

API for setting bias measurement configuration:

normal -  Normal measurement configuration (default):
In normal measurement configuration the device
follows normal measurement flow. Pins BP and BN
are left floating and high impedance.

positivebias -  Positive bias configuration: In positive bias
configuration, a positive current is forced across
the resistive load on pins BP and BN.

negativebias -  Negative bias configuration. In negative bias
configuration, a negative current is forced across
the resistive load on pins BP and BN.

disabled     -  Only available on HMC5983. Magnetic sensor is disabled.
Temperature sensor is enabled.

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
Cc: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: chemical: atlas-ph-sensor: switch regmap cache
Matt Ranostay [Sun, 14 Feb 2016 01:20:42 +0000 (17:20 -0800)]
iio: chemical: atlas-ph-sensor: switch regmap cache

switch from using REGCACHE_FLAT to REGCACHE_RBTREE so initial hw values
are read from device. This also allows some volatile ranges to be
dropped.

Note that REGCACHE_FLAT is intended only for very low lag cases so doesn't
do nice things like read initial values from the device.  Hence this change.

Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: Fix typos in the struct iio_event_spec documentation comments
William Breathitt Gray [Mon, 15 Feb 2016 17:47:42 +0000 (12:47 -0500)]
iio: Fix typos in the struct iio_event_spec documentation comments

This patch fixes a few minor typos in the documentation comments for the
scan_type member of the iio_event_spec structure. The sign member name
was improperly capitalized as "Sign" in the comments. The storagebits
member name was improperly listed as "storage_bits" in the comments. The
endianness member entry in the comments was moved after the repeat
member entry in order to maintain consistency with the actual struct
iio_event_spec layout.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: pressure: ms5611: select IIO_BUFFER
Arnd Bergmann [Tue, 16 Feb 2016 14:55:07 +0000 (15:55 +0100)]
iio: pressure: ms5611: select IIO_BUFFER

The ms5611 driver started using the IIO_TRIGGERED_BUFFER infrastructure
which in turn depend on IIO_BUFFER, and it produces a build error now
if that is not enabled:

warning: (... && MS5611 && ...) selects IIO_TRIGGERED_BUFFER which has unmet direct dependencies (IIO && IIO_BUFFER)
buffer/industrialio-triggered-buffer.c: In function 'iio_triggered_buffer_setup':
buffer/industrialio-triggered-buffer.c:58:2: error: implicit declaration of function 'iio_device_attach_buffer' [-Werror=implicit-function-declaration]
pressure/ms5611_core.c: In function 'ms5611_trigger_handler':
pressure/ms5611_core.c:193:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' [-Werror=implicit-function-declaration]

This adds the second select.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 713bbb4efb9d ("iio: pressure: ms5611: Add triggered buffer support")
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: health/afe4404: mark suspend/resume functions __maybe_unused
Arnd Bergmann [Mon, 15 Feb 2016 09:19:04 +0000 (10:19 +0100)]
iio: health/afe4404: mark suspend/resume functions __maybe_unused

The newly added afe4404 driver implements suspend/resume using the
SIMPLE_DEV_PM_OPS() macro, which leaves out references to the actual
functions when CONFIG_PM is disabled, causing a harmless warning:

health/afe4404.c:509:12: error: 'afe4404_suspend' defined but not used
health/afe4404.c:530:12: error: 'afe4404_resume' defined but not used

This marks the functions as __maybe_unused so we don't get those
warnings.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 87aec56e27ef ("iio: health: Add driver for the TI AFE4404 heart monitor")
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: health/afe4403: mark suspend/resume functions __maybe_unused
Arnd Bergmann [Mon, 15 Feb 2016 09:02:51 +0000 (10:02 +0100)]
iio: health/afe4403: mark suspend/resume functions __maybe_unused

The newly added afe4403 driver implements suspend/resume using the
SIMPLE_DEV_PM_OPS() macro, which leaves out references to the actual
functions when CONFIG_PM is disabled, causing a harmless warning:

health/afe4403.c:509:12: error: 'afe4403_suspend' defined but not used
health/afe4403.c:530:12: error: 'afe4403_resume' defined but not used

This marks the functions as __maybe_unused so we don't get those
warnings.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoiio: health/afe4403: select REGMAP_SPI
Arnd Bergmann [Tue, 16 Feb 2016 15:52:15 +0000 (16:52 +0100)]
iio: health/afe4403: select REGMAP_SPI

The newly added afe4403 driver uses the regmap facility to abstract
the I2C and SPI access. However, it fails to ensure that regmap_spi
is actually present:

drivers/iio/built-in.o: In function `afe4403_probe':
:(.text+0x9bf8): undefined reference to `__devm_regmap_init_spi'

This adds a Kconfig select statement like the afe4404 I2C driver
has.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: eec96d1e2d31 ("iio: health: Add driver for the TI AFE4403 heart monitor")
Acked-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
8 years agoPlatform: goldfish: goldfish_pipe.c: Add DMA support using managed version
Shraddha Barke [Fri, 12 Feb 2016 10:41:54 +0000 (16:11 +0530)]
Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version

Coherent mapping guarantees that the device and CPU are in sync.

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: xgifb: Fix comment style
Janani Ravichandran [Mon, 15 Feb 2016 05:57:38 +0000 (00:57 -0500)]
staging: xgifb: Fix comment style

Fix comments to use trailing */ on separate lines.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: vt6655: Add missing blank line after declaration
Janani Ravichandran [Mon, 15 Feb 2016 05:15:12 +0000 (00:15 -0500)]
staging: vt6655: Add missing blank line after declaration

Add missing blank line after declaration of variables. Issue found by
checkpatch.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: vt6655: Fit function header on the same line
Janani Ravichandran [Mon, 15 Feb 2016 05:25:23 +0000 (00:25 -0500)]
staging: vt6655: Fit function header on the same line

Improve readability by fitting all parts of the function header on the same line.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: goldfish: goldfish_nand: Return correct error code
Amitoj Kaur Chawla [Fri, 12 Feb 2016 08:39:49 +0000 (14:09 +0530)]
staging: goldfish: goldfish_nand: Return correct error code

The return value of devm_kzalloc on failure of allocation of memory should
be -ENOMEM and not -1.

Found using Coccinelle. A simplified version of the semantic patch
used is:

//<smpl>
@@
expression *e;
@@

e = devm_kzalloc(...);
if (e == NULL) {
...
return
- -1
+ -ENOMEM
;
}
//</smpl>

The single call site does not perform any checks on the return value, hence
no change is required at the call site.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: gdm724x: gdm_mux: Remove create_workqueue()
Amitoj Kaur Chawla [Sat, 13 Feb 2016 05:01:02 +0000 (10:31 +0530)]
staging: gdm724x: gdm_mux: Remove create_workqueue()

With concurrency managed workqueues, use of dedicated workqueues
can be replaced by using system_wq. Drop mux_rx_wq by using system_wq.

Since there is only one work item per mux_dev and different mux_devs
do not need to be ordered, increase of concurrency level by switching
to system_wq should not break anything.

cancel_work_sync() is used to ensure that work is not pending or
executing on any CPU.

Lastly, since all devices are suspended, which shutdowns the work item
before the driver can be unregistered, it is guaranteed that no work
item is pending or executing by the time exit path runs.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: nvec: Modify the nvec_write_sync method to return the error code
Tomás Tormo [Sun, 14 Feb 2016 19:30:56 +0000 (20:30 +0100)]
Staging: nvec: Modify the nvec_write_sync method to return the error code

Modify the nvec_write_sync function to return the error code
instead of the received message.

The received message is now returned as an output parameter.

Signed-off-by: Tomás Tormo <tomas.tormo@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: octeon-usb: support official bindings
Aaro Koskinen [Sun, 14 Feb 2016 00:47:28 +0000 (02:47 +0200)]
staging: octeon-usb: support official bindings

Support official DT bindings alongside with the deprecated ones.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: octeon: support fixed-link phys
Aaro Koskinen [Sun, 14 Feb 2016 00:45:30 +0000 (02:45 +0200)]
staging: octeon: support fixed-link phys

Support fixed-link PHYs. This allows to remove some of the board-specific
link cvmx_helper code in the future.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: speakup: Fix block comment style
Janani Ravichandran [Sun, 14 Feb 2016 03:05:01 +0000 (22:05 -0500)]
staging: speakup: Fix block comment style

Use trailing */ on a separate line when it is a block comment.
This patch fixes the last of the checkpatch warnings for the file.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: netlogic: Fix parenthesis alignment
Laura Garcia Liebana [Sun, 14 Feb 2016 17:55:23 +0000 (18:55 +0100)]
staging: netlogic: Fix parenthesis alignment

Align arguments with the open parenthesis. Checkpatch found this issue.

Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: netlogic: Remove multiple blank lines
Laura Garcia Liebana [Sun, 14 Feb 2016 15:26:13 +0000 (16:26 +0100)]
staging: netlogic: Remove multiple blank lines

Avoid the use of multiple blank lines. Checkpatch found this issue.

Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: netlogic: Fix multiple irq assignments in a single line
Laura Garcia Liebana [Sun, 14 Feb 2016 13:10:11 +0000 (14:10 +0100)]
staging: netlogic: Fix multiple irq assignments in a single line

Avoid the use of multiple assignments in a single line. Checkpatch
found this issue.

Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl819u: ieee80211: Remove function ieee80211_wep_null
Bhumika Goyal [Sat, 13 Feb 2016 11:12:32 +0000 (16:42 +0530)]
Staging: rtl819u: ieee80211: Remove function ieee80211_wep_null

Remove function ieee80211_wep_null from the file as is it blank and
remove its declaration from the header file.
Also remove its function call as it is of no use calling this function.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8723au: Replace header files
Bhumika Goyal [Fri, 12 Feb 2016 10:52:19 +0000 (16:22 +0530)]
Staging: rtl8723au: Replace header files

The headers <asm/uaccess.h>,<asm/atomic.h>,<asm/atomic.h> should not be
directly included so replace them.
Warning generated by checkpatch.pl.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: sm750fb: Fix indentation of if...else statements
Janani Ravichandran [Sun, 14 Feb 2016 03:59:06 +0000 (22:59 -0500)]
staging: sm750fb: Fix indentation of if...else statements

This patch clears the checkpatch warning about suspect code indent for
conditional statements in the file.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: sm750fb: Eliminate commented out code
Janani Ravichandran [Sun, 14 Feb 2016 03:48:42 +0000 (22:48 -0500)]
staging: sm750fb: Eliminate commented out code

This patch removes commented out code in the file.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: sm750fb: Remove unneeded braces in if...else statements
Janani Ravichandran [Sun, 14 Feb 2016 03:23:17 +0000 (22:23 -0500)]
staging: sm750fb: Remove unneeded braces in if...else statements

Remove unnecessary braces in if...else statements where both branches have a single statement each.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8192u: Remove useless comments
Bhumika Goyal [Sun, 14 Feb 2016 05:29:50 +0000 (10:59 +0530)]
Staging: rtl8192u: Remove useless comments

Remove the commented out places where macros PlatformAcquireSpinLock and
PlatformReleaseSpinLock are called as these macros are no longer used.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8723au: Remove unused macros
Bhumika Goyal [Sun, 14 Feb 2016 05:29:49 +0000 (10:59 +0530)]
Staging: rtl8723au: Remove unused macros

The macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are
not used anywhere so remove them. Used grep to find occurences.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8712: Remove unnecessary ret variable
Joseph Bisch [Sun, 14 Feb 2016 21:57:27 +0000 (16:57 -0500)]
staging: rtl8712: Remove unnecessary ret variable

Since the variable ret is set at the beginning of the function and
never changes its value, we can just return the value it was set to.

Found using coccinelle with misc/returnvar.cocci.

Signed-off-by: Joseph Bisch <joseph.bisch@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8712: Fixed a comparision coding style warning.
Rakhi Sharma [Sat, 13 Feb 2016 05:24:20 +0000 (10:54 +0530)]
staging: rtl8712: Fixed a comparision coding style warning.

WARNING: Comparisons should place the constant on the right side of the test
Fixed this warning by placing the constant on right side.

Signed-off-by: Rakhi Sharma <rakhish1994@gmail.com>-
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: iio: magnetometer: remove exceptional & on function name
Bhumika Goyal [Fri, 12 Feb 2016 15:10:29 +0000 (20:40 +0530)]
Staging: iio: magnetometer: remove exceptional & on function name

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: iio: light: remove exceptional & on function name
Bhumika Goyal [Fri, 12 Feb 2016 15:10:28 +0000 (20:40 +0530)]
Staging: iio: light: remove exceptional & on function name

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: iio: light: remove exceptional & on function name
Bhumika Goyal [Fri, 12 Feb 2016 15:10:27 +0000 (20:40 +0530)]
Staging: iio: light: remove exceptional & on function name

In this file,function names are otherwise used as pointers without &.
Found using coccinelle.
// <smpl>
@r@
identifier f;
@@

f(...) { ... }
@@
identifier r.f;
@@

- &f
+ f
// </smpl>

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rts5208: Place constants on the right side of comparisons
Janani Ravichandran [Sun, 14 Feb 2016 02:57:51 +0000 (21:57 -0500)]
staging: rts5208: Place constants on the right side of comparisons

Constants should be placed on the right hand side of comparisons. This
issue was identified by checkpatch.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rdma: hfi1: Delete NULL check before vfree
Bhumika Goyal [Sun, 14 Feb 2016 15:04:28 +0000 (20:34 +0530)]
Staging: rdma: hfi1: Delete NULL check before vfree

The function vfree test whether the argument is NULL and return
immediately. SO NULL test is not needed before vfree.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: rtl8188eu: os_dep: Remove NULL test before rtw_free_netdev
Bhumika Goyal [Sun, 14 Feb 2016 15:24:03 +0000 (20:54 +0530)]
Staging: rtl8188eu: os_dep: Remove NULL test before rtw_free_netdev

The function rtw_free_netdev test whether its argument is NULL and
return immediately. So NULL test before this function is not needed.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: Fix comment style
Janani Ravichandran [Sat, 13 Feb 2016 20:58:52 +0000 (15:58 -0500)]
staging: rtl8192u: ieee80211: Fix comment style

This patch changes some C99-style "//..." comments to C89 "/* ... */" style.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: Remove msleep_interruptible_rsl Macro
Amitoj Kaur Chawla [Sat, 13 Feb 2016 07:04:14 +0000 (12:34 +0530)]
staging: rtl8192u: ieee80211: Remove msleep_interruptible_rsl Macro

Remove driver specific macro msleep_interruptible_rsl as it has been
replaced by a direct call to msleep_interruptible in the single
instance referencing it.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: ieee80211_softmac: Replace driver specific macro msleep...
Amitoj Kaur Chawla [Sat, 13 Feb 2016 07:01:33 +0000 (12:31 +0530)]
staging: rtl8192u: ieee80211: ieee80211_softmac: Replace driver specific macro msleep_interruptible_rsl

Replace driver specific msleep_interruptible_rsl macro with direct
call to msleep_interruptible.

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Reviewed-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: Remove MSECS macro
Amitoj Kaur Chawla [Sat, 13 Feb 2016 04:34:23 +0000 (10:04 +0530)]
staging: rtl8192u: ieee80211: Remove MSECS macro

Remove driver specific macro MSECS since all instances of this macro
have been replaced by direct calls to msecs_to_jiffies().

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: r8192U_dm: Replace MSECS with msecs_to_jiffies
Amitoj Kaur Chawla [Sat, 13 Feb 2016 04:34:16 +0000 (10:04 +0530)]
staging: rtl8192u: r8192U_dm: Replace MSECS with msecs_to_jiffies

Replace driver specific macro MSECS with msecs_to_jiffies().

This was found using the following Coccinelle semantic patch:

//<smpl>
@@
expression e;
@@

- MSECS(e)
+ msecs_to_jiffies(e)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: ieee80211_rx: Replace MSECS with msecs_to_jiffies
Amitoj Kaur Chawla [Sat, 13 Feb 2016 04:34:10 +0000 (10:04 +0530)]
staging: rtl8192u: ieee80211: ieee80211_rx: Replace MSECS with msecs_to_jiffies

Replace driver specific macro MSECS with msecs_to_jiffies().

This was found using the following Coccinelle semantic patch:

//<smpl>
@@
expression e;
@@

- MSECS(e)
+ msecs_to_jiffies(e)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: ieee80211_softmac: Replace MSECS with msecs_to_jiffies
Amitoj Kaur Chawla [Sat, 13 Feb 2016 04:34:04 +0000 (10:04 +0530)]
staging: rtl8192u: ieee80211: ieee80211_softmac: Replace MSECS with msecs_to_jiffies

Replace driver specific macro MSECS with msecs_to_jiffies().

This was found using the following Coccinelle semantic patch:

//<smpl>
@@
expression e;
@@

- MSECS(e)
+ msecs_to_jiffies(e)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: rtl819x_BAProc: Replace MSECS with msecs_to_jiffies
Amitoj Kaur Chawla [Sat, 13 Feb 2016 04:33:54 +0000 (10:03 +0530)]
staging: rtl8192u: ieee80211: rtl819x_BAProc: Replace MSECS with msecs_to_jiffies

Replace driver specific macro MSECS with msecs_to_jiffies().

This was found using the following Coccinelle semantic patch:

//<smpl>
@@
expression e;
@@

- MSECS(e)
+ msecs_to_jiffies(e)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: rtl8192u: ieee80211: rtl819x_TSProc: Replace MSECS with msecs_to_jiffies
Amitoj Kaur Chawla [Sat, 13 Feb 2016 04:33:47 +0000 (10:03 +0530)]
staging: rtl8192u: ieee80211: rtl819x_TSProc: Replace MSECS with msecs_to_jiffies

Replace driver specific macro MSECS with msecs_to_jiffies().

This was found using the following Coccinelle semantic patch:

//<smpl>
@@
expression e;
@@

- MSECS(e)
+ msecs_to_jiffies(e)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agodrivers/staging/android: don't use modular references in sync_debug.c
Paul Gortmaker [Sat, 13 Feb 2016 23:20:17 +0000 (18:20 -0500)]
drivers/staging/android: don't use modular references in sync_debug.c

In commit 8a0044846115e74552b671a7073cffeec14b9316 ("staging/android:
create a 'sync' dir for debugfs information"), modular references were
introduced to this file.  However if we look, we find:

drivers/staging/android/Makefile:obj-$(CONFIG_SYNC) += sync.o sync_debug.o

drivers/staging/android/Kconfig:config SYNC
drivers/staging/android/Kconfig:        bool "Synchronization framework"

This file isn't currently buildable as a module, and hence the code
for module_exit is just dead code.  Remove it and the module.h include.

Cc: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: wlan-ng: Remove function prototype
Bhumika Goyal [Sat, 13 Feb 2016 13:19:35 +0000 (18:49 +0530)]
Staging: wlan-ng: Remove function prototype

This patch removes the function prototype for prism2mgmt_pstr2bytearea as
it is no longer needed.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: wlan-ng: Drop wrapper function
Bhumika Goyal [Sat, 13 Feb 2016 13:19:34 +0000 (18:49 +0530)]
Staging: wlan-ng: Drop wrapper function

Drop the function prism2mgmt_pstr2bytearea and replace its function call
with the standard function memcpy that it wrapped.
The code becomes cleaner after this patch.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: wlan-ng: Remove multiple assignments
Bhumika Goyal [Sat, 13 Feb 2016 06:18:02 +0000 (11:48 +0530)]
Staging: wlan-ng: Remove multiple assignments

Remove multiple assignments by factorizing them.
Made a coccinelle script to match cases:
@@
identifier a,b;
constant c;
@@
-a=b=c;
+a=c;
+b=c;

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: media: Remove multiple assignments
Bhumika Goyal [Sat, 13 Feb 2016 06:19:35 +0000 (11:49 +0530)]
Staging: media: Remove multiple assignments

Remove multiple assignments by factorizing them.
Made a coccinelle script to match cases:
@@
identifier a,b;
constant c;
@@
-a=b=c;
+a=c;
+b=c;

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: linux_mon.c: Remove unneeded braces
Janani Ravichandran [Sun, 14 Feb 2016 19:47:13 +0000 (14:47 -0500)]
staging: wilc1000: linux_mon.c: Remove unneeded braces

Remove braces around single statement blocks in if conditions as they
are not required.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: Simplify code by eliminating else block
Janani Ravichandran [Sun, 14 Feb 2016 05:09:33 +0000 (00:09 -0500)]
staging: wilc1000: Simplify code by eliminating else block

Remove else block here as it is not useful after the return statement in the corresponding if block. This simplifies code. This issue was identified by checkpatch.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: Remove useless return statement in a void function
Janani Ravichandran [Sun, 14 Feb 2016 04:53:23 +0000 (23:53 -0500)]
staging: wilc1000: Remove useless return statement in a void function

Remove the return statement at the end of the void function as it has
no purpose.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: Remove useless macros
Janani Ravichandran [Sun, 14 Feb 2016 04:31:48 +0000 (23:31 -0500)]
staging: wilc1000: Remove useless macros

Remove the macros FN_IN and FN_OUT as they haven't been used anywhere.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: Eliminate spaces between function names and open parentheses
Janani Ravichandran [Sun, 14 Feb 2016 04:26:49 +0000 (23:26 -0500)]
staging: wilc1000: Eliminate spaces between function names and open parentheses

Remove spaces between function names and open parentheses as they are
unnecessary.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: Eliminate extraneous braces
Janani Ravichandran [Sun, 14 Feb 2016 04:10:29 +0000 (23:10 -0500)]
staging: wilc1000: Eliminate extraneous braces

Get rid of extraneous braces enclosing single statement blocks.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: Include KERN_ facility level for printk()
Janani Ravichandran [Sun, 14 Feb 2016 04:19:10 +0000 (23:19 -0500)]
staging: wilc1000: Include KERN_ facility level for printk()

This patch includes KERN_ facility level for printk(). KERN_INFO is
justified here as the messages here are informational.

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: wilc_wfi_cfgoperations: remove cast on void pointers
Alison Schofield [Sat, 13 Feb 2016 06:54:08 +0000 (22:54 -0800)]
staging: wilc1000: wilc_wfi_cfgoperations: remove cast on void pointers

Remove cast on void pointers. C programming language guarantees
the conversion from void pointer to any other pointer type.

Coccinelle patch:
@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: linux_wlan: remove cast on void pointers
Alison Schofield [Sat, 13 Feb 2016 06:53:13 +0000 (22:53 -0800)]
staging: wilc1000: linux_wlan: remove cast on void pointers

Remove casts on void pointers. C programming language guarantees
the conversion from void pointer to any other pointer type.

Coccinelle patch:
@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: linux_mon: remove cast on void pointer
Alison Schofield [Sat, 13 Feb 2016 06:52:11 +0000 (22:52 -0800)]
staging: wilc1000: linux_mon: remove cast on void pointer

Remove cast on void pointer. C programming language guarantees
the conversion from void pointer to any other pointer type.

Coccinelle patch:
@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: host_interface: remove cast on void pointers
Alison Schofield [Sat, 13 Feb 2016 06:51:04 +0000 (22:51 -0800)]
staging: wilc1000: host_interface: remove cast on void pointers

Remove cast on void pointers. C programming language guarantees
the conversion from void pointer to any other pointer type.

Coccinelle patch:
@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: use netdev_err instead of PRINT_ER
Chaehyun Lim [Fri, 12 Feb 2016 14:04:47 +0000 (23:04 +0900)]
staging: wilc1000: use netdev_err instead of PRINT_ER

This patch uses netdev_err instead of PRINT_ER that is a custom debug
print.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: rename result in handle_set_channel
Chaehyun Lim [Fri, 12 Feb 2016 14:04:46 +0000 (23:04 +0900)]
staging: wilc1000: rename result in handle_set_channel

This patch renames result to ret that is used to get return value from
wilc_send_config_pkt.
Some handle_*() function are used as result, others are used as ret.
It will start to rename as ret in all handle_*() function to sync up
with this variable name.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: change data type of result variable to int.
Chaehyun Lim [Fri, 12 Feb 2016 14:04:45 +0000 (23:04 +0900)]
staging: wilc1000: change data type of result variable to int.

result variable gets value from wilc_send_config_pkt that has
return value of int. This patch changes data type of result variable to
int.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: change handle_set_channel's return type to void
Chaehyun Lim [Fri, 12 Feb 2016 14:04:44 +0000 (23:04 +0900)]
staging: wilc1000: change handle_set_channel's return type to void

When handle_set_channel is called in hostIFthread that is a kernel
thread, it is not checked return type of this function. This patch
changes return type to void and removes braces if statement due
to have a single statement.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: define a new local variable in wilc_scan
Chaehyun Lim [Fri, 12 Feb 2016 14:04:43 +0000 (23:04 +0900)]
staging: wilc1000: define a new local variable in wilc_scan

struct scan_info is defined as a new local variable in wilc_scan
function. It makes some assignment short as well as improve more
readability.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: rename u8security in user_conn_req
Chaehyun Lim [Fri, 12 Feb 2016 14:04:42 +0000 (23:04 +0900)]
staging: wilc1000: rename u8security in user_conn_req

This patch renames u8security to security to remove u8 prefix in struct
user_conn_req. There is no need to use prefix to show data type of this
variable.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: rename pu8ssid in struct user_conn_req
Chaehyun Lim [Fri, 12 Feb 2016 14:04:41 +0000 (23:04 +0900)]
staging: wilc1000: rename pu8ssid in struct user_conn_req

This patch renames pu8ssid to ssid to remove pu8 prefix in struct
user_conn_req. There is no need to use prefix to show data type of this
variable.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: rename pu8bssid in struct user_conn_req
Chaehyun Lim [Fri, 12 Feb 2016 14:04:40 +0000 (23:04 +0900)]
staging: wilc1000: rename pu8bssid in struct user_conn_req

This patch renames pu8bssid to bssid to remove pu8 prefix in struct
user_conn_req. There is no need to use prefix to show data type of this
variable.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: rename s8rssi in struct found_net_info
Chaehyun Lim [Fri, 12 Feb 2016 14:04:39 +0000 (23:04 +0900)]
staging: wilc1000: rename s8rssi in struct found_net_info

This patch renames s8rssi to rssi to remove s8 prefix in struct
found_net_info. There is no need to use prefix to show data type of this
variable.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: rename au8bssid in struct found_net_info
Chaehyun Lim [Fri, 12 Feb 2016 14:04:38 +0000 (23:04 +0900)]
staging: wilc1000: rename au8bssid in struct found_net_info

This patch renames au8bssid to bssid to remove au8 prefix. There is no
need to use prefix to show data type of this variable.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: wilc1000: rename au8bssid in struct join_bss_param
Chaehyun Lim [Fri, 12 Feb 2016 14:04:37 +0000 (23:04 +0900)]
staging: wilc1000: rename au8bssid in struct join_bss_param

This patch renames au8bssid to bssid to remove au8 prefix in struct
join_bss_param. There is no need to use prefix to show data type of this
variable.

Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: vt6656: move local var init into declaration
Alison Schofield [Fri, 12 Feb 2016 18:44:43 +0000 (10:44 -0800)]
staging: vt6656: move local var init into declaration

Improve readability by initializing local variables at declaration.

In one instance, vnt_start_interrupt_urb_complete(), also use that
local variable in subsequent switch.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: vt6656: replace GFP_ATOMIC with GFP_KERNEL for urb allocation
Alison Schofield [Fri, 12 Feb 2016 18:05:01 +0000 (10:05 -0800)]
staging: vt6656: replace GFP_ATOMIC with GFP_KERNEL for urb allocation

Replace GFP_ATOMIC with GFP_KERNEL during urb buffer allocation.
This makes vnt_alloc_bufs() consistent in setting GFP_KERNEL during
kmalloc() and usb_alloc_urb(). GFP_KERNEL is safe because we are in
process context, not in an interrupt handler, nor holding any spinlock.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: fbtft: Remove the use of CamelCase
Eva Rachel Retuya [Fri, 12 Feb 2016 07:39:30 +0000 (15:39 +0800)]
staging: fbtft: Remove the use of CamelCase

Rename the macro defining constant ROWxCOL into ROW_X_COL to remove
checkpatch check concerning use of CamelCase and to achieve better
readability.

CHECK: Avoid CamelCase: <ROWxCOL>

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: fbtft: Delete blank line after '{' brace
Eva Rachel Retuya [Fri, 12 Feb 2016 07:39:29 +0000 (15:39 +0800)]
staging: fbtft: Delete blank line after '{' brace

Omit the whitespace after '{' brace as suggested by checkpatch.

CHECK: Blank lines aren't necessary after an open brace '{'

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: fbtft: Insert blank line after function declaration
Eva Rachel Retuya [Fri, 12 Feb 2016 07:39:28 +0000 (15:39 +0800)]
staging: fbtft: Insert blank line after function declaration

Insert the required whitespace after the function declaration as
suggested by checkpatch.

CHECK: Please use a blank line after function/struct/union/enum
declarations

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: fbtft: Fix alignment to match open parenthesis
Eva Rachel Retuya [Fri, 12 Feb 2016 07:39:27 +0000 (15:39 +0800)]
staging: fbtft: Fix alignment to match open parenthesis

Fix alignment issues by properly indenting function parameters in
accordance to the kernel coding style. Checkpatch pointed out this
issue.

CHECK: Alignment should match open parenthesis

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: fbtft: Modify block comments based on kernel coding style
Eva Rachel Retuya [Fri, 12 Feb 2016 07:39:26 +0000 (15:39 +0800)]
staging: fbtft: Modify block comments based on kernel coding style

Add the required trailing * on subsequent lines as well as move the */
on a separate line. Checkpatch found this issue.

Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: lustre: obdclass: Declare function as static
Bhumika Goyal [Fri, 12 Feb 2016 06:23:28 +0000 (11:53 +0530)]
Staging: lustre: obdclass: Declare function as static

Declare the function cache_stats_print as static since it is used
only  in this file. Used grep to find occurences. Problem found using
sparse.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agoStaging: lustre: llite: Remove NULL check before kfree
Bhumika Goyal [Fri, 12 Feb 2016 14:37:54 +0000 (20:07 +0530)]
Staging: lustre: llite: Remove NULL check before kfree

NULL check before kfree is unnecessary so remove it.
Semantic patch used:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: obdclass: Use IS_ERR_OR_NULL
Amitoj Kaur Chawla [Sat, 13 Feb 2016 15:02:48 +0000 (20:32 +0530)]
staging: lustre: obdclass: Use IS_ERR_OR_NULL

Use macro IS_ERR_OR_NULL in place of tests for NULL and IS_ERR.

The Coccinelle semantic patch used to make the change is as follows:

//<smpl>
@@
expression e;
@@

- e == NULL || IS_ERR(e)
+ IS_ERR_OR_NULL(e)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre/lnet: Fix wrong typecasting warning generated by sparse
Niranjan Dighe [Sun, 14 Feb 2016 03:21:48 +0000 (08:51 +0530)]
staging: lustre/lnet: Fix wrong typecasting warning generated by sparse

Fix the following warning generated about type casting by sparse

warning: cast removes address space of expression

The current implementation casts the structure pointers with (char *)
without __user annotation and then adds sizeof struct to it, thereby
generating the sparse warning. Fixed this by removing the unnecessary
char pointer type cast.

Signed-off-by: Niranjan Dighe <niranjan.dighe@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
8 years agostaging: lustre: fix all conditional comparison to zero in LNet layer
James Simmons [Fri, 12 Feb 2016 17:06:09 +0000 (12:06 -0500)]
staging: lustre: fix all conditional comparison to zero in LNet layer

Doing if (rc != 0) or if (rc == 0) is bad form. This patch corrects
the LNet code to behavior according to kernel coding standards.

Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>