]>
git.karo-electronics.de Git - karo-tx-linux.git/log
Dave Jones [Thu, 25 Oct 2012 01:14:36 +0000 (12:14 +1100)]
selinux: fix sel_netnode_insert() suspicious rcu dereference
===============================
[ INFO: suspicious RCU usage. ]
3.5.0-rc1+ #63 Not tainted
-------------------------------
security/selinux/netnode.c:178 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 1, debug_locks = 0
1 lock held by trinity-child1/8750:
#0: (sel_netnode_lock){+.....}, at: [<
ffffffff812d8f8a >] sel_netnode_sid+0x16a/0x3e0
stack backtrace:
Pid: 8750, comm: trinity-child1 Not tainted 3.5.0-rc1+ #63
Call Trace:
[<
ffffffff810cec2d >] lockdep_rcu_suspicious+0xfd/0x130
[<
ffffffff812d91d1 >] sel_netnode_sid+0x3b1/0x3e0
[<
ffffffff812d8e20 >] ? sel_netnode_find+0x1a0/0x1a0
[<
ffffffff812d24a6 >] selinux_socket_bind+0xf6/0x2c0
[<
ffffffff810cd1dd >] ? trace_hardirqs_off+0xd/0x10
[<
ffffffff810cdb55 >] ? lock_release_holdtime.part.9+0x15/0x1a0
[<
ffffffff81093841 >] ? lock_hrtimer_base+0x31/0x60
[<
ffffffff812c9536 >] security_socket_bind+0x16/0x20
[<
ffffffff815550ca >] sys_bind+0x7a/0x100
[<
ffffffff816c03d5 >] ? sysret_check+0x22/0x5d
[<
ffffffff810d392d >] ? trace_hardirqs_on_caller+0x10d/0x1a0
[<
ffffffff8133b09e >] ? trace_hardirqs_on_thunk+0x3a/0x3f
[<
ffffffff816c03a9 >] system_call_fastpath+0x16/0x1b
This patch below does what Paul McKenney suggested in the previous thread.
Signed-off-by: Dave Jones <davej@redhat.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: Paul Moore <paul@paul-moore.com>
Cc: Eric Paris <eparis@parisplace.org>
Cc: James Morris <jmorris@namei.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Corey Minyard [Thu, 25 Oct 2012 01:14:36 +0000 (12:14 +1100)]
CRIS: Fix I/O macros
The inb/outb macros for CRIS are broken from a number of points of view,
missing () around parameters and they have an unprotected if statement in
them. This was breaking the compile of IPMI on CRIS and thus I was being
annoyed by build regressions, so I fixed them.
Plus I don't think they would have worked at all, since the data values
were missing "&" and the outsl had a "3" instead of a "4" for the size.
From what I can tell, this stuff is not used at all, so this can't be any
more broken than it was before, anyway.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Mikael Starvik <starvik@axis.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Dan Carpenter [Thu, 25 Oct 2012 01:14:35 +0000 (12:14 +1100)]
memstick: memory leak on error in msb_ftl_scan()
We need to free "overwrite_flags" before returning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Maxim Levitsky <maximlevitsly@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Dan Carpenter [Thu, 25 Oct 2012 01:14:35 +0000 (12:14 +1100)]
memstick: use after free in msb_disk_release()
The original code dereferenced "msb" after freeing it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Maxim Levitsky <maximlevitsly@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Maxim Levitsky [Thu, 25 Oct 2012 01:14:35 +0000 (12:14 +1100)]
memstick: ms_block: fix compile issue
As suggested by Geert Uytterhoeven:
: http://kisskb.ellerman.id.au/kisskb/buildresult/
7280352 /
: arch/m68k/include/asm/hardirq.h:23:20: error: expected ')' before 'DRIVER_NAME'
: make[4]: *** [drivers/memstick/core/ms_block.o] Error 1
:
: The reason for this is that pr_fmt() references DRIVER_NAME and is defined
: before the first include, while DRIVER_NAME is only defined in ms_block.h,
: which is the last included file. If any subsequent include file uses
: pr_fmt() (e.g. the call to pr_crit() in arch/m68k/include/asm/hardirq.h),
: this causes a build failure.
:
: I suggest moving the DRIVER_NAME define to ms_block.c. Cfr. memstick.c
: and mspro_block.c, who already have their own definition.
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alex Dubov <oakad@yahoo.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Maxim Levitsky [Thu, 25 Oct 2012 01:14:34 +0000 (12:14 +1100)]
memstick: remove unused field from state struct
Oops, I forgot that I have thet field there already. Just save memory by
not allocating it.
Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Alex Dubov <oakad@yahoo.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Stanislav Kinsbursky [Thu, 25 Oct 2012 01:14:34 +0000 (12:14 +1100)]
proc: check vma->vm_file before dereferencing
7b540d0646ce ("proc_map_files_readdir(): don't bother with grabbing
files") switched proc_map_files_readdir() to use @f_mode directly instead of
grabbing @file reference, but same time the test for @vm_file presence was
lost leading to nil dereference. The patch brings the test back.
The all proc_map_files feature is CONFIG_
\10 CHECKPOINT_RESTORE wrapped
(which is set to 'n' by default) so the bug doesn't affect regular
kernels.
The regression is 3.7-rc1 only as far as I can tell.
[gorcunov@openvz.org: provided changelog]
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Mel Gorman [Thu, 25 Oct 2012 01:14:33 +0000 (12:14 +1100)]
mm: vmscan: scale number of pages reclaimed by reclaim/compaction only in direct reclaim
Jiri Slaby reported the following:
(It's an effective revert of "mm: vmscan: scale number of pages
reclaimed by reclaim/compaction based on failures".)
Given kswapd had hours of runtime in ps/top output yesterday in the
morning and after the revert it's now 2 minutes in sum for the last 24h,
I would say, it's gone.
The intention of the patch in question was to compensate for the loss of
lumpy reclaim. Part of the reason lumpy reclaim worked is because it
aggressively reclaimed pages and this patch was meant to be a sane
compromise.
When compaction fails, it gets deferred and both compaction and
reclaim/compaction is deferred avoid excessive reclaim. However, since
commit
c6543459 ("mm: remove __GFP_NO_KSWAPD"), kswapd is woken up each
time and continues reclaiming which was not taken into account when the
patch was developed.
As it is not taking deferred compaction into account in this path it scans
aggressively before falling out and making the compaction_deferred check
in compaction_ready. This patch avoids kswapd scaling pages for reclaim
and leaves the aggressive reclaim to the process attempting the THP
allocation.
Signed-off-by: Mel Gorman <mgorman@suse.de>
Reported-by: Jiri Slaby <jslaby@suse.cz>
Cc: Rik van Riel <riel@redhat.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Stephen Rothwell [Mon, 29 Oct 2012 03:16:05 +0000 (14:16 +1100)]
Merge branch 'akpm-current/current'
Conflicts:
tools/testing/selftests/epoll/test_epoll.c
Stephen Rothwell [Mon, 29 Oct 2012 03:10:30 +0000 (14:10 +1100)]
Merge remote-tracking branch 'drop-experimental/linux-next'
Stephen Rothwell [Mon, 29 Oct 2012 03:08:42 +0000 (14:08 +1100)]
Merge remote-tracking branch 'lzo-update/lzo-update'
Stephen Rothwell [Mon, 29 Oct 2012 03:07:06 +0000 (14:07 +1100)]
Merge remote-tracking branch 'random/dev'
Stephen Rothwell [Mon, 29 Oct 2012 03:00:13 +0000 (14:00 +1100)]
Merge remote-tracking branch 'signal/for-next'
Conflicts:
arch/sparc/kernel/sys_sparc_64.c
Stephen Rothwell [Mon, 29 Oct 2012 02:53:36 +0000 (13:53 +1100)]
Merge remote-tracking branch 'dma-buf/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:51:56 +0000 (13:51 +1100)]
Merge remote-tracking branch 'kvmtool/master'
Stephen Rothwell [Mon, 29 Oct 2012 02:50:16 +0000 (13:50 +1100)]
Merge remote-tracking branch 'tegra/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:48:37 +0000 (13:48 +1100)]
Merge remote-tracking branch 'samsung/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:46:56 +0000 (13:46 +1100)]
Merge remote-tracking branch 'renesas/next'
Stephen Rothwell [Mon, 29 Oct 2012 02:45:14 +0000 (13:45 +1100)]
Merge remote-tracking branch 'ixp4xx/next'
Stephen Rothwell [Mon, 29 Oct 2012 02:45:12 +0000 (13:45 +1100)]
Merge remote-tracking branch 'ep93xx/ep93xx-for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:43:31 +0000 (13:43 +1100)]
Merge remote-tracking branch 'cortex/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:41:53 +0000 (13:41 +1100)]
Merge remote-tracking branch 'bcm2835/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:40:09 +0000 (13:40 +1100)]
Merge remote-tracking branch 'arm-soc/for-next'
Conflicts:
arch/arm/Kconfig
arch/arm/mach-ux500/cpu-db8500.c
Stephen Rothwell [Mon, 29 Oct 2012 02:38:29 +0000 (13:38 +1100)]
Merge remote-tracking branch 'gpio-lw/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:38:13 +0000 (13:38 +1100)]
Merge remote-tracking branch 'vhost/linux-next'
Conflicts:
drivers/net/tun.c
Stephen Rothwell [Mon, 29 Oct 2012 02:36:18 +0000 (13:36 +1100)]
Merge remote-tracking branch 'pinctrl/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:29:43 +0000 (13:29 +1100)]
Merge remote-tracking branch 'tmem/linux-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:28:08 +0000 (13:28 +1100)]
Merge remote-tracking branch 'char-misc/char-misc-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:26:13 +0000 (13:26 +1100)]
Merge remote-tracking branch 'staging/staging-next'
Conflicts:
drivers/staging/comedi/drivers/amplc_dio200.c
Stephen Rothwell [Mon, 29 Oct 2012 02:23:58 +0000 (13:23 +1100)]
Merge remote-tracking branch 'usb/usb-next'
Conflicts:
drivers/usb/misc/ezusb.c
Stephen Rothwell [Mon, 29 Oct 2012 02:21:38 +0000 (13:21 +1100)]
Merge remote-tracking branch 'tty/tty-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:19:57 +0000 (13:19 +1100)]
Merge remote-tracking branch 'driver-core/driver-core-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:18:19 +0000 (13:18 +1100)]
Merge remote-tracking branch 'leds/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:16:31 +0000 (13:16 +1100)]
Merge remote-tracking branch 'regmap/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:14:38 +0000 (13:14 +1100)]
Merge remote-tracking branch 'drivers-x86/linux-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:13:00 +0000 (13:13 +1100)]
Merge remote-tracking branch 'workqueues/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:11:08 +0000 (13:11 +1100)]
Merge remote-tracking branch 'xen-two/linux-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:09:22 +0000 (13:09 +1100)]
Merge remote-tracking branch 'kvm-ppc/kvm-ppc-next'
Stephen Rothwell [Mon, 29 Oct 2012 02:07:38 +0000 (13:07 +1100)]
Merge remote-tracking branch 'kvm/linux-next'
Conflicts:
arch/powerpc/include/asm/Kbuild
arch/powerpc/include/asm/kvm_para.h
Stephen Rothwell [Mon, 29 Oct 2012 02:00:07 +0000 (13:00 +1100)]
Merge remote-tracking branch 'rcu/rcu/next'
Stephen Rothwell [Mon, 29 Oct 2012 01:52:39 +0000 (12:52 +1100)]
Merge remote-tracking branch 'tip/auto-latest'
Stephen Rothwell [Mon, 29 Oct 2012 01:51:00 +0000 (12:51 +1100)]
Merge remote-tracking branch 'spi-mb/spi-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:49:22 +0000 (12:49 +1100)]
Merge remote-tracking branch 'dt-rh/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:47:38 +0000 (12:47 +1100)]
Merge remote-tracking branch 'edac-amd/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:45:53 +0000 (12:45 +1100)]
Merge remote-tracking branch 'edac/linux_next'
Stephen Rothwell [Mon, 29 Oct 2012 01:44:12 +0000 (12:44 +1100)]
Merge remote-tracking branch 'fsnotify/for-next'
Conflicts:
kernel/audit_tree.c
Stephen Rothwell [Mon, 29 Oct 2012 01:36:38 +0000 (12:36 +1100)]
Merge remote-tracking branch 'pm/linux-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:34:56 +0000 (12:34 +1100)]
Merge remote-tracking branch 'trivial/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:33:18 +0000 (12:33 +1100)]
Merge remote-tracking branch 'osd/linux-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:28:06 +0000 (12:28 +1100)]
Merge remote-tracking branch 'iommu/next'
Stephen Rothwell [Mon, 29 Oct 2012 01:26:19 +0000 (12:26 +1100)]
Merge remote-tracking branch 'watchdog/master'
Stephen Rothwell [Mon, 29 Oct 2012 01:26:13 +0000 (12:26 +1100)]
Merge remote-tracking branch 'selinux/master'
Stephen Rothwell [Mon, 29 Oct 2012 01:19:21 +0000 (12:19 +1100)]
Merge remote-tracking branch 'security/next'
Conflicts:
fs/cifs/cifsacl.c
net/dns_resolver/dns_key.c
security/keys/keyctl.c
security/keys/keyring.c
security/keys/process_keys.c
Stephen Rothwell [Mon, 29 Oct 2012 01:17:38 +0000 (12:17 +1100)]
Merge remote-tracking branch 'regulator/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:15:43 +0000 (12:15 +1100)]
Merge remote-tracking branch 'md/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:08:35 +0000 (12:08 +1100)]
Merge remote-tracking branch 'slab/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:08:26 +0000 (12:08 +1100)]
Merge remote-tracking branch 'kgdb/kgdb-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:06:49 +0000 (12:06 +1100)]
Merge remote-tracking branch 'mmc/mmc-next'
Stephen Rothwell [Mon, 29 Oct 2012 01:05:02 +0000 (12:05 +1100)]
Merge branch 'quilt/device-mapper'
Stephen Rothwell [Mon, 29 Oct 2012 01:03:21 +0000 (12:03 +1100)]
Merge remote-tracking branch 'block/for-next'
Conflicts:
init/Kconfig
Stephen Rothwell [Mon, 29 Oct 2012 00:58:59 +0000 (11:58 +1100)]
Merge remote-tracking branch 'cgroup/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 00:57:12 +0000 (11:57 +1100)]
Merge remote-tracking branch 'input/next'
Stephen Rothwell [Mon, 29 Oct 2012 00:55:37 +0000 (11:55 +1100)]
Merge remote-tracking branch 'virtio/virtio-next'
Stephen Rothwell [Mon, 29 Oct 2012 00:48:48 +0000 (11:48 +1100)]
Merge remote-tracking branch 'modules/modules-next'
Stephen Rothwell [Mon, 29 Oct 2012 00:46:55 +0000 (11:46 +1100)]
Merge commit 'refs/next/
20121026 /sound-asoc'
Stephen Rothwell [Mon, 29 Oct 2012 00:35:25 +0000 (11:35 +1100)]
Merge remote-tracking branch 'sound/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 00:33:48 +0000 (11:33 +1100)]
Merge remote-tracking branch 'crypto/master'
Stephen Rothwell [Mon, 29 Oct 2012 00:32:09 +0000 (11:32 +1100)]
Merge remote-tracking branch 'l2-mtd/master'
Stephen Rothwell [Mon, 29 Oct 2012 00:30:34 +0000 (11:30 +1100)]
Merge remote-tracking branch 'mtd/master'
Stephen Rothwell [Mon, 29 Oct 2012 00:28:58 +0000 (11:28 +1100)]
Merge remote-tracking branch 'bluetooth/master'
Stephen Rothwell [Mon, 29 Oct 2012 00:26:55 +0000 (11:26 +1100)]
Merge remote-tracking branch 'wireless-next/master'
Stephen Rothwell [Mon, 29 Oct 2012 00:23:08 +0000 (11:23 +1100)]
Merge remote-tracking branch 'net-next/master'
Stephen Rothwell [Mon, 29 Oct 2012 00:21:29 +0000 (11:21 +1100)]
Merge remote-tracking branch 'slave-dma/next'
Stephen Rothwell [Mon, 29 Oct 2012 00:19:35 +0000 (11:19 +1100)]
Merge remote-tracking branch 'target-updates/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 00:17:56 +0000 (11:17 +1100)]
Merge remote-tracking branch 'ubi/linux-next'
Stephen Rothwell [Mon, 29 Oct 2012 00:16:16 +0000 (11:16 +1100)]
Merge remote-tracking branch 'thermal/next'
Stephen Rothwell [Mon, 29 Oct 2012 00:16:09 +0000 (11:16 +1100)]
Merge remote-tracking branch 'cpuidle/cpuidle-next'
Conflicts:
drivers/cpuidle/coupled.c
include/linux/cpuidle.h
Stephen Rothwell [Mon, 29 Oct 2012 00:15:44 +0000 (11:15 +1100)]
Merge remote-tracking branch 'kbuild/for-next'
Stephen Rothwell [Mon, 29 Oct 2012 00:13:29 +0000 (11:13 +1100)]
Merge commit 'refs/next/
20121026 /v4l-dvb'
Stephen Rothwell [Sun, 28 Oct 2012 23:59:47 +0000 (10:59 +1100)]
Merge remote-tracking branch 'hwmon-staging/hwmon-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:58:16 +0000 (10:58 +1100)]
Merge branch 'quilt/jdelvare-hwmon'
Stephen Rothwell [Sun, 28 Oct 2012 23:56:43 +0000 (10:56 +1100)]
Merge branch 'quilt/i2c'
Stephen Rothwell [Sun, 28 Oct 2012 23:55:08 +0000 (10:55 +1100)]
Merge remote-tracking branch 'hid/for-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:53:38 +0000 (10:53 +1100)]
Merge remote-tracking branch 'vfs/for-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:52:02 +0000 (10:52 +1100)]
Merge remote-tracking branch 'xfs/for-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:50:22 +0000 (10:50 +1100)]
Merge remote-tracking branch 'ubifs/linux-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:50:14 +0000 (10:50 +1100)]
Merge remote-tracking branch 'v9fs/for-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:48:23 +0000 (10:48 +1100)]
Merge remote-tracking branch 'ocfs2/linux-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:46:47 +0000 (10:46 +1100)]
Merge remote-tracking branch 'nfs/linux-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:45:11 +0000 (10:45 +1100)]
Merge remote-tracking branch 'logfs/master'
Stephen Rothwell [Sun, 28 Oct 2012 23:43:42 +0000 (10:43 +1100)]
Merge remote-tracking branch 'gfs2/master'
Stephen Rothwell [Sun, 28 Oct 2012 23:41:59 +0000 (10:41 +1100)]
Merge remote-tracking branch 'fuse/for-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:40:25 +0000 (10:40 +1100)]
Merge remote-tracking branch 'cifs/for-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:38:50 +0000 (10:38 +1100)]
Merge remote-tracking branch 'ceph/master'
Stephen Rothwell [Sun, 28 Oct 2012 23:37:14 +0000 (10:37 +1100)]
Merge remote-tracking branch 'xtensa/for_next'
Stephen Rothwell [Sun, 28 Oct 2012 23:35:45 +0000 (10:35 +1100)]
Merge remote-tracking branch 'unicore32/unicore32'
Stephen Rothwell [Sun, 28 Oct 2012 23:34:13 +0000 (10:34 +1100)]
Merge remote-tracking branch 's390/features'
Stephen Rothwell [Sun, 28 Oct 2012 23:32:43 +0000 (10:32 +1100)]
Merge remote-tracking branch 'mpc5xxx/next'
Stephen Rothwell [Sun, 28 Oct 2012 23:32:40 +0000 (10:32 +1100)]
Merge remote-tracking branch 'parisc/for-next'
Stephen Rothwell [Sun, 28 Oct 2012 23:31:09 +0000 (10:31 +1100)]
Merge remote-tracking branch 'openrisc/for-upstream'