Move the exports for the variables that are in range.c into the
file itself. These variables should be prefixed with comedi_ but
that's for a different patch...
Linus Lüssing [Mon, 22 Mar 2010 21:46:15 +0000 (22:46 +0100)]
Staging: batman-adv: Fixing wrap-around bug in vis
When the seqno for a vis packet had a wrap around from i.e. 255 to 0,
add_packet() would falsely claim the older packet with the seqno 255 as
newer as the one with the seqno of 0 and would therefore ignore the new
packet. This happens with all following vis packets until the old vis
packet expires after 180 seconds timeout. This patch fixes this issue
and gets rid of these highly undesired 3min. breaks for the vis-server.
Signed-off-by: Linus Lüssing <linus.luessing@web.de> Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Linus Lüssing [Mon, 22 Mar 2010 21:46:14 +0000 (22:46 +0100)]
Staging: batman-adv: Fix VIS output bug for secondary interfaces
TQ and HNA records for originators on secondary interfaces were
wrongly being included on the primary interface. Ensure we output a
line for each source interface on every node, so we correctly separate
primary and secondary interface records.
Andrew Lunn [Mon, 22 Mar 2010 21:46:13 +0000 (22:46 +0100)]
Staging: batman-adv: don't have interrupts disabled while sending.
send_vis_packets() would disable interrupts before calling
dev_queue_xmit() which resulting in a backtrace in local_bh_enable().
Fix this by using kref on the vis_info object so that we can call
send_vis_packets() without holding vis_hash_lock. vis_hash_lock also
used to protect recv_list, so we now need a new lock to protect that
instead of vis_hash_lock.
Also a few checkpatch cleanups.
Reported-by: Linus Lüssing <linus.luessing@web.de> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de> Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This driver is written (almost) from scratch, using the
allocator developed for dt3155pci see bellow). The driver
uses videobuf-dma-contig interface modified to use the above
mentioned allocator instead of dma_alloc_coheren().
The first thing to do was to design a new allocator based
on allocating a configurable number of 4MB chunks of memory,
that latter are broken into frame buffers of 768x576 bytes
kept in different FIFOs (queues). As far as the driver autoloads
as a kernel module during kernel boot, the allocation of 4MB
chunks succeeds.
The driver keeps three FIFOs: one for 4MB chunks, one for free
buffers (available for allocations) and one for buffers already
allocated. Allocation/deallocation is done automatically though
the video4linux videobuf subsystem (some pointers to functions
are replaced by driver supplied functions).
Sure, there are problems:
1. The device tested to work with "xawtv -f" either via read()
method (DT3155_STREAMING not selected), or via mmap() method
(DT3155_STREAMING is selected) only. This coresponds to either
cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE;
or
cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
but not when
cap->capabilities = V4L2_CAP_VIDEO_CAPTURE |
V4L2_CAP_STREAMING |
V4L2_CAP_READWRITE;
This is because xawtv calls poll() before starting streaming,
but videobuf_poll_stream() automatically starts reading if streaming
is not started.
This selection is made during kernel configuration (for now).
2. Works for CCIR, but should work for RS-170 (not tested)
This is made also during kernel configuration.
3. Could work for multiple dt3155 frame grabbers in a PC,
(private data is allocated during PCI probe() method), but
is not tested due to lack of a second board.
Staging: comedi: use the standard NI pci device id
Don't redefine something that we already have in the core
kernel. Also move to use PCI_DEVICE() macros to make things
a bit simpler when changing the define.
Randy Dunlap [Thu, 29 Apr 2010 17:46:32 +0000 (10:46 -0700)]
Staging: memrar: fix printk format warning
Fix printk format warning in memrar:
drivers/staging/memrar/memrar_handler.c:393: warning: format '%u' expects type 'unsigned int', but argument 4 has type 'size_t'
Yong Wang [Fri, 23 Apr 2010 08:26:42 +0000 (16:26 +0800)]
Staging: rtl8192e: Use the standard config option for PM functions
Use the standard config option CONFIG_PM to enable rtl8192e PM
functions. Tested on Samsung N140 and it works fine. Without enabling
the PM functions, the box always fails to resume.
Signed-off-by: Yong Wang <yong.y.wang@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andres More [Tue, 13 Apr 2010 22:43:07 +0000 (19:43 -0300)]
Staging: vt6656: struct usb_driver cleanup
Code cleanup following other USB drivers:
- Renamed driver struct and callbacks to vt6656_*
- Added __init/__exit like directives
- Resolved checkpatch.pl findings on those lines
Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Texas Instruments BT, FM and GPS combo chips/drivers
make use of a single TTY to communicate with the chip.
This is the common header file for both the ST driver and the
protocol drivers which intend to use ST as their mode of
transport.
Texas Instruments BT, FM and GPS combo chips/drivers
make use of a single TTY to communicate with the chip.
This module constitutes the proprietary power management
protocol from TI for the BT/FM/GPS combo chips
Texas Instruments BT, FM and GPS combo chips/drivers
make use of a single TTY to communicate with the chip.
This module constitutes the core logic, TTY ldisc driver
and the exported symbols for registering/unregistering of
the protocol drivers such as BT/FM/GPS.
Andres More [Sun, 11 Apr 2010 18:59:01 +0000 (15:59 -0300)]
staging: vt6656: cleared checkpatch.pl findings in 80211hdr.h
Code cleanup in:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Findings were:
do not use C99 // comments
space required after that close brace '}'
line over 80 characters
Signed-off-by: Andres More <more.andres@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
John Church [Thu, 8 Apr 2010 21:04:17 +0000 (16:04 -0500)]
Staging: rtl8187se: fix coding style issues in r8180_core.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by: John Church <j.church@ymail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Samuel Ortiz [Fri, 9 Apr 2010 22:33:18 +0000 (00:33 +0200)]
Staging: rtl8187se: Do not mess with carrier settings while scanning
Toggling the link carrier is a non sense and is the grossest locking I can
think of. Moreover, it's giving a completely inaccurate status to userspace
who could for example decide to turn the interface down on carrier off
detection.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Samuel Ortiz [Fri, 9 Apr 2010 22:33:19 +0000 (00:33 +0200)]
Staging: rtl8187se: Do not send NULL BSSID events when not associated
If we're not associated, we should not send wireless events to let userspace
know that we just left an ESSID, simply because we havent yet joined it.
If we keep on doing that, wpa_supplicant could receive such events while
actually trying to join an ESSID, and thus decide to stop trying. This leads
to a lot of connection failures as this driver seems to be sending GIWAP
events quite a lot.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Samuel Ortiz [Fri, 9 Apr 2010 22:33:17 +0000 (00:33 +0200)]
Staging: rtl8187se: Do not autoconnect based on probe response
Getting a probe response after sending a probe request to a specific SSID
doesnt mean we're trying to associate with this SSID.
wpa_supplicant should be the only one deciding when to join an SSID, not the
kernel.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Fixed almost all the issues given by checkpatch.pl except for one
warning about an 81 character line, which cannot really be decomposed
(the code is a bit too nested there).
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Johan Meiring [Sun, 28 Mar 2010 19:36:09 +0000 (21:36 +0200)]
Staging: line6: rewrote inline comments in control.h
This is a patch to control.h that presents certain inline comments in a
neater way, and which eliminates the 80 character error found by the
checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Wed, 17 Mar 2010 09:02:49 +0000 (11:02 +0200)]
Staging: wlags49_h2: fix trailing statements coding style issue in dhf.c
This is a patch to the dhf.c file that fixed up a trailing statements
Errors found by the checkpatch.pl tools, like
trailing statements should be on next line
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 20:46:24 +0000 (22:46 +0200)]
Staging: wlags49_h2: fix spaces, macros and comments coding style issue in debug.h
This is a patch to the debug.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
and
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
and
do not use C99 // comments
and
Macros with complex values should be enclosed in parenthesis
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Richard Kennedy [Wed, 17 Mar 2010 14:40:57 +0000 (14:40 +0000)]
Staging: wlan-ng: refactor p80211wext.c to reduce text size.
Refactor the wext interface to reduce lines of code & module text size.
- add a helper function p80211wext_getmib
- rename p80211wext_dorequest to p80211wext_setmib
- refactor wext to call the get/set mib helpers and so reduce repeated code.
size reported text reduction :-
text data bss dec hex filename
8343 720 0 9063 2367 p80211wext.o.patch
9907 720 0 10631 2987 p80211wext.o.orig
Tested on x86_32 laptop, everything works correctly using NetworkManager,
and iwconfig & iwlist return sensible results when reading from the card.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Mon, 15 Mar 2010 19:27:42 +0000 (21:27 +0200)]
Staging: wlan-ng: fix spaces coding style issue in p80211conv.c
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Sun, 28 Mar 2010 06:38:57 +0000 (08:38 +0200)]
Staging: winbond: wb35rx.c Coding style fixes v2.
New patch that fixes an unclear comment too.
I fixed checkpatch issues except for long lines and printk:s.
I also removed version comments and the () in a return statement.
Generated .o is identical to master and i checked the code with
Dan Carpenters strip_whitespace.pl and diff.
Signed-off-by: Lars Lindley <lindley@coyote.org> Acked-by: Dan Carpenter <error27@gmail.com> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Thu, 25 Mar 2010 13:44:53 +0000 (14:44 +0100)]
Staging: winbond: wb35reg.c Coding style fixes
I fixed the problems reported by checkpatch.pl excetp for
long lines, a couple of printks and some warnings about usb_free_urb(NULL).
I checked for regressions with Dan Carpenters strip_whitespace.pl
and diff and everything looks good.
Generated .o is identical to master.
This is a new patch against master where I fixed up a switch-statement
after comments from Pavel Machek.
Signed-off-by: Lars Lindley <lindley@coyote.org> Acked-by: Pavel Machek <pavel@ucw.cz> Acked-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
projects / linux-beck.git / log