]> git.karo-electronics.de Git - karo-tx-linux.git/log
karo-tx-linux.git
13 years agoMAINTAINERS: the staging tree dropped the "-2.6" suffix
Greg Kroah-Hartman [Mon, 3 Oct 2011 23:02:41 +0000 (16:02 -0700)]
MAINTAINERS: the staging tree dropped the "-2.6" suffix

Now that we are in the 3.x days, "2.6" doesn't make sense.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: send suspend messages synchronously
Marc Dietrich [Tue, 27 Sep 2011 17:01:08 +0000 (19:01 +0200)]
staging: nvec: send suspend messages synchronously

The suspend commands need to be sent using the
synchronous method, otherwise the power gets
disabled before the messages are transferred.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
[jak@jak-linux.org: Rewrote commit message]
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Add a udelay(100) to nvec_interrupt
Julian Andres Klode [Tue, 27 Sep 2011 17:01:07 +0000 (19:01 +0200)]
staging: nvec: Add a udelay(100) to nvec_interrupt

As the comment indicates, adding that udelay seems to
improve the stability of the communication, although
it is not known why this is the case.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Add missing includes and reorder them
Julian Andres Klode [Tue, 27 Sep 2011 17:01:06 +0000 (19:01 +0200)]
staging: nvec: Add missing includes and reorder them

Add the includes that are currently missing in nvec.h
and nvec.c and reorder them alphabetically.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Add myself to MAINTAINERS
Julian Andres Klode [Tue, 27 Sep 2011 17:01:05 +0000 (19:01 +0200)]
staging: nvec: Add myself to MAINTAINERS

I intent to support this code, especially the parts
I wrote; and will thus enter as co-maintainer.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Add battery quirk to ignore incomplete responses
Julian Andres Klode [Tue, 27 Sep 2011 17:01:04 +0000 (19:01 +0200)]
staging: nvec: Add battery quirk to ignore incomplete responses

The nvec_power system polls nvec for battery information. In some
cases, that part seems to be overloaded and unable to respond
fast in which case it sends an incomplete response. We need to
mark the transfer as completed, though, in order to prevent
endless retries which can kill nvec.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: ps2: Always sample 4 bytes instead of just 1
Julian Andres Klode [Tue, 27 Sep 2011 17:01:03 +0000 (19:01 +0200)]
staging: nvec: ps2: Always sample 4 bytes instead of just 1

Get 4 bytes of data from nvec at once instead of just a single
byte. This makes the driver more similar to nvidias and might
improve reliability.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Return error in PS2 driver if write fails
Julian Andres Klode [Tue, 27 Sep 2011 17:01:02 +0000 (19:01 +0200)]
staging: nvec: Return error in PS2 driver if write fails

Return the return value of nvec_write_async() in the methods
returning an int.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Reject incomplete messages
Julian Andres Klode [Tue, 27 Sep 2011 17:01:01 +0000 (19:01 +0200)]
staging: nvec: Reject incomplete messages

Reject incomplete messages, causing the request to be
transmitted again. This should fix various problems
out there.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Handle filled up RX buffers
Julian Andres Klode [Tue, 27 Sep 2011 17:01:00 +0000 (19:01 +0200)]
staging: nvec: Handle filled up RX buffers

If no RX buffer is available in state 1, jump to state
0 again. This will produce an incredible amount of
warnings, but it is not supposed to happen anyway.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Allow TX buffers only in the upper 75% of the pool
Julian Andres Klode [Tue, 27 Sep 2011 17:00:59 +0000 (19:00 +0200)]
staging: nvec: Allow TX buffers only in the upper 75% of the pool

Allow TX buffers to be allocated only in the upper 75% of the pool
to avoid a completely filled buffer preventing the driver from
processing responses. This also improves performance, as RX
allocations do not require checking buffers allocated for TX
unless there are more than 16 incoming messages -- which is
highly unlikely.

An earlier version used the lower 75% for TX messages, but
that was considered to be not that effective due to the
overlaps of RX and TX buffers mentioned above.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Export nvec_msg_free() to clients
Julian Andres Klode [Tue, 27 Sep 2011 17:00:58 +0000 (19:00 +0200)]
staging: nvec: Export nvec_msg_free() to clients

Client code wishing to make use of nvec_write_sync() must
have a way to free the returned pointer, otherwise we run
out of poool memory fairly soon.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Move implementation-only macros out of the header
Julian Andres Klode [Tue, 27 Sep 2011 17:00:57 +0000 (19:00 +0200)]
staging: nvec: Move implementation-only macros out of the header

Those macros are needed only for implementation purposes and
do not have any use for other code wishing to use nvec.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Document public and private API
Julian Andres Klode [Tue, 27 Sep 2011 17:00:56 +0000 (19:00 +0200)]
staging: nvec: Document public and private API

Add kernel-doc comments describing the functions
and structs we currently have.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Have nvec_write_async() return -ENOMEM on OOM
Julian Andres Klode [Tue, 27 Sep 2011 17:00:55 +0000 (19:00 +0200)]
staging: nvec: Have nvec_write_async() return -ENOMEM on OOM

Change nvec_write_async() to return an integer, 0 by default,
a negative error on failure. Change nvec_write_sync() to
check the return value and abort if it is negative.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Enable the capslock LED in the keyboard driver
Julian Andres Klode [Tue, 27 Sep 2011 17:00:54 +0000 (19:00 +0200)]
staging: nvec: Enable the capslock LED in the keyboard driver

When the caps lock key is pressed, toggle the associated
LED. According to Nvidia code, we should send 0x01 where
we sent 0x07, but this does not appear to work correctly
on the AC100.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Add myself to copyright and authors list
Julian Andres Klode [Tue, 27 Sep 2011 17:00:53 +0000 (19:00 +0200)]
staging: nvec: Add myself to copyright and authors list

Forgotten in the last commit(s) which contained the copyrightable
material, so let's add it now. I believe that only my nvec.c
contributions are copyrightable, nvec.h is just interface naming,
so does not deserve that yet.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Do not print free message for tx_scratch
Julian Andres Klode [Tue, 27 Sep 2011 17:00:52 +0000 (19:00 +0200)]
staging: nvec: Do not print free message for tx_scratch

The scratch area is not part of the pool and thus gets
no allocation message. Printing a free message would
be confusing, and the pointer subtraction would be
undefined behavior.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Rewrite the interrupt handler
Julian Andres Klode [Tue, 27 Sep 2011 17:00:51 +0000 (19:00 +0200)]
staging: nvec: Rewrite the interrupt handler

Rewrite the interrupt handler to use a state machine similar to
that found in the various kernels for the Advent Vega. This also
changes the code to use the new functions introduced in the
previous commits.

This also merges the rewrite sent in August 2011 by Marc
Dietrich, and thus also includes code by him. His original
patch can be found on the mailing list.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Add is_event() and size() functions for nvec_msg
Julian Andres Klode [Tue, 27 Sep 2011 17:00:50 +0000 (19:00 +0200)]
staging: nvec: Add is_event() and size() functions for nvec_msg

Add functions nvec_msg_is_event() and nvec_msg_size() which
do just what the say: tell whether the message is an event,
and getting the size of the message.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Introduce nvec_gpio_set_value()
Julian Andres Klode [Tue, 27 Sep 2011 17:00:49 +0000 (19:00 +0200)]
staging: nvec: Introduce nvec_gpio_set_value()

Introduce nvec_gpio_set_value(), which works like
gpio_set_value(), but also creates a debugging
message, if that's enabled.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Introduce new internal API for msg alloc/free
Julian Andres Klode [Tue, 27 Sep 2011 17:00:48 +0000 (19:00 +0200)]
staging: nvec: Introduce new internal API for msg alloc/free

Introduce two new functions nvec_msg_alloc() and nvec_msg_free()
that allocate and free message buffers from the internal pool
of messages.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: fix Kconfig dependencies
Marc Dietrich [Tue, 27 Sep 2011 17:00:47 +0000 (19:00 +0200)]
staging: nvec: fix Kconfig dependencies

This patch adds config dependencies for the NVEC keyboard, mouse,
and power drivers.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: add MAINTAINERS info
Marc Dietrich [Tue, 27 Sep 2011 17:00:46 +0000 (19:00 +0200)]
staging: nvec: add MAINTAINERS info

This adds the relevant info to the MAINTAINERS file so people can
find the right person to blame.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: update ToDo list
Marc Dietrich [Tue, 27 Sep 2011 17:00:45 +0000 (19:00 +0200)]
staging: nvec: update ToDo list

Mostly small stuff only. Hopefully completed during the next
release cycle.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
[jak@jak-linux.org: Removed some items no longer valid]
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: add LED support
Ilya Petrov [Tue, 27 Sep 2011 17:00:44 +0000 (19:00 +0200)]
staging: nvec: add LED support

This patch adds support for LEDs connect to a nvec. A single brightness
property is exported to sysfs. LEDs are selected via bitfields in the
brightness value. Also the blinking behavior is selected through this
method. Vendors may use different values for different HW designs.

Signed-off-by: Ilya Petrov <ilya.muromec@gmail.com>
Signed-off-by: Marc Dietrich <marvin24@gmx.de>
[jak@jak-linux.org: Fixed checkpatch warnings]
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: fix unmute of speakers
Marc Dietrich [Tue, 27 Sep 2011 17:00:43 +0000 (19:00 +0200)]
staging: nvec: fix unmute of speakers

The ec command used was for muting, not unmuting.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: rework the nvec slave init
Marc Dietrich [Tue, 27 Sep 2011 17:00:42 +0000 (19:00 +0200)]
staging: nvec: rework the nvec slave init

Rework the tegra slave controller init to look more like in
tegra-i2c.c. This makes the nvec init reliable. Also add de-init of
the slave to be used during suspend.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Use print_hex_dump() where appropriate
Marc Dietrich [Tue, 27 Sep 2011 17:00:41 +0000 (19:00 +0200)]
staging: nvec: Use print_hex_dump() where appropriate

Split of the previous patch and the next by Marc, as that
patch is not strictly a coding style fix only.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: coding style fixes / add copyright notice
Marc Dietrich [Tue, 27 Sep 2011 17:00:40 +0000 (19:00 +0200)]
staging: nvec: coding style fixes / add copyright notice

This patch fixes coding style and adds copyright notices.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
[jak@jak-linux.org: Merge later cleanup into that patch]
Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: nvec: Include missing headers
Julian Andres Klode [Tue, 27 Sep 2011 17:00:39 +0000 (19:00 +0200)]
staging: nvec: Include missing headers

Those headers were apparently included by other headers
previously, but are not anymore.

Signed-off-by: Julian Andres Klode <jak@jak-linux.org>
Acked-by: Marc Dietrich <marvin24@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: bcm: Alter LOC for readability/understandability purposes
Kevin McKinney [Wed, 28 Sep 2011 01:28:11 +0000 (21:28 -0400)]
Staging: bcm: Alter LOC for readability/understandability purposes

This patch alters a line of code to make it more readable
and easier to understand. The purpose of the original line
of code was to compute the amount of memory to request from
kmalloc. This mulit-step algorithm was being done in one
line of code, thus making it more difficult to understand.
Therefore, I split this algorithm into three logical steps.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: bcm: Add min/max restrictions for IOCTL_BCM_REGISTER_READ_PRIVATE
Kevin McKinney [Tue, 27 Sep 2011 02:03:59 +0000 (22:03 -0400)]
Staging: bcm: Add min/max restrictions for IOCTL_BCM_REGISTER_READ_PRIVATE

This patch fixes two issues within bcm/Bcmchar.c. The
first condition in the or statement checks if variable
IoBuffer.OutputLength, defined from user space, is
greater than the maximum value allowed for an
unsigned short. IoBuffer.OutputLength is then used
in a kmalloc call to return a pointer to memory. If
this size is greater than an unsigned short, it
becomes useless. The second condition in the or statement
checks if the same variable, IoBuffer.OutputLength is
equal to zero before invoking the kmalloc call. In
this case, if a zero size is sent to kmalloc, a valid
pointer to memory is returned instead of the expected NULL.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: hv: remove the carrier status check from netvsc_open()
Haiyang Zhang [Wed, 28 Sep 2011 20:24:15 +0000 (13:24 -0700)]
staging: hv: remove the carrier status check from netvsc_open()

Checking carrier status in netvsc_open() is not necessary.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: vt6656: potential memory corruption
Dan Carpenter [Thu, 29 Sep 2011 06:13:18 +0000 (09:13 +0300)]
Staging: vt6656: potential memory corruption

param->u.wpa_key.key_len comes from the user.  If it's too large we
would write past the end of the array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: unwind the IIO_IN -> IIO_VOLTAGE define
Jonathan Cameron [Tue, 27 Sep 2011 08:56:41 +0000 (09:56 +0100)]
staging:iio: unwind the IIO_IN -> IIO_VOLTAGE define

This was originally there to avoid churn during a complex change.
Now everything is stable lets get rid of this as it is missleading
and confusing.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: Update the TODO file
K. Y. Srinivasan [Thu, 22 Sep 2011 19:40:50 +0000 (12:40 -0700)]
Staging: hv: Update the TODO file

Now that all vmbus audit related comments have been addressed,
update the TODO file to reflect this.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Use IW_HANDLER macro
David Kilroy [Sun, 25 Sep 2011 07:30:21 +0000 (08:30 +0100)]
staging: wlags49_h2: Use IW_HANDLER macro

to declare wireless handlers.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Stop playing with length in GIWESSID handler
David Kilroy [Sun, 25 Sep 2011 07:30:19 +0000 (08:30 +0100)]
staging: wlags49_h2: Stop playing with length in GIWESSID handler

WE21 clarified that ESSID should not be NULL terminated.
The existing code didn't NULL terminate, but did play with length
and then reset it again. Just stop it.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Declare support for WEXT 21
David Kilroy [Sun, 25 Sep 2011 07:30:20 +0000 (08:30 +0100)]
staging: wlags49_h2: Declare support for WEXT 21

WEXT changes between versions 15 and 21 have been taken care of,
so update the declared support.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Fixup WEXT capabilities
David Kilroy [Sun, 25 Sep 2011 07:30:18 +0000 (08:30 +0100)]
staging: wlags49_h2: Fixup WEXT capabilities

Add recently added events to the capabilities reported in iw_range.
Use capability macros instead of assuming the array offsets.

Explicitly list scan capabilities.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agodrivers:staging:comedi:drivers:cb_das_cs.c codeing style issue
Christopher Rice [Fri, 23 Sep 2011 23:53:09 +0000 (16:53 -0700)]
drivers:staging:comedi:drivers:cb_das_cs.c codeing style issue

drivers: staging: comedi: cb_das16_cs.c
fixed over 80 line issue, and removed a space before tab issue.

Signed-off-by: Christopher Rice <rice.christopher.a@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: comedi: Added log subjects to printk()s in pcmmio
Johannes Thumshirn [Sun, 25 Sep 2011 04:49:12 +0000 (06:49 +0200)]
staging: comedi: Added log subjects to printk()s in pcmmio

Added log subject to printk()s in drivers/staging/comedi/drivers/pcmmio.c.

Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: vt6655-6: potential info leak in private_ioctl()
Dan Carpenter [Fri, 23 Sep 2011 06:23:22 +0000 (09:23 +0300)]
Staging: vt6655-6: potential info leak in private_ioctl()

Smatch has a new check for Rosenberg type information leaks where
structs are copied to the user with uninitialized stack data in them.

In this path, the .uLinkRate member doesn't get initialized so I've
set it to zero.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agodrivers/staging/bcm/InterfaceDld.c: Fix checkpatch warnings
Marcos Paulo de Souza [Fri, 23 Sep 2011 03:20:09 +0000 (00:20 -0300)]
drivers/staging/bcm/InterfaceDld.c: Fix checkpatch warnings

In the source file there are a lot of warnings. I will send it in parts to be more easy to
review. All the changes in this file its just alignment, and things like that.

Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: et131x: Bugfix - driver doesn't autoreneg after cable unplug/plug events
Mark Einon [Sun, 25 Sep 2011 18:17:57 +0000 (19:17 +0100)]
staging: et131x: Bugfix - driver doesn't autoreneg after cable unplug/plug events

This driver has a long standing bug where removing and inserting the ethernet cable results in no packets being
trnasmitted / received and hence no autonegotiation occurring.

Fixed by resetting the rx/tx engines and queue on detecting a cable being removed.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: et131x: Remove header declaration of et131x_check_mii()
Mark Einon [Sun, 25 Sep 2011 18:17:56 +0000 (19:17 +0100)]
staging: et131x: Remove header declaration of et131x_check_mii()

et131x_check_mii no longer exists, remove its declaration from the header file

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: et131x: Create et131x_[dis|en]able_txrx() calls
Mark Einon [Sun, 25 Sep 2011 18:17:55 +0000 (19:17 +0100)]
staging: et131x: Create et131x_[dis|en]able_txrx() calls

In et131x_netdev.c, a series of calls to enable and diasble the rx/tx engine and queue are being used in several different places.
Create two functions to encapsulate these calls, and replace many calls with just the one.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: et131x: Remove et131x_check_mii() and move functionality into et131x_adjust_...
Mark Einon [Sun, 25 Sep 2011 18:17:54 +0000 (19:17 +0100)]
staging: et131x: Remove et131x_check_mii() and move functionality into et131x_adjust_link()

et131x_check_mii() is now only being called from et131x_adjust_link.
Removed this call and associated subroutines, putting the functionality directly into et131x_adjust_link(), in preparation for further simplification.
Changed register checks from bare BMSR checks to use phydev/netif versions, also now uses adapter->link to track link state changes.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: et131x: Add link status to adapter struct
Mark Einon [Sun, 25 Sep 2011 18:17:53 +0000 (19:17 +0100)]
staging: et131x: Add link status to adapter struct

This will be used to determine if the link state has changed when the phydev
informs the et131x that a change has occurred (in et131x_adjust_link)

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: et131x: support register dump in ethtool ops
Mark Einon [Sun, 25 Sep 2011 18:17:52 +0000 (19:17 +0100)]
staging: et131x: support register dump in ethtool ops

Not an exhaustive dump of the et131x registers, used while debugging a specific problem - seems a shame not to keep it around.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: gma500: gtt based hardware scrolling console
Alan Cox [Thu, 22 Sep 2011 18:43:47 +0000 (19:43 +0100)]
staging: gma500: gtt based hardware scrolling console

Add support for GTT based scrolling. Instead of pushing bits around we simply
use the GTT to change the mappings. This provides us with a very fast way to
scroll the display providing we have enough memory to allocate on 4K line
boundaries. In practice this seems to be the case except for very big displays
such as HDMI. It works out nicely on the usual configurations are netbooks and
tablets.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: gma500: frame buffer locking
Alan Cox [Thu, 22 Sep 2011 12:20:57 +0000 (13:20 +0100)]
staging: gma500: frame buffer locking

If we are the console then a printk can hit us with a spin lock held (and
in fact the kernel will do its best to take printing lock).

In that case we cannot politely sleep when synching after an accelerated op
but must behave obnixously to be sure of getting the bits out.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: Prevent reading from buffer chrdev when device has no buffer.
Jonathan Cameron [Wed, 21 Sep 2011 10:16:02 +0000 (11:16 +0100)]
staging:iio: Prevent reading from buffer chrdev when device has no buffer.

Silly bug introduced during the chrdev merge series.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:magnetometer:ak8975: Fix probe() error-handling
Stephen Warren [Wed, 21 Sep 2011 10:16:01 +0000 (11:16 +0100)]
staging:iio:magnetometer:ak8975: Fix probe() error-handling

Fix ak8975_probe() to jump to the appropriate exit labels when an error
occurs. With the previous code, some cleanup actions were being skipped
for some error conditions.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Andrew Chew <achew@nvidia.com>
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:magnetometer:ak8975: Don't assume 0 is an invalid GPIO
Stephen Warren [Wed, 21 Sep 2011 10:16:00 +0000 (11:16 +0100)]
staging:iio:magnetometer:ak8975: Don't assume 0 is an invalid GPIO

gpio_is_valid() is the defined mechanism to determine whether a GPIO is
valid. Use this instead of assuming that 0 is an invalid GPIO.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Andrew Chew <achew@nvidia.com>
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:magnetometer:ak8975 use platform_data to pass the gpio number.
Jonathan Cameron [Wed, 21 Sep 2011 10:15:59 +0000 (11:15 +0100)]
staging:iio:magnetometer:ak8975 use platform_data to pass the gpio number.

Tegra doesn't have irq_to_gpio() any more, and ak8975 is included in
tegra_defconfig. This causes a build failure. Instead, pass the GPIO name
through platform data.

[swarren: Rewrote commit description when I squashed this with my patch
to remove the irq_to_gpio() call]

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:accel:lis3l02dq ring->buffer renames.
Jonathan Cameron [Wed, 21 Sep 2011 10:15:58 +0000 (11:15 +0100)]
staging:iio:accel:lis3l02dq ring->buffer renames.

This driver already supports kfifo usage, so the term ring is
misleading and hence replaced.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: replacing term ring with buffer in the IIO core.
Jonathan Cameron [Wed, 21 Sep 2011 10:15:57 +0000 (11:15 +0100)]
staging:iio: replacing term ring with buffer in the IIO core.

They aren't always ring buffers, so just use buffer for all naming.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: rename ring_generic.h -> buffer_generic.h
Jonathan Cameron [Wed, 21 Sep 2011 10:15:56 +0000 (11:15 +0100)]
staging:iio: rename ring_generic.h -> buffer_generic.h

Nothing in this file is specific to RING buffers so rename it.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: tree wide IIO_RING_BUFFER config symbol to IIO_BUFFER
Jonathan Cameron [Wed, 21 Sep 2011 10:15:55 +0000 (11:15 +0100)]
staging:iio: tree wide IIO_RING_BUFFER config symbol to IIO_BUFFER

Functionality is generic, so name is missleading.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: tree wide IIO_RING_TRIGGERED -> IIO_BUFFER_TRIGGERED
Jonathan Cameron [Wed, 21 Sep 2011 10:15:54 +0000 (11:15 +0100)]
staging:iio: tree wide IIO_RING_TRIGGERED -> IIO_BUFFER_TRIGGERED

also, IIO_RING_HARDWARE_BUFFER -> IIO_BUFFER_HARDWARE

These aren't always rings so the naming should not imply that.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio: treewide rename iio_triggered_ring_* to iio_triggered_buffer_*
Jonathan Cameron [Wed, 21 Sep 2011 10:15:53 +0000 (11:15 +0100)]
staging:iio: treewide rename iio_triggered_ring_* to iio_triggered_buffer_*

Not always a ring so naming is missleading.
Also, kfifo_buf is probably first buffer to take out of staging and it
definitely isn't a ring.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:documentation Add abi docs for capacitance adcs.
Jonathan Cameron [Wed, 21 Sep 2011 10:15:52 +0000 (11:15 +0100)]
staging:iio:documentation Add abi docs for capacitance adcs.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging:iio:documentation general refresh of abi docs.
Jonathan Cameron [Wed, 21 Sep 2011 10:15:51 +0000 (11:15 +0100)]
staging:iio:documentation general refresh of abi docs.

Numerous small fixes and additions of missing elements.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: iio: Move sensor drivers to sub menus
Manuel Stahl [Wed, 21 Sep 2011 10:15:50 +0000 (11:15 +0100)]
staging: iio: Move sensor drivers to sub menus

We have a lot of drivers now, so the iio sub menu becomes quite large.
This patch creates sub menus for the different sensors.

Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: iio: adc: Replace, rewrite ad7745 from scratch.
Michael Hennerich [Wed, 21 Sep 2011 10:15:49 +0000 (11:15 +0100)]
staging: iio: adc: Replace, rewrite ad7745 from scratch.

The existing ad7745 driver didn't conform with the IIO spec for such devices.
It was way simpler to rewrite the existing driver, than actually fixing it.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: intel_sst: instel_sst: fixed some coding style issues.
Jaap Crezee [Wed, 21 Sep 2011 20:48:44 +0000 (22:48 +0200)]
Staging: intel_sst: instel_sst: fixed some coding style issues.

Fixed a coding style issue.

Signed-off-by: Jaap Crezee <jaap@jcz.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: mei: Organize the initialization state machine.
Oren Weil [Wed, 21 Sep 2011 13:45:30 +0000 (16:45 +0300)]
staging: mei: Organize the initialization state machine.

moving the final state, clearing of the client maps and
updating of mei state out from mei_host_client_properties function.

Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Oren Weil <oren.jer.weil@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: rtl8192e: off by one in rtl8192_get_channel_map()
Dan Carpenter [Wed, 21 Sep 2011 07:17:04 +0000 (10:17 +0300)]
Staging: rtl8192e: off by one in rtl8192_get_channel_map()

COUNTRY_CODE_MAX is not a valid country code.  We're off by one here.
This gets passed to Dot11d_Channelmap() where it's used as an offset
into the ChannelPlan[] array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: simplified internal ioctl function once more
Roland Vossen [Fri, 23 Sep 2011 00:07:56 +0000 (17:07 -0700)]
staging: brcm80211: simplified internal ioctl function once more

Code cleanup. Merged two functions.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: consistent naming of struct net_device *ndev
Roland Vossen [Fri, 23 Sep 2011 00:07:55 +0000 (17:07 -0700)]
staging: brcm80211: consistent naming of struct net_device *ndev

Code cleanup. Various names (ndev, net, dev) were used for the
same structure. Settled for 'ndev'.

Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: clarified fullmac io and event codes
Roland Vossen [Fri, 23 Sep 2011 00:07:54 +0000 (17:07 -0700)]
staging: brcm80211: clarified fullmac io and event codes

Added comments to make code more readable.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed log after kzalloc()/kmalloc() failure
Roland Vossen [Fri, 23 Sep 2011 00:07:53 +0000 (17:07 -0700)]
staging: brcm80211: removed log after kzalloc()/kmalloc() failure

kzalloc/kmalloc already reports an allocation failure themselves.

Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed likely/unlikely calls
Roland Vossen [Fri, 23 Sep 2011 00:07:52 +0000 (17:07 -0700)]
staging: brcm80211: removed likely/unlikely calls

There was no performance rationale to use these guys.

Reported-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: added endianness check flag to fullmac Makefile
Roland Vossen [Fri, 23 Sep 2011 00:07:51 +0000 (17:07 -0700)]
staging: brcm80211: added endianness check flag to fullmac Makefile

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: removed two fullmac sparse spinlock warnings
Roland Vossen [Fri, 23 Sep 2011 00:07:50 +0000 (17:07 -0700)]
staging: brcm80211: removed two fullmac sparse spinlock warnings

By deleting three redundant functions. The spinlock was related to
event queue operation. Event queue data members were also renamed
to make their function more clear.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove global variables for data frame boundary
Franky Lin [Fri, 23 Sep 2011 00:07:49 +0000 (17:07 -0700)]
staging: brcm80211: remove global variables for data frame boundary

Put boundary settings in brcmf_bus structure

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove fullmac module_param brcmf_idletime
Franky Lin [Fri, 23 Sep 2011 00:07:48 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param brcmf_idletime

Use constant for idle time setting.

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove fullmac module_param for watchdog
Franky Lin [Fri, 23 Sep 2011 00:07:47 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param for watchdog

Use constant to replace global variable used for watchdog polling

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove fullmac module_param brcmf_sdiod_drive_strength
Franky Lin [Fri, 23 Sep 2011 00:07:46 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param brcmf_sdiod_drive_strength

Replaced the global variable with constant

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove fullmac module_param brcmf_dongle_memsize
Franky Lin [Fri, 23 Sep 2011 00:07:45 +0000 (17:07 -0700)]
staging: brcm80211: remove fullmac module_param brcmf_dongle_memsize

remove unused module parameter brcmf_dongle_memsize and related code

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove event handler thread from fullmac
Franky Lin [Fri, 23 Sep 2011 00:07:44 +0000 (17:07 -0700)]
staging: brcm80211: remove event handler thread from fullmac

Use work queue to defer cfg80211 event handle jobs

Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove unconditional code blocks from brcmfmac
Arend van Spriel [Fri, 23 Sep 2011 00:07:43 +0000 (17:07 -0700)]
staging: brcm80211: remove unconditional code blocks from brcmfmac

Using a block statement to scope function variables is not
common in linux kernel development. Browsed through the brcmfmac
to remove those.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: more fullmac sparse endianness scan related changes
Roland Vossen [Fri, 23 Sep 2011 00:07:42 +0000 (17:07 -0700)]
staging: brcm80211: more fullmac sparse endianness scan related changes

Annotated endianness on structures send/received to/from dongle.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: sparse endianness warnings for struct sdpcm_shared
Roland Vossen [Fri, 23 Sep 2011 00:07:41 +0000 (17:07 -0700)]
staging: brcm80211: sparse endianness warnings for struct sdpcm_shared

Structure that is received from dongle has been annotated.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: sparse endianness warnings for struct brcmf_proto_cdc_ioctl
Roland Vossen [Fri, 23 Sep 2011 00:07:40 +0000 (17:07 -0700)]
staging: brcm80211: sparse endianness warnings for struct brcmf_proto_cdc_ioctl

Structure that is send/received to/from dongle has been annotated.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: various fulmac sparse endianness fixes
Roland Vossen [Fri, 23 Sep 2011 00:07:39 +0000 (17:07 -0700)]
staging: brcm80211: various fulmac sparse endianness fixes

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: sparse endianness warnings on dongle events
Roland Vossen [Fri, 23 Sep 2011 00:07:38 +0000 (17:07 -0700)]
staging: brcm80211: sparse endianness warnings on dongle events

Structures received from dongle have been annotated.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: vmbus: Get rid of hv_cb_utils[] and other unneeded code
K. Y. Srinivasan [Sun, 18 Sep 2011 17:31:35 +0000 (10:31 -0700)]
Staging: hv: vmbus: Get rid of hv_cb_utils[] and other unneeded code

Now that the transformation of the util driver is complete,
get rid of hv_cb_utils[] and other unneeded code.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: util: Properly handle util services in the util driver
K. Y. Srinivasan [Sun, 18 Sep 2011 17:31:34 +0000 (10:31 -0700)]
Staging: hv: util: Properly handle util services in the util driver

Now, properly handle util services in the util driver and eliminate code
that will not be necessary. In the current code, util services were
all handled not as other vmbus devices (net, block) but rather through
special handling (channel setup etc.). In this patch we handle all
services using the standard Linux Driver Model.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: util: Perform some service specific init/deinit in probe/remove
K. Y. Srinivasan [Sun, 18 Sep 2011 17:31:33 +0000 (10:31 -0700)]
Staging: hv: util: Perform some service specific init/deinit in probe/remove

In preparation for modifying the util driver to fully conform to the
Linux Driver Model, perform some service specific init and de-init
operations in util_probe()/util_remove()  as opposed to in
init_hyperv_utils()/exit_hyperv_utils() as is currently done.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Support standard WEXT events
David Kilroy [Mon, 19 Sep 2011 20:08:15 +0000 (21:08 +0100)]
staging: wlags49_h2: Support standard WEXT events

... instead of using IWEVCUSTOM. Use the defined events for
michael mic failure, association request info and association
response info.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wlags49_h2: Remove old WIRELESS_EXT support
David Kilroy [Mon, 19 Sep 2011 20:08:14 +0000 (21:08 +0100)]
staging: wlags49_h2: Remove old WIRELESS_EXT support

Since the driver is now in-kernel remove support for building
against ancient WIRELESS_EXT versions.

Signed-off-by: David Kilroy <kilroyd@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT
Kautuk Consul [Wed, 14 Sep 2011 03:26:21 +0000 (08:56 +0530)]
staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT

If the usermode app does an ioctl over this serial device  by
using TIOCMIWAIT, then the code will wait by setting the current
task state to TASK_INTERRUPTIBLE and then calling schedule().
This will be woken up by the qt2_process_modem_status on URB
completion when the port_extra->shadowMSR is set to the new
modem status.

However, this could result in a lost wakeup scenario due to a race
in the logic in the qt2_ioctl(TIOCMIWAIT) loop and the URB completion
for new modem status in qt2_process_modem_status.
Due to this, the usermode app's task will continue to sleep despite a
change in the modem status.

Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: bcm: Add size maximum size restrictions for IOCTL_IDLE_REQ
Kevin McKinney [Sun, 18 Sep 2011 22:34:47 +0000 (18:34 -0400)]
Staging: bcm: Add size maximum size restrictions for IOCTL_IDLE_REQ

In the first alteration, the MAX_CNTL_PKT_SIZE is the
maximum size of the control packet in ->Adapter->txctlpacket[]
which is defined in InitAdapter(). This caps the size of
kmalloc memory allocation. In the second change, this max
cap fixes a potential memory corruption bug when subsequent
memset and memcpy calls are invoked.

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: bcm: Add size minimum size restrictions for IOCTL_IDLE_REQ
Kevin McKinney [Sun, 18 Sep 2011 22:34:46 +0000 (18:34 -0400)]
Staging: bcm: Add size minimum size restrictions for IOCTL_IDLE_REQ

If IoBuffer.InputLength is zero then this will cause an Oops when
we dereference the ZERO_SIZE_PTR.  Or if it's smaller than
sizeof(struct link_request) then we would get memory corruption
when we set ->PLength in CopyBufferToControlPacket().

Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: usbip: fix up api changes that broke windows clients
Alexander Thomas [Mon, 19 Sep 2011 14:56:51 +0000 (16:56 +0200)]
staging: usbip: fix up api changes that broke windows clients

Revert changes in definitions that were submitted on May 11 2011 and
committed on June 7 2011. No reason for the change in these values was
given in the patch comment, it broke compatibility with older
versions, and was difficult to detect by the simultaneous move of the
lines of code.

Signed-off-by: Alexander Thomas <alexander.thomas@esaturnus.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: sparse endianness warnings on fullmac bss info
Roland Vossen [Fri, 16 Sep 2011 19:28:08 +0000 (12:28 -0700)]
staging: brcm80211: sparse endianness warnings on fullmac bss info

Structure that is received from dongle has been annotated.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Arend van Spriel <arend@broadcom.com>
Reviewed-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: brcm80211: remove static global variables from dhd_sdio.c
Arend van Spriel [Fri, 16 Sep 2011 19:28:07 +0000 (12:28 -0700)]
staging: brcm80211: remove static global variables from dhd_sdio.c

Several global variables that were set but never initialized have
been removed.

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Reviewed-by: Franky (Zhenhui) Lin <frankyl@broadcom.com>
Reviewed-by: Roland Vossen <rvossen@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>