]> git.karo-electronics.de Git - linux-beck.git/log
linux-beck.git
11 years agortl8192u: add space after '}' in r8192U_core.c
Xenia Ragiadakou [Thu, 23 May 2013 02:14:47 +0000 (05:14 +0300)]
rtl8192u: add space after '}' in r8192U_core.c

This patch fixes the following checkpatch error:
ERROR: space required after that close brace '}'

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: replace __FUNCTION__ with __func__ in r8192U_core.c
Xenia Ragiadakou [Thu, 23 May 2013 02:14:48 +0000 (05:14 +0300)]
rtl8192u: replace __FUNCTION__ with __func__ in r8192U_core.c

This patch fixes the following checkpatch warning:
WARNING: __func__ should be used instead of gcc
specific __FUNCTION__

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: remove space between function name and '(' in r8192U_core.c
Xenia Ragiadakou [Thu, 23 May 2013 02:14:46 +0000 (05:14 +0300)]
rtl8192u: remove space between function name and '(' in r8192U_core.c

This patch fixes the following checkpatch warning:
WARNING: space prohibited between function name and
open parenthesis '('

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: speakup: fix warnings by adding __user annotations
Emil Goode [Wed, 22 May 2013 18:53:09 +0000 (20:53 +0200)]
staging: speakup: fix warnings by adding __user annotations

This patch fixes the following sparse warnings by adding
__user annotations.

drivers/staging/speakup/speakup_soft.c:248:34: warning:
        incorrect type in argument 1 (different address spaces)
        drivers/staging/speakup/speakup_soft.c:248:34:
        expected void [noderef] <asn:1>*dst
        drivers/staging/speakup/speakup_soft.c:248:34:
        got char *[assigned] cp
drivers/staging/speakup/speakup_soft.c:272:40: warning:
        incorrect type in argument 1 (different address spaces)
        drivers/staging/speakup/speakup_soft.c:272:40:
        expected char const [noderef] <asn:1>*s
        drivers/staging/speakup/speakup_soft.c:272:40:
        got char const *buf
drivers/staging/speakup/speakup_soft.c:306:17: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/speakup_soft.c:306:17:
        expected long ( *read )( ... )
        drivers/staging/speakup/speakup_soft.c:306:17:
        got long ( static [toplevel] *<noident> )( ... )
drivers/staging/speakup/speakup_soft.c:307:18: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/speakup_soft.c:307:18:
        expected long ( *write )( ... )
        drivers/staging/speakup/speakup_soft.c:307:18:
        got long ( static [toplevel] *<nfile_operationsoident> )( ... )

drivers/staging/speakup/devsynth.c:29:41: warning:
        incorrect type in argument 2 (different address spaces)
        drivers/staging/speakup/devsynth.c:29:41:
        expected void const [noderef] <asn:1>*from
        drivers/staging/speakup/devsynth.c:29:41:    got char const *ptr
drivers/staging/speakup/devsynth.c:62:17: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/devsynth.c:62:17:
        expected long ( *read )( ... )
        drivers/staging/speakup/devsynth.c:62:17:
        got long ( static [toplevel] *<noident> )( ... )
drivers/staging/speakup/devsynth.c:63:18: warning:
        incorrect type in initializer (incompatible argument 2
        (different address spaces))
        drivers/staging/speakup/devsynth.c:63:18:
        expected long ( *write )( ... )
        drivers/staging/speakup/devsynth.c:63:18:
        got long ( static [toplevel] *<noident> )( ... )

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup/main: Staticize local symbols
Sachin Kamat [Wed, 22 May 2013 09:07:25 +0000 (14:37 +0530)]
Staging: speakup/main: Staticize local symbols

Symbols referenced only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup/kobjects: Use NULL instead of 0
Sachin Kamat [Wed, 22 May 2013 09:07:24 +0000 (14:37 +0530)]
Staging: speakup/kobjects: Use NULL instead of 0

Use NULL instead of 0 for pointers.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup/main: Use NULL instead of 0
Sachin Kamat [Wed, 22 May 2013 10:49:30 +0000 (16:19 +0530)]
Staging: speakup/main: Use NULL instead of 0

Use NULL instead of 0 for pointers.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup/speakup_keypc: Return NULL instead of 0
Sachin Kamat [Wed, 22 May 2013 09:07:22 +0000 (14:37 +0530)]
Staging: speakup/speakup_keypc: Return NULL instead of 0

The function returns a pointer. Hence return NULL instead of 0.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup/speakup_dtlk: Return NULL instead of 0
Sachin Kamat [Wed, 22 May 2013 09:07:21 +0000 (14:37 +0530)]
Staging: speakup/speakup_dtlk: Return NULL instead of 0

The function returns a pointer. Hence return NULL instead of 0.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: speakup/speakup_acntpc: Return NULL instead of 0
Sachin Kamat [Wed, 22 May 2013 09:07:20 +0000 (14:37 +0530)]
Staging: speakup/speakup_acntpc: Return NULL instead of 0

The function returns a pointer. Hence return NULL instead of 0.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace around ',' in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:40 +0000 (18:22 +0300)]
rtl8192u: fix whitespace around ',' in r8192U_core.c

This patch fixes whitespace around ',' and corrects
the following checkpatch error:
ERROR: space required after that ','

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace after '(' and before ')' in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:39 +0000 (18:22 +0300)]
rtl8192u: fix whitespace after '(' and before ')' in r8192U_core.c

This patch removes whitespace after '(' and before ')'
following the kernel coding style.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace around ';' in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:38 +0000 (18:22 +0300)]
rtl8192u: fix whitespace around ';' in r8192U_core.c

This patch fixes whitespace around ';' following kernel
coding style conventions.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace around relational operators in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:37 +0000 (18:22 +0300)]
rtl8192u: fix whitespace around relational operators in r8192U_core.c

This patch fixes whitespace around relational operators
following the kernel coding style conventions.
It corrects the following checkpatch errors:
ERROR: spaces required around that '=='
ERROR: spaces required around that '!'
ERROR: spaces required around that '<='
ERROR: spaces required around that '>='
ERROR: spaces required around that '<'
ERROR: spaces required around that '>'

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace around '=' in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:36 +0000 (18:22 +0300)]
rtl8192u: fix whitespace around '=' in r8192U_core.c

This patch fixes the following checkpatch error:
ERROR: spaces required around that '='

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace around 'while' in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:35 +0000 (18:22 +0300)]
rtl8192u: fix whitespace around 'while' in r8192U_core.c

This patch fixes whitespace around 'while' following
the kernel coding style conventions.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace around 'for' in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:34 +0000 (18:22 +0300)]
rtl8192u: fix whitespace around 'for' in r8192U_core.c

This patch fixes whitespace around 'for' following the
kernel coding style conventions.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agortl8192u: fix whitespace around 'if' in r8192U_core.c
Xenia Ragiadakou [Wed, 22 May 2013 15:22:33 +0000 (18:22 +0300)]
rtl8192u: fix whitespace around 'if' in r8192U_core.c

This patch fixes whitespace around 'if' following the
kernel coding style conventions.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agogdm72xx: remove unnecessary cast in gdm_wimax.c
Xenia Ragiadakou [Wed, 22 May 2013 15:41:21 +0000 (18:41 +0300)]
gdm72xx: remove unnecessary cast in gdm_wimax.c

This patch removes an unnecessary cast on the return value
of alloc_netdev(), since alloc_netdev() returns a pointer
to the allocated struct net_device anyway.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: ced1401: Staticize local symbols
Sachin Kamat [Wed, 22 May 2013 10:06:33 +0000 (15:36 +0530)]
Staging: ced1401: Staticize local symbols

Symbols referenced only in this file are made static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: ced1401: Use NULL instead of 0 for pointers
Sachin Kamat [Wed, 22 May 2013 10:06:32 +0000 (15:36 +0530)]
Staging: ced1401: Use NULL instead of 0 for pointers

Use NULL instead of 0 for pointer variables.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging/cxt1e1:Removing parantheses surrounding return argument
Dulshani Gunawardhana [Wed, 22 May 2013 18:00:45 +0000 (23:30 +0530)]
Staging/cxt1e1:Removing parantheses surrounding return argument

This patch fixes the error 'return is not a function, parentheses are
not required' that is found by using checkpatch.pi

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging/cxt1e1:Fixing foo * bar should be foo *bar
Dulshani Gunawardhana [Wed, 22 May 2013 17:59:26 +0000 (23:29 +0530)]
Staging/cxt1e1:Fixing foo * bar should be foo *bar

This patch fixes the variable naming  error foo * bar should be foo *bar.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging/cxt1e1/comet.c:Modifying comment style and intentation
Dulshani Gunawardhana [Wed, 22 May 2013 17:43:05 +0000 (23:13 +0530)]
Staging/cxt1e1/comet.c:Modifying comment style and intentation

This patch modifies the commenting style by placing comments above the
line of code commented upone.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging/cxt1e1/comet.c:Fixes indentation errors
Dulshani Gunawardhana [Wed, 22 May 2013 17:42:06 +0000 (23:12 +0530)]
Staging/cxt1e1/comet.c:Fixes indentation errors

This patch fixes the "Code indent should usually use tabs" and
"no spaces at front of line" warnings generated by checkpatch.pi.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging/cxt1e1/comet.c:Fixes space between function name and parenthesis
Dulshani Gunawardhana [Wed, 22 May 2013 17:40:52 +0000 (23:10 +0530)]
Staging/cxt1e1/comet.c:Fixes space between function name and parenthesis

This patch corrects the error "Space prohibited between function name
and parenthesis", generated by using checkpatch.pi.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoMerge tag 'iio-for-3.11a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23...
Greg Kroah-Hartman [Wed, 22 May 2013 22:22:44 +0000 (15:22 -0700)]
Merge tag 'iio-for-3.11a' of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into staging-next

Jonathan writes:

First round of new IIO drivers and cleanups for the 3.11 cycle.

1) New driver for MCP3204/08 12 bit ADCs
2) Move the sysfs trigger out of staging.  This has been pretty clean for a
   long time so lets finally move it out.
3) New functionality for the ak8975 magnetometer (DT and data ready interrupt
   handling)
4) Use devm_ioremap_resource in exynos_adc.  We have 3 separate versions of
   this patch proposed but this one got there first.
5) A couple of other tiny fixes.

11 years agoadc: exynos_adc: Convert to devm_ioremap_resource()
Sachin Kamat [Wed, 3 Apr 2013 06:23:00 +0000 (07:23 +0100)]
adc: exynos_adc: Convert to devm_ioremap_resource()

Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: Correct HID light sensor name in comments
Alexandre Relange [Thu, 16 May 2013 13:54:00 +0000 (14:54 +0100)]
iio: Correct HID light sensor name in comments

The original driver was pasted from accelerometer driver, but the name
of the ID was not changed. This patch fixes this comment.

Signed-off-by: Alexandre Relange <alexandre@relange.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: STMicroelectronics: remove three useless selects
Paul Bolle [Tue, 14 May 2013 09:05:00 +0000 (10:05 +0100)]
iio: STMicroelectronics: remove three useless selects

Drivers for STMicroelectronics accelerometers, gyroscopes, and
magnetometers were added in v3.9. They all have a (similar) select
statement in their Kconfig files for a non-existant Kconfig symbol.
These select statements can safely be removed.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Denis Ciocca <denis.ciocca@st.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:ak8975 Implement data ready interrupt handling
Jacek Anaszewski [Tue, 7 May 2013 10:41:00 +0000 (11:41 +0100)]
iio:ak8975 Implement data ready interrupt handling

Implement "data ready" interrupt handling in addition to the
two existing read modes - DRDY GPIO polling and ST1 register
DRDY bit polling.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:ak8975 Add support for gpios DT property
Jacek Anaszewski [Tue, 7 May 2013 10:41:00 +0000 (11:41 +0100)]
iio:ak8975 Add support for gpios DT property

Add support for parsing 'gpios' property when initializing
from oftree.
This patch adds also the binding documentation file.

Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio:trigger:sysfs Move out of staging.
Jonathan Cameron [Sun, 14 Apr 2013 11:54:00 +0000 (12:54 +0100)]
iio:trigger:sysfs Move out of staging.

This simple driver is rather useful. No issues about its interface
have been raised for some time hence the proposal to move it out
of staging.

Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agostaging/iio/mxs-lradc: cleanup masklength
Michał Mirosław [Sat, 4 May 2013 13:19:00 +0000 (14:19 +0100)]
staging/iio/mxs-lradc: cleanup masklength

We know the exact iio->masklength = LRADC_MAX_TOTAL_CHANS.
Let's use it consistently.

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: buffer: cleanup messages in iio_update_buffers()
Michał Mirosław [Sat, 4 May 2013 13:19:00 +0000 (14:19 +0100)]
iio: buffer: cleanup messages in iio_update_buffers()

1. make messages grepable (in one line)
2. include returned errno in them

Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoiio: adc: add driver for MCP3204/08 12-bit ADC
Oskar Andero [Fri, 3 May 2013 09:58:00 +0000 (10:58 +0100)]
iio: adc: add driver for MCP3204/08 12-bit ADC

This adds support for Microchip's 12 bit AD converters MCP3204 and
MCP3208. These chips communicates over SPI and supports single-ended
and pseudo-differential configurations.

Signed-off-by: Oskar Andero <oskar.andero@gmail.com>
Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
11 years agoStaging: bcm: fix checkpatch errors and warnings in Version.h
Severin Gsponer [Tue, 21 May 2013 23:46:02 +0000 (01:46 +0200)]
Staging: bcm: fix checkpatch errors and warnings in Version.h

This patch change the comment style to C89 and removes a unnecessary line.

Signed-off-by: Severin Gsponer <svgsponer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: bcm: Change comment style to C89 in vendorspecificextn.c
Severin Gsponer [Wed, 22 May 2013 00:13:58 +0000 (02:13 +0200)]
Staging: bcm: Change comment style to C89 in vendorspecificextn.c

Changed the comment style to C89 in vendorspecificextn.c. Found with checkpatch.pl

Signed-off-by: Severin Gsponer <svgsponer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: tidspbridge: _tiomap.h: fixed indentation warning.
Tülin İzer [Wed, 22 May 2013 01:23:50 +0000 (04:23 +0300)]
Staging: tidspbridge: _tiomap.h: fixed indentation warning.

This patch fixes indentation warning found by checkpatch.pl in
tidspbridge/_tiomap.h

Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: tidspbridge: tiomap3430_pwr.c: fixed indentation warning.
Tülin İzer [Wed, 22 May 2013 01:23:16 +0000 (04:23 +0300)]
Staging: tidspbridge: tiomap3430_pwr.c: fixed indentation warning.

This patch fixes indentation warning found by checkpatch.pl
in tidspbridge/tiomap3430_pwr.c

Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: tidspbridge: wdt.c: fixed indentation warning.
Tülin İzer [Wed, 22 May 2013 01:22:44 +0000 (04:22 +0300)]
Staging: tidspbridge: wdt.c: fixed indentation warning.

This patch fixes indentation warning found by checkpatch.pl in
tidspbridge/wdt.c

Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: tidspbridge: ue_deh.c: fixed space formatting issue.
Tülin İzer [Wed, 22 May 2013 01:22:11 +0000 (04:22 +0300)]
Staging: tidspbridge: ue_deh.c: fixed space formatting issue.

This patch fixes warning about space formatting around pointer
found by checkpatch.pl in tidsbridge/ue_deh.c

Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: tidspbridge: _tiomap_pwr.h: fixed indentation warning.
Tülin İzer [Wed, 22 May 2013 01:21:22 +0000 (04:21 +0300)]
Staging: tidspbridge: _tiomap_pwr.h: fixed indentation warning.

This patch fixed indentation warning found by checkpatch.pl in
tidsbridge/_tiomap_pwr.h

Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: tidspbridge: _tiomap.h: fixed warning 'space prohibited before semicolon'.
Tülin İzer [Wed, 22 May 2013 01:24:22 +0000 (04:24 +0300)]
Staging: tidspbridge: _tiomap.h: fixed warning 'space prohibited before semicolon'.

This patch fixes warning 'space prohibited before semicolon' found by
checkpatch.pl in tidspbridge/_tiomap.h

Signed-off-by: Tülin İzer <tulinizer@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/speakup: Changed parameters in kstrtol()
Lisa Nguyen [Tue, 21 May 2013 20:31:48 +0000 (13:31 -0700)]
staging/speakup: Changed parameters in kstrtol()

Changed parameters in the kstrtol() function inside main.c to resolve
warnings re: mismatched data types used.

Signed-off-by: Lisa Nguyen <lisa@xenapiadmin.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: use comedi_load_firmware()
H Hartley Sweeten [Mon, 20 May 2013 21:32:29 +0000 (14:32 -0700)]
staging: comedi: usbduxsigma: use comedi_load_firmware()

Use comedi_load_firmware() instead of duplicating the code in a
private function.

Also, rename firmwareUpload() to have namespace associated with
the driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: move firmware request/upload into (*auto_attach)
H Hartley Sweeten [Mon, 20 May 2013 21:32:01 +0000 (14:32 -0700)]
staging: comedi: usbduxsigma: move firmware request/upload into (*auto_attach)

The last step the usb_driver (*probe) does before handing off to the
comedi_driver (*auto_attach) is requesting and uploading the firmware.

Move the request/upload into the (*auto_attach) so we can use the
comedi_load_firmware() helper.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: consolidate the firmware upload
H Hartley Sweeten [Mon, 20 May 2013 21:31:32 +0000 (14:31 -0700)]
staging: comedi: usbduxsigma: consolidate the firmware upload

Absorb the usbduxsub_stop(), usbduxsub_upload(), and usbduxsub_start()
functions into firmwareUpload().

Each of them just do a usb_control_msg() to the device and output
an error message if it fails. A similar message is also output by
firmware_upload() so the extra messages are redundant.

We can also share the malloc'ed local buffer needed for the
usb_control_msg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxsigma: request firmware synchronously
H Hartley Sweeten [Mon, 20 May 2013 21:31:05 +0000 (14:31 -0700)]
staging: comedi: usbduxsigma: request firmware synchronously

Change the request_firmware_nowait() to a request_firmware() so
that the usb_driver (*probe) can continue with the comedi_driver
(*auto_attach).

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: use comedi_load_firmware()
H Hartley Sweeten [Mon, 20 May 2013 21:30:41 +0000 (14:30 -0700)]
staging: comedi: usbdux: use comedi_load_firmware()

Use comedi_load_firmware() instead of duplicating the code in a
private function.

Also, rename firmware_upload() to have namespace associated with
the driver.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: move firmware request/upload into (*auto_attach)
H Hartley Sweeten [Mon, 20 May 2013 21:30:04 +0000 (14:30 -0700)]
staging: comedi: usbdux: move firmware request/upload into (*auto_attach)

The last step the usb_driver (*probe) does before handing off to the
comedi_driver (*auto_attach) is requesting and uploading the firmware.

Move the request/upload into the (*auto_attach) so we can use the
comedi_load_firmware() helper.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: consolidate the firmware upload
H Hartley Sweeten [Mon, 20 May 2013 21:29:39 +0000 (14:29 -0700)]
staging: comedi: usbdux: consolidate the firmware upload

Absorb the usbdux_stop(), usbdux_upload(), and usbdux_start()
functions into firmware_upload().

Each of them just do a usb_control_msg() to the device and output
an error message if it fails. A similar message is also output by
firmware_upload() so the extra messages are redundant.

We can also share the malloc'ed local buffer needed for the
usb_control_msg().

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbdux: request firmware synchronously
H Hartley Sweeten [Mon, 20 May 2013 21:29:06 +0000 (14:29 -0700)]
staging: comedi: usbdux: request firmware synchronously

Change the request_firmware_nowait() to a request_firmware() so
that the usb_driver (*probe) can continue with the comedi_driver
(*auto_attach).

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxfast: use comedi_load_firmware()
H Hartley Sweeten [Mon, 20 May 2013 21:28:29 +0000 (14:28 -0700)]
staging: comedi: usbduxfast: use comedi_load_firmware()

Use comedi_load_firmware() instead of duplicating the code in a
private function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: dt9812: use comedi_to_usb_dev()
H Hartley Sweeten [Mon, 20 May 2013 21:27:48 +0000 (14:27 -0700)]
staging: comedi: dt9812: use comedi_to_usb_dev()

Use the helper function to get a usb_device pointer from a
comedi_device pointer. This removes the need for also getting
the usb_interface pointer in some cases.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: vmk80xx: remove usb_interface from private data
H Hartley Sweeten [Mon, 20 May 2013 21:27:13 +0000 (14:27 -0700)]
staging: comedi: vmk80xx: remove usb_interface from private data

This driver uses the comedi auto attach mechanism so the comedi_device
will always have an associated usb_interface and usb_device.

Remove the unnecessary checks if the comedi_device has a usb_interface
attached. This also allows removing the usb_interface from the private
data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: vmk80xx: use comedi_to_usb_dev()
H Hartley Sweeten [Mon, 20 May 2013 21:26:01 +0000 (14:26 -0700)]
staging: comedi: vmk80xx: use comedi_to_usb_dev()

Use the helper function to get a usb_device pointer from a
comedi_device pointer. This removes the need carring the
usb_device pointer in the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: vmk80xx: don't pass the private data directly
H Hartley Sweeten [Mon, 20 May 2013 21:24:32 +0000 (14:24 -0700)]
staging: comedi: vmk80xx: don't pass the private data directly

Instead of passing the private data to the internal functions. pass
the comedi_device pointer and get the private data from it.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: usbduxfast: use comedi_to_usb_dev()
H Hartley Sweeten [Mon, 20 May 2013 21:20:30 +0000 (14:20 -0700)]
staging: comedi: usbduxfast: use comedi_to_usb_dev()

Use the helper function to get a usb_device pointer from a
comedi_device pointer. This removes the need for also getting
the usb_interface pointer in some cases.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: comedi: introduce comedi_to_usb_dev()
H Hartley Sweeten [Mon, 20 May 2013 21:20:02 +0000 (14:20 -0700)]
staging: comedi: introduce comedi_to_usb_dev()

Introduce a helper function to get a usb_device pointer from a
comedi_device pointer.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoozwpan: replace kfree_skb with dev_kfree_skb in ozproto.c
Xenia Ragiadakou [Tue, 21 May 2013 10:18:59 +0000 (13:18 +0300)]
ozwpan: replace kfree_skb with dev_kfree_skb in ozproto.c

This patch replaces the calls to kfree_skb with
calls to dev_kfree_skb.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoozwpan: replace kfree_skb with dev_kfree_skb in ozpd.c
Xenia Ragiadakou [Tue, 21 May 2013 10:18:58 +0000 (13:18 +0300)]
ozwpan: replace kfree_skb with dev_kfree_skb in ozpd.c

This patch replaces the calls to kfree_skb with
calls to dev_kfree_skb.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c
Xenia Ragiadakou [Tue, 21 May 2013 10:18:57 +0000 (13:18 +0300)]
ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

This patch replaces the calls to alloc_skb with calls
to dev_alloc_skb.

dev_alloc_skb has GFP_ATOMIC priority so the
replacement does not change the code semantics.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoozwpan: replace alloc_skb with dev_alloc_skb in ozpd.c
Xenia Ragiadakou [Tue, 21 May 2013 10:18:56 +0000 (13:18 +0300)]
ozwpan: replace alloc_skb with dev_alloc_skb in ozpd.c

This patch replaces the calls to alloc_skb with calls
to dev_alloc_skb.

dev_alloc_skb has GFP_ATOMIC priority so the
replacement does not change the code semantics.

Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: btmtk_usb: remove unused including <linux/version.h>
Wei Yongjun [Tue, 21 May 2013 02:44:34 +0000 (10:44 +0800)]
staging: btmtk_usb: remove unused including <linux/version.h>

Remove including <linux/version.h> that don't need it.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoimx-drm: parallel-display: Let device core handle pinctrl
Fabio Estevam [Tue, 21 May 2013 14:24:46 +0000 (11:24 -0300)]
imx-drm: parallel-display: Let device core handle pinctrl

Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
we can rely on device core for handling pinctrl, so remove
devm_pinctrl_get_select_default() from the driver.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoimx-drm: imx-tve: Let device core handle pinctrl
Fabio Estevam [Tue, 21 May 2013 14:24:45 +0000 (11:24 -0300)]
imx-drm: imx-tve: Let device core handle pinctrl

Since commit ab78029 (drivers/pinctrl: grab default handles from device core)
we can rely on device core for handling pinctrl, so remove
devm_pinctrl_get_select_default() from the driver.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: cxt1e1: Replacing asm/io.h with linux/io.h
Dulshani Gunawardhana [Tue, 21 May 2013 16:14:35 +0000 (21:44 +0530)]
Staging: cxt1e1: Replacing asm/io.h with linux/io.h

This patch fixes the warning "Use #include <linux/io.h> instead of
<asm/io.h>" generated by using checkpatch.pi.

Signed-off-by: Dulshani Gunawardhana <dulshani.gunawardhana89@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/goldfish: Fixed up incorrect formatted comments.
Sara Bird [Mon, 20 May 2013 19:32:49 +0000 (15:32 -0400)]
staging/goldfish: Fixed up incorrect formatted comments.

The existing comments are using an odd style. Fixed them up to adhereto the
StyleGuide. No code changes.

Signed-off-by: Sara Bird <sara.bird.iar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/frontier: Fixed up incorrect formatted comments
Sara Bird [Mon, 20 May 2013 19:28:07 +0000 (15:28 -0400)]
staging/frontier: Fixed up incorrect formatted comments

The existing comments are using an odd style. Fixed them up to adhereto the
StyleGuide. No code changes.

Signed-off-by: Sara Bird <sara.bird.iar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/zsmalloc: Fixed up incorrect formatted comments
Sara Bird [Mon, 20 May 2013 19:18:14 +0000 (15:18 -0400)]
staging/zsmalloc: Fixed up incorrect formatted comments

The existing comments are using an odd style. Fixed them up to adhere
to the StyleGuide. No code changes.

Signed-off-by: Sara Bird <sara.bird.iar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/asus_oled: Fixed up incorrect formatted comments.
Sara Bird [Mon, 20 May 2013 19:14:42 +0000 (15:14 -0400)]
staging/asus_oled: Fixed up incorrect formatted comments.

The existing comments are using an odd style. Fixed them up to adhere
to the StyleGuide. No code changes.

Signed-off-by: Sara Bird <sara.bird.iar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: Fixes string split across lines in zram
Marlies Ruck [Thu, 16 May 2013 18:30:39 +0000 (14:30 -0400)]
Staging: Fixes string split across lines in zram

Fixes the following checkpatch warning in zram_drv.c:
WARNING: quoted string split across lines

Signed-off-by: Marlies Ruck <marlies.ruck@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: Fix lines over 80 chars in android sw_sync
Marlies Ruck [Wed, 15 May 2013 17:05:24 +0000 (13:05 -0400)]
staging: Fix lines over 80 chars in android sw_sync

Fixes the following checkpatch warning:
WARNING: Line over 80 characters

Signed-off-by: Marlies Ruck <marlies.ruck@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agoStaging: Fixes string split across lines in zsmalloc zsmalloc-main
Marlies Ruck [Wed, 15 May 2013 20:56:49 +0000 (16:56 -0400)]
Staging: Fixes string split across lines in zsmalloc zsmalloc-main

Fixes the following checkpatch warning:
WARNING: quoted string split across lines

Signed-off-by: Marlies Ruck <marlies.ruck@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/btmtk_usb: Mark local functions as static
Peter Huewe [Fri, 17 May 2013 21:51:58 +0000 (23:51 +0200)]
staging/btmtk_usb: Mark local functions as static

sparse complains about some local functions not being static:
drivers/staging/btmtk_usb/btmtk_usb.c:50:6:
warning: symbol 'hex_dump' was not declared. Should it be static?
drivers/staging/btmtk_usb/btmtk_usb.c:227:5:
warning: symbol 'checksume16' was not declared. Should it be static?

-> add the static keyword

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/btmtk_usb: use module_usb_driver to register driver
Peter Huewe [Fri, 17 May 2013 21:51:57 +0000 (23:51 +0200)]
staging/btmtk_usb: use module_usb_driver to register driver

Removing some boilerplate by using module_usb_driver instead of calling
register and unregister in the otherwise empty init/exit functions

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes line over 80 characters warning
Amarjargal Gundjalam [Fri, 17 May 2013 08:06:49 +0000 (01:06 -0700)]
keucr: fixes line over 80 characters warning

This patch fixes the following checkpatch warning,
WARNING: line over 80 characters

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes trailing whitespace error
Amarjargal Gundjalam [Fri, 17 May 2013 08:06:36 +0000 (01:06 -0700)]
keucr: fixes trailing whitespace error

This patch fixes the following checkpatch error,
ERROR: trailing whitespace

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes no spaces at the start of a line warning
Amarjargal Gundjalam [Fri, 17 May 2013 08:06:19 +0000 (01:06 -0700)]
keucr: fixes no spaces at the start of a line warning

This patch fixes the following checkpatch warning,
WARNING: please, no spaces at the start of a line

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes do not use C99 // comments error
Amarjargal Gundjalam [Fri, 17 May 2013 08:06:05 +0000 (01:06 -0700)]
keucr: fixes do not use C99 // comments error

This patch fixes the following checkpatch error,
ERROR: do not use C99 // comments

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: removes unused code from smilmain.c
Amarjargal Gundjalam [Fri, 17 May 2013 08:05:51 +0000 (01:05 -0700)]
keucr: removes unused code from smilmain.c

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes space prohibited before warning
Amarjargal Gundjalam [Fri, 17 May 2013 08:05:04 +0000 (01:05 -0700)]
keucr: fixes space prohibited before warning

This patch fixes the following checkpatch error and warning,
ERROR: space prohibited before open square bracket '['
WARNING: space prohibited before semicolon

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixed space prohibited between warning
Amarjargal Gundjalam [Fri, 17 May 2013 08:04:49 +0000 (01:04 -0700)]
keucr: fixed space prohibited between warning

This patch fixes the following checkpatch warning,
WARNING: space prohibited between function name and open parenthesis '('

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeurc: fixes spaces required around error
Amarjargal Gundjalam [Fri, 17 May 2013 08:04:33 +0000 (01:04 -0700)]
keurc: fixes spaces required around error

This patch fixes the following checkpatch error,
ERROR: spaces required around that ' '

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes space required before open parenthesis error
Amarjargal Gundjalam [Fri, 17 May 2013 08:04:18 +0000 (01:04 -0700)]
keucr: fixes space required before open parenthesis error

This patch fixes the following checkpatch error,
ERROR: space required before the open parenthesis '('

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes space required after error
Amarjargal Gundjalam [Fri, 17 May 2013 08:04:02 +0000 (01:04 -0700)]
keucr: fixes space required after error

This patch fixes the following checkpatch error,
ERROR: space required after that ' '

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes open brace go on the next line error
Amarjargal Gundjalam [Fri, 17 May 2013 08:03:41 +0000 (01:03 -0700)]
keucr: fixes open brace go on the next line error

This patch fixes the following checkpatch error,
ERROR: open brace '{' following function declarations go on the next
line

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes else should follow close brace error
Amarjargal Gundjalam [Fri, 17 May 2013 08:03:15 +0000 (01:03 -0700)]
keucr: fixes else should follow close brace error

This patch fixes the following checkpatch error,
ERROR: else should follow close brace '}'

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: fixes open brace should be on the previous line error
Amarjargal Gundjalam [Fri, 17 May 2013 08:02:50 +0000 (01:02 -0700)]
keucr: fixes open brace should be on the previous line error

This patch fixes the following checkpatch error,
ERROR: that open brace { should be on the previous line

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agokeucr: Fixes return is not a function error in smilmain.c
Amarjargal Gundjalam [Fri, 17 May 2013 08:02:22 +0000 (01:02 -0700)]
keucr: Fixes return is not a function error in smilmain.c

Fixes the following checkpatch error,
ERROR: return is not a function, parentheses are not required

Signed-off-by: Amarjargal Gundjalam <amarjargal16@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: fixed else format in ft1000_debug.c
Katja Collier [Fri, 17 May 2013 13:37:06 +0000 (15:37 +0200)]
staging: fixed else format in ft1000_debug.c

Put else statements on same line as if statement close bracket in
"/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c".

Signed-off-by: Katja Collier <katjacollier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: fixed spaces around parens in ft1000
Katja Collier [Fri, 17 May 2013 13:38:35 +0000 (15:38 +0200)]
staging: fixed spaces around parens in ft1000

Deleted extra spaces before and after parens, added a couple necessary
spaces before parens in
"/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c" and
"/drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h".

Signed-off-by: Katja Collier <katjacollier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: open braces in ft1000_debug.c and ioctl.h
Katja Collier [Fri, 17 May 2013 13:36:03 +0000 (15:36 +0200)]
staging: open braces in ft1000_debug.c and ioctl.h

Fixed open braces error in "/staging/ft1000/ft1000-usb/ft1000_ioctl.h"
and "/staging/ft1000/ft1000-usb/ft1000_debug.c" by moving braces to the
correct line.

Signed-off-by: Katja Collier <katjacollier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: improved comment style in ft1000_ioctl.h
Katja Collier [Fri, 17 May 2013 13:35:08 +0000 (15:35 +0200)]
staging: improved comment style in ft1000_ioctl.h

Replaced C99 style comments with C89 in
"/drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h".

Signed-off-by: Katja Collier <katjacollier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: improved comment style in ft1000_debug.c
Katja Collier [Fri, 17 May 2013 13:34:14 +0000 (15:34 +0200)]
staging: improved comment style in ft1000_debug.c

Replaced C99 style comments with C89 in
"/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c".

Signed-off-by: Katja Collier <katjacollier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging/xgifb: Remove dead assignments/increments
Peter Huewe [Fri, 17 May 2013 22:19:54 +0000 (00:19 +0200)]
staging/xgifb: Remove dead assignments/increments

The code now contains several dead assignments which are shadowed by
another assignment a few lines later.

-> This patch removes them (and possibly associated code).

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: lustre: fix to use list_for_each_entry_safe() when delete items
Wei Yongjun [Fri, 17 May 2013 08:27:05 +0000 (16:27 +0800)]
staging: lustre: fix to use list_for_each_entry_safe() when delete items

Since we will remove items off the list using list_del_init() we need
to use a safe version of the list_for_each_entry() macro aptly named
list_for_each_entry_safe().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: wlags49_h2: fix error return code in wl_adapter_insert()
Wei Yongjun [Fri, 17 May 2013 08:43:15 +0000 (16:43 +0800)]
staging: wlags49_h2: fix error return code in wl_adapter_insert()

When return from wl_adapter_insert() in the register_netdev() error
handling case, 'ret' which is 0 is returned, but we should return a
negative error code instead, so fix to return the return value of
register_netdev().

Introduce by commit 657d4c86d4cd85a4696445f6fb2fe0941a5724ff
(staging: wlags49_h2: fix error handling in pcmcia probe function)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
11 years agostaging: vt6655: Use alloc_etherdev() for kzalloc
Hema Prathaban [Fri, 17 May 2013 05:44:56 +0000 (11:14 +0530)]
staging: vt6655: Use alloc_etherdev() for kzalloc

Use alloc_etherdev() for kzalloc

Signed-off-by: Hema Prathaban <hemaklnce@gmail.com>
Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>