]>
git.karo-electronics.de Git - linux-beck.git/log
Larry Finger [Sun, 25 Aug 2013 16:55:15 +0000 (11:55 -0500)]
staging: r8188eu: Fix build errors for allyesconfig
This driver has some global names that are the same as found in
driver r8712. Fix the allyesconfig build errors by changing the
names of those routines.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Sun, 25 Aug 2013 16:49:37 +0000 (11:49 -0500)]
staging: gdm724x: Remove tests of KERNELVERSION
Kernel code need not test for KERNELVERSION. Besides being unnecessary
for an in-kernel driver, these lines will cause a build failure for any
source tree with a stale include/linux/version.h.
This patch is only compile tested.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 24 Aug 2013 17:36:49 +0000 (10:36 -0700)]
staging: line6: use default sysfs attribute macros
Move to use the DEVICE_ATTR_RW/RO macros, making it easier to audit the
sysfs file permissions, and get rid of the "empty" callback for
read-only files, saving lines of code.
Cc: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Laurent Navet <laurent.navet@gmail.com>
Cc: Johannes Thumshirn <morbidrsa@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 24 Aug 2013 17:34:53 +0000 (10:34 -0700)]
staging: quickstart: fix up sysfs file permissions
Use the default DEVICE_ATTR_RO/RW macros to specify the file permissions
better, and make them easier to audit.
And did we really want any user to be able to write to this file, I kind
of doubt it...
Cc: Jiang Liu <jiang.liu@huawei.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 24 Aug 2013 17:33:07 +0000 (10:33 -0700)]
staging: keucr: be explicit to the sysfs file permissions
Use the DEVICE_ATTR_RW() macro to be clearer as to the permissions for
the sysfs file, making it easier to audit the code.
Cc: Al Cho <acho@novell.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 24 Aug 2013 17:30:28 +0000 (10:30 -0700)]
staging: frontier: use better DEVICE_ATTR_ macros
Use the DEVICE_ATTR_RO/RW macros to better describe the permissions on
the file, and make them easier to audit.
Cc: David Täht <d@teklibre.com>
Cc: Sara Bird <sara.bird.iar@gmail.com>
Cc: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 24 Aug 2013 17:27:29 +0000 (10:27 -0700)]
staging: android: timed_output: fix sysfs file creation race
The sysfs file for the driver was being created _after_ the device was
announced to userspace, causing a race with any tools looking for sysfs
files.
Fix the race by using the default attribute group for the class.
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Sat, 24 Aug 2013 17:24:40 +0000 (10:24 -0700)]
staging: wlags49_h2: remove sysfs file
The sysfs file in this driver is showing a raft of debugging values,
none of which belong in sysfs, let alone in a single sysfs file. If
these really need to be described somewhere, they should go into
debugfs.
For now, just delete the sysfs file, which removes a bunch of files from
the tree.
Cc: Henk de Groot <pe1dnn@amsat.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Geert Uytterhoeven [Fri, 23 Aug 2013 15:46:48 +0000 (17:46 +0200)]
staging: lustre: Use proper constant types for L*_POISON values
On 32-bit m68k, I get lots of warnings like:
warning: integer constant is too large for ‘long’ type
Switch the L*_POISON definitions from too-large constants and casts
to the proper constant types to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare [Fri, 23 Aug 2013 15:11:02 +0000 (16:11 +0100)]
staging: ozwpan: Fix Documentation style.
This patch fixes Kernel Documentation style.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare [Fri, 23 Aug 2013 15:11:01 +0000 (16:11 +0100)]
staging: ozwpan: Fix wrong error check.
schedule_work() returns true if succeeded & false on failure,
error check was doing exactly reverse.
Also removes extra variable.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare [Fri, 23 Aug 2013 15:11:00 +0000 (16:11 +0100)]
staging: ozwpan: Remove memset
As we are initialising structure, we do not require
memset().
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 Aug 2013 13:37:48 +0000 (14:37 +0100)]
staging: vt6656: rxtx.c s_vFillTxKey fill structure vnt_mic_hdr
Replace the pointer offsets with structure of mic_hdr with
endian conversion where needed.
Replace vFillTxKey argument u8 *pMICHDR with struct vnt_mic_hdr *mic_hdr
and fix type of calling functions.
An extra check that mic_hdr is not NULL
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 Aug 2013 13:33:55 +0000 (14:33 +0100)]
staging: vt6656: desc.h Remove typedef struct tagSMICHDRHead to new structure in rxtx.h
To new structure.
typedef struct tagSMICHDRHead -> struct vnt_mic_hdr
This is only needed by rxtc.c so moved to rxtx.h
The new structure is the same size as the old but
contains the members as pointer referenced in
rxtx.c s_vFillTxKey
u8 id
*pMICHDR = 0x59;
u8 tx_priority;
*((u8 *)(pMICHDR+1)) = 0; // TxPriority
u8 mic_addr2[6];
memcpy(pMICHDR+2, &(pMACHeader->addr2[0]), 6);
__be32 tsc_47_16;
pMICHDR+8 = HIBYTE(HIWORD(pTransmitKey->dwTSC47_16));
pMICHDR+9 = LOBYTE(HIWORD(pTransmitKey->dwTSC47_16));
pMICHDR+10 = HIBYTE(LOWORD(pTransmitKey->dwTSC47_16));
pMICHDR+11 = LOBYTE(LOWORD(pTransmitKey->dwTSC47_16));
__be16 tsc_15_0;
pMICHDR+12 = HIBYTE(pTransmitKey->wTSC15_0);
pMICHDR+13 = LOBYTE(pTransmitKey->wTSC15_0);
__be16 payload_len;
pMICHDR+14 = HIBYTE(wPayloadLen);
pMICHDR+15 = LOBYTE(wPayloadLen);
__be16 hlen;
pMICHDR+16 = 0; // HLEN[15:8]
pMICHDR+17 = 28; // HLEN[7:0]
__le16 frame_control;
memcpy(pMICHDR+18, (u8 *)&wValue, 2); // MSKFRACTL
u8 addr1[6];
memcpy(pMICHDR+20, &(pMACHeader->addr1[0]), 6);
u8 addr2[6];
memcpy(pMICHDR+26, &(pMACHeader->addr2[0]), 6);
u8 addr3[6];
memcpy(pMICHDR+32, &(pMACHeader->addr3[0]), 6);
__le16 seq_ctrl;
memcpy(pMICHDR+38, (u8 *)&wValue, 2); // MSKSEQCTL
u8 addr4[6];
memcpy(pMICHDR+40, &(pMACHeader->addr4[0]), 6);
u16 packing; /* packing to 48 bytes */
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 Aug 2013 10:48:46 +0000 (11:48 +0100)]
staging: vt6656: rxtx.c endian correct wTimeStampOff
wTimeStampOff needs to be endian corrected
Create new function vnt_time_stamp_off to return little endian u16 value.
Private variable byPreambleType is common to all calling functions is included.
variable rate to set the desired rate.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 23 Aug 2013 10:32:26 +0000 (11:32 +0100)]
staging: vt6656: rxtx.c s_create new function to endian correct uGetTxRsvTime.
We can't endian correct uGetTxRsvTime because it is called by other functions.
Create new function to vnt_rxtx_rsvtime_le16 to return little endian u16
value.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Thu, 22 Aug 2013 20:03:40 +0000 (21:03 +0100)]
staging: vt6656: s_uGetRTSCTSRsvTime return u16 endian corrected value.
s_uGetRTSCTSRsvTime always needs to be corrected to u16 endian value.
Change function to return u16 endian corrected value.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 23 Aug 2013 13:43:39 +0000 (22:43 +0900)]
staging: gdm724x: Fix typo in comments
Correct spelling typo in comments within staging/gdm724x
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 23 Aug 2013 13:55:31 +0000 (22:55 +0900)]
staging: bcm: Fix typo in comments
Correct spelling typo in staging/bcm
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
navin patidar [Fri, 23 Aug 2013 12:54:02 +0000 (18:24 +0530)]
staging: rtl8187se: Remove pt_regs * irq handler parameter
struct pt_regs pointer is no longer passed as a irq handler
argument.
v2:
remove rtl8180_interrupt cast to (void *) .
Signed-off-by: navin patidar <navinp@cdac.in>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anthony Foiani [Fri, 23 Aug 2013 04:06:42 +0000 (22:06 -0600)]
staging: usbip: fix up alignment in long options list
Re-align the option lists.
Signed-off-by: Anthony Foiani <anthony.foiani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anthony Foiani [Fri, 23 Aug 2013 04:06:41 +0000 (22:06 -0600)]
staging: usbip: properly handle "-l" / "--log" option
This option is in the long options list, and it's handled in the
option processing loop, but the optstring didn't include it.
Signed-off-by: Anthony Foiani <anthony.foiani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anthony Foiani [Fri, 23 Aug 2013 04:06:40 +0000 (22:06 -0600)]
staging: usbip: set usbipd server port via "-t" / "--tcp-port" option.
Add an option "-t" / "--tcp-port" to specify the TCP port to listen
on. Downcase associated variables as they're no longer constants.
Signed-off-by: Anthony Foiani <anthony.foiani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anthony Foiani [Fri, 23 Aug 2013 04:06:39 +0000 (22:06 -0600)]
staging: usbip: add "-P" / "--pid" option to save usbipd process id
Introduce option "-P" / "--pid" to request that usbipd save its PID to
a file while running.
Signed-off-by: Anthony Foiani <anthony.foiani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Fri, 23 Aug 2013 02:17:12 +0000 (22:17 -0400)]
staging: dgap: removes proc.h
This patch removes the proc.h file and removes '#include
dgap_proc.h' from headers in the driver.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Fri, 23 Aug 2013 02:17:11 +0000 (22:17 -0400)]
staging: dgap: removes proc.c
This patch removes proc.c. This code isn't needed anymore because
a previous patch removed references to it and because the kernel
uses sysfs instead of proc.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Fri, 23 Aug 2013 02:17:10 +0000 (22:17 -0400)]
staging: dgap: removes references to proc code
This patch removes references to proc functions and
structs in the code. The kernel uses sysfs instead
of proc now.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Fri, 23 Aug 2013 01:35:19 +0000 (21:35 -0400)]
staging: dgap: removes mgmt.h
This patch removes mgmt.h and the headers that include
it of files in dgap. This file isn't needed for the
driver to work with the kernel.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Fri, 23 Aug 2013 01:35:18 +0000 (21:35 -0400)]
staging: dgap: removes mgmt.c
This patch removes mgmt.c. This file isn't needed for the
driver to work with the kernel.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Fri, 23 Aug 2013 01:35:17 +0000 (21:35 -0400)]
staging: dgap: removes references to mgmt code
This patch removes references to mgmt functions from
the code. The files mgmt.c and mgmt.h will be
removed in the patches that follow.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 18:54:15 +0000 (14:54 -0400)]
staging: dgnc: driver.c: removes dgnc_mbuf function
This patch removes the dgnc_mbuf function. This function was causing the
errors:
drivers/staging/dgnc/dgnc_driver.c: In function 'dgnc_mbuf.constprop.0':
drivers/staging/dgnc/dgnc_driver.c:945:1: warning: the frame size of 1032
bytes is larger than 1024 bytes [-Wframe-larger-than=]
drivers/staging/dgnc/dgnc_tty.c: In function 'dgnc_sniff_nowait_nolock':
drivers/staging/dgnc/dgnc_tty.c:614:1: warning: the frame size of 1056
bytes is larger than 1024 bytes [-Wframe-larger-than=]
This patch removes it so the kernel won't be making noise when its
device is found on the system.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 17:40:35 +0000 (13:40 -0400)]
staging: dgap: adds driver to kernel build
This patch adds the dgap driver to the kernel build process.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:15 +0000 (22:34 -0500)]
staging: r8188eu: Turn on build of new driver
This commit modifies drivers/staging/Makefile, and adds the
drivers/staging/rtl8188eu/Makefile.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:14 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 31
This commit adds files include/sta_info.h, include/usb_hal.h,
include/usb_ops.h, include/usb_ops_linux.h, include/usb_osintf.h,
include/usb_vendor_req.h, include/wifi.h, include/wlan_bssdef.h,
and include/xmit_osdep.h.
The commit also deleted include/autoconf.h, which is no longer needed.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:13 +0000 (22:34 -0500)]
staging: r8188eu: Insert Kconfig files for new driver
The configuration options include those to add code needed for
AP mode, and peer-to-peer mode.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:12 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 30
This commit adds files include/rtw_security.h, include/rtw_sreset.h,
include/rtw_version.h, and include/rtw_xmit.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:11 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 29
This commit adds files include/rtw_p2p.h, include/rtw_pwrctrl.h,
include/rtw_qos.h, include/rtw_recv.h, and include/rtw_rf.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:10 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 28
This commit adds files include/rtw_mlme.h, include/rtw_mlme_ext.h,
include/rtw_mp.h, include/rtw_mp_ioctl.h, and include/rtw_mp_phy_regdef.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:09 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 27
This commit adds files include/rtw_ht.h, include/rtw_io.h,
include/rtw_ioctl.h, include/rtw_ioctl_rtl.h, include/rtw_ioctl_set.h,
include/rtw_iol.h, and include/rtw_led.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:08 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 26
This commit adds files include/rtw_android.h, include/rtw_ap.h,
include/rtw_br_ext.h, include/rtw_cmd.h, include/rtw_debug.h,
include/rtw_eeprom.h, include/rtw_efuse.h, and include/rtw_event.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:07 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 25
This commit adds files include/recv_osdep.h, include/rtl8188e_cmd.h,
include/rtl8188e_dm.h, include/rtl8188e_hal.h, include/rtl8188e_led.h,
include/rtl8188e_recv.h, include/rtl8188e_rf.h, include/rtl8188e_spec.h,
include/rtl8188e_sreset.h, and include/rtl8188e_xmit.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:06 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 24
This commit adds files include/odm.h, include/odm_HWConfig.h,
include/odm_RTL8188E.h, include/odm_RegConfig8188E.h, include/odm_RegDefine11AC.h,
include/odm_RegDefine11N.h, include/odm_debug.h, include/odm_interface.h,
include/odm_precomp.h, include/odm_reg.h, include/odm_types.h,
include/osdep_intf.h, and include/osdep_service.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:05 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 23
This commit adds files include/ieee80211.h, include/ieee80211_ext.h,
include/if_ether.h, include/ioctl_cfg80211.h, include/ip.h,
include/mlme_osdep.h, include/mp_custom_oid.h, and include/nic_spec.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:04 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 22
This commit adds files include/Hal8188EFWImg_CE.h, include/Hal8188EPhyCfg.h,
include/Hal8188EPhyReg.h, include/Hal8188EPwrSeq.h, include/Hal8188ERateAdaptive.h,
include/Hal8188EReg.h, include/HalHWImg8188E_BB.h, include/HalHWImg8188E_FW.h,
include/HalHWImg8188E_MAC.h, include/HalHWImg8188E_RF.h, include/HalPhyRf.h,
include/HalPhyRf_8188e.h, include/HalPwrSeqCmd.h, and include/HalVerDef.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:03 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 21
This commit adds files include/autoconf.h, include/basic_types.h,
include/cmd_osdep.h, include/drv_types.h, include/drv_types_linux.h,
include/ethernet.h. include/h2clbk.h, include/hal_com.h, and include/hal_intf.h.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:02 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 20
This commit adds files os_dep/usb_intf.c, os_dep/usb_ops_linux.c,
and os_dep/xmit_linux.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:01 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 19
This commit adds files os_dep/os_intfs.c, os_dep/recv_linux.c,
and os_dep/rtw_android.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:34:00 +0000 (22:34 -0500)]
staging: r8188eu: Add files for new driver - part 18
This commit adds files hal/usb_halinit.c and hal/usb_ops_linux.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:59 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 17
This commit adds files hal/rtl8188eu_led.c, hal/rtl8188eu_recv.c,
and hal/rtl8188eu_xmit.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:58 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 16
This commit adds files os_dep/ioctl_linux.c, os_dep/mlme_linux.c, and
os_dep/osdep_service.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:57 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 15
This commit adds files hal/rtl8188e_rxdesc.c, hal/rtl8188e_sreset.c, and
hal/rtl8188e_xmit.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:56 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 14
This commit adds files hal/rtl8188e_hal_init.c, hal/rtl8188e_mp.c,
hal/rtl8188e_phycfg.c, and hal/rtl8188e_rf6052.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:55 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 13
This commit adds files hal/odm_RTL8188E.c, hal/odm_RegConfig8188E.c,
hal/rtl8188e_cmd.c, and hal/rtl8188e_dm.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:54 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 12
This commit adds files odm_HWConfig.c and odm_interface.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:53 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 11
This commit adds files hal/HalPwrSeqCmd.c, hal/odm.c, and hal/odm_debug.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:52 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 10
This commit adds files hal/HalPhyRf.c, hal/HalPhyRf_8188e.c, and hal/hal_intf.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:51 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 9
This commit adds files hal/HalHWImg8188E_BB.c, hal/HalHWImg8188E_MAC.c, hal/HalHWImg8188E_RF.c, and
hal/hal_com.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:50 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 8
This commit adds files hal/Hal8188EFWImg_CE.c, hal/Hal8188EPwrSeq.c, and hal/Hal8188ERateAdaptive.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:49 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 7
This commit adds core/rtw_wlan_util.c and core/rtw_xmit.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:48 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 6
This commit adds core/rtw_security.c, core/rtw_sreset.c, and core/rtw_sta_mgt.c.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:47 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 5
This commit adds core/rtw_pwrctrl.c, core/rtw_recv.c, and core/rtw_rf.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:46 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 4
This commit adds files core/rtw_led.c, core/rtw_mlme.c, core/rtw_mlme_ext.c,
core/rtw_mp.c, core/rtw_mp_ioctl.c, and core/rtw_p2p.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:45 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 3
This commit adds core/rtw_io.c, core/rtw_ioctl_set.c, and core/rtw_iol.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:44 +0000 (22:33 -0500)]
staging: r8188eu: Add files for new driver - part 2
This commit adds core/rtw_debug.c, core/rtw_efuse.c, and core/rtw_ieee80211.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 22 Aug 2013 03:33:43 +0000 (22:33 -0500)]
staging: r8188eu: Add source files for new driver - part 1
This commit adds core/rtw_ap.c, core/rtw_br_ext.c, and core/rtw_cmd.c
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare [Thu, 22 Aug 2013 16:38:51 +0000 (17:38 +0100)]
staging: ozwpan: Create deferred work to destroy PD object.
Currently we call oz_pd_destroy() from softirq context, where we
try to destroy relevant data structures, as well we kill a tasklet
which always result in following kernel warning.
[12279.262194] Attempt to kill tasklet from interrupt
[12279.262202] Attempt to kill tasklet from interrupt
This patch defers deallocation of data structures to work queue.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare [Thu, 22 Aug 2013 16:38:50 +0000 (17:38 +0100)]
staging: ozwpan: Increment reference counter.
Increment PD reference counter, on every timer event so that
we do not loose PD object by mistake.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare [Thu, 22 Aug 2013 16:38:49 +0000 (17:38 +0100)]
staging: ozwpan: Check error condition before creating endpoint.
Check if interface number is correct before creating an end point.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Rupesh Gujare [Thu, 22 Aug 2013 16:38:48 +0000 (17:38 +0100)]
staging: ozwpan: Fix crash for race condition.
Do not allocate a port to new device or process URB when its status is
yet to be read. This avoids race condition when USB core read hub
status a bit late, while new device tries to acquire port.
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:41 +0000 (21:48 -0400)]
staging: dgap: ifdef HAVE_UNLOCKED_IOCTL conditionals
This patch removes the HAVE_UNLOCKED_IOCTL conditional
statements from driver.c, mgmt.c and mgmt.h. This was
used to support older kernels. It isn't needed now.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:40 +0000 (21:48 -0400)]
staging: dgap: mgmt.c: removes unused variable
This patch removes the unused variable page
in mgmt.c.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:39 +0000 (21:48 -0400)]
staging: dgap: tty.c: fixes incompatible type error
This patch fixes the error: incompatible types when
assigning to type ‘struct ktermios *’ from type
‘struct ktermios’
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:38 +0000 (21:48 -0400)]
staging: dgap: tty.c: fixes ioctl param list
The declaration for the ioctl function has changed. The previous version
of this declaration took struct file *file as a parameter and the new
one does not. This patch removes that parameter.
It also removes cases for the commands TIOCGETP
TCGETS and TCGETA.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:37 +0000 (21:48 -0400)]
staging: dgap: tty.c: removes read_cnt, real_raw and rawreadok
This patch removes the use of read_cnt, real_raw and rawreadok.
These variables don't exist in the new API. Reading the data
raw is no longer supported by the tty layer.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:36 +0000 (21:48 -0400)]
staging: dgap: tty.c: fixes termios error
This patch fixes this error: invalid type
argument of ‘->’ (have ‘struct ktermios’).
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:35 +0000 (21:48 -0400)]
staging: dgap: tty.c: fixes errors with tty function calls
This patch fixes errors with the tty function calls
tty_buffer_request_room, tty_insert_flip_string_flags,
tty_insert_flip_string and tty_flip_buffer_push.
They now take struct tty_port as a parameter instead
of tty_struct.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:34 +0000 (21:48 -0400)]
staging: dgap: fep5.c: fixes errors with tty function calls
This patch fixes errors with the tty function calls
tty_buffer_request_room, tty_insert_flip_char and
tty_flip_buffer_push. They now take struct tty_port
as a parameter instead of tty_struct.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:33 +0000 (21:48 -0400)]
staging: dgap: removes references to proc code
This patch removes references to proc code in this
driver. It still has proc.c, proc.h and a board
state called NEEDS_PROC_CREATION. All three of
these will be removed in another patch.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Thu, 22 Aug 2013 01:48:32 +0000 (21:48 -0400)]
staging: dgap: fixes incompatible type error
This patch fixes the error: incompatible types
when assigning to type ‘struct ktermios *’ from
type ‘struct ktermios’
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Scott_Kilau@digi.com [Thu, 22 Aug 2013 01:48:31 +0000 (21:48 -0400)]
staging: dgap: adds dgap driver to staging
This patch adds the dgap driver to staging. This is
a TTY serial port driver for the EPCA PCI based
product line by Digi International <www.digi.com>.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 21 Aug 2013 21:16:04 +0000 (22:16 +0100)]
staging: vt6656: rxtx.c: s_uGetDataDuration Drop argument byDurType.
When byDurType == DATADUR_B then byPktType == PK_TYPE_11B
Drop argument byDurType and filter on byPktType == PK_TYPE_11B.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 21 Aug 2013 20:58:37 +0000 (21:58 +0100)]
staging: vt6656: rxtx.c s_uGetDataDuration return endian corrected u16.
The return always be u16 endian corrected. For the
large part this is missing.
Fix uGetDataDuration to return u16 endian corrected.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 20 Aug 2013 10:50:19 +0000 (11:50 +0100)]
staging: comedi: pcmuio: fix possible NULL deref on detach
pcmuio_detach() is called by the comedi core even if pcmuio_attach()
returned an error, so `dev->private` might be `NULL`. Check for that
before dereferencing it.
Also, as pointed out by Dan Carpenter, there is no need to check the
pointer passed to `kfree()` is non-NULL, so remove that check.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ian Abbott [Tue, 20 Aug 2013 15:55:41 +0000 (16:55 +0100)]
staging: comedi: pcmmio: remove unneeded checks on detach
As pointed out by Dan carpenter for the similar pcmuio driver, there is
no need to check the pointer passed to `kfree()`, so remove that check
from `pcmmio_detach()`.
Also, check the `devpriv` (`dev->private`) pointer once, outside the
`for` loop.
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat [Thu, 22 Aug 2013 08:06:57 +0000 (13:36 +0530)]
staging: xillybus: Remove duplicate inclusion of list.h
list.h header file was included twice.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tushar Behera [Thu, 22 Aug 2013 13:24:23 +0000 (18:54 +0530)]
staging: dgnc: driver.c: Need to include slab.h
With 'allyesconfig', we get following error without this.
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_cleanup_board’:
drivers/staging/dgnc/dgnc_driver.c:459:3: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
kfree(brd->msgbuf_head);
^
drivers/staging/dgnc/dgnc_driver.c: In function ‘dgnc_driver_kzmalloc’:
drivers/staging/dgnc/dgnc_driver.c:905:2: error: implicit declaration of function ‘kmalloc’ [-Werror=implicit-function-declaration]
void *p = kmalloc(size, priority);
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
Cc: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:30:11 +0000 (13:30 -0400)]
staging: dgnc: tty.c: fixes code indent error
This patch fixes the error "code indent should use
tabs where possible" in dgnc_tty.c.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:30:10 +0000 (13:30 -0400)]
staging: dgnc: sysfs.c: fixes code indent error
This patch fixes the error "code indent should use
tabs where possible" in dgnc_sysfs.c.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:30:09 +0000 (13:30 -0400)]
staging: dgnc: neo.c: fixes code indent error
This patch fixes the error "code indent should use
tabs where possible" in dgnc_neo.c.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:30:08 +0000 (13:30 -0400)]
staging: dgnc: driver.h: fixes code indent error
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.h.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:30:07 +0000 (13:30 -0400)]
staging: dgnc: driver.c: fixes code indent error
This patch fixes the error "code indent should use
tabs where possible" in dgnc_driver.c.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:27:26 +0000 (13:27 -0400)]
staging: dgnc: fixes struct declaration
This patch fixes the error: open brace '{'
following struct go on the same line.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:27:15 +0000 (13:27 -0400)]
staging: dgnc: tty.c: fixes pointer syntax
This patch fixes the error: "foo* bar" should be "foo *bar".
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Lidza Louina [Wed, 21 Aug 2013 17:26:40 +0000 (13:26 -0400)]
staging: dgnc: removes CVS code from files
This patch removes the code supporting CVS
from its files.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 20 Aug 2013 21:52:30 +0000 (22:52 +0100)]
staging: vt6656: baseband.c BBvCalculateParameter create structure for pwPhyLen, pbyPhySrv and pbyPhySgn
Create single packed structure vnt_phy_field for rxtx.h structures.
In card.c CARDvSetRSPINF a vnt_phy_field replaces abyServ,
abySignal, awLen variables.
In rxtx.c point BBvCalculateParameter to relevant field.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 20 Aug 2013 21:49:26 +0000 (22:49 +0100)]
staging: vt6656: baseband.c BBvCalculateParameter pwPhyLen return endian corrected.
In rxtx.c many calls to BBvCaculateParameter are not endian
corrected all calls here need to be endian corrected.
Correct the endian in BBvCaculateParameter.
In card.c: CARDvSetRSPINF pwPhyLen points to awLen and is
manually applied to abyData. Because it is now endian
corrected put_unaligned is needed to correct it.
In rxtx.c remove were endian is corrected.
This allows to merge BBvCalculateParameter *pwPhyLen,*pbyPhySrv
and *pbyPhySgn to singles structure for tx buffers.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Wed, 21 Aug 2013 08:30:08 +0000 (11:30 +0300)]
staging: drm/imx: ipu-dc: signedness bug in ipu_dc_init_sync()
"map" needs to be signed for the error handling to work. In the success
case then it holds a small non-negative value.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Marek Vasut <marex@denx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Wed, 21 Aug 2013 08:31:18 +0000 (11:31 +0300)]
staging: gdm7240: fix error handling of probe()
The error handling is messy and not in kernel style. On some paths it
frees "mux_dev" twice.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Wed, 21 Aug 2013 08:28:04 +0000 (11:28 +0300)]
staging: comedi: pcl812: missing break statement
Smatch complains that there is a missing break statement here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dan Carpenter [Tue, 20 Aug 2013 08:57:35 +0000 (11:57 +0300)]
staging: comedi: dt282x: dt282x_ai_insn_read() always fails
In dt282x_ai_insn_read() we call this macro like:
wait_for(!mux_busy(), comedi_error(dev, "timeout\n"); return -ETIME;);
Because the if statement doesn't have curly braces it means we always
return -ETIME and the function never succeeds.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Cc: stable <stable@vger.kernel.org> # 2.6.36+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>