This fixes some code style issues like prohibited spaces after that open
parenthesis '(' and before that close parenthesis ')', and lines over 80
characters.
Wolfram Sang [Sat, 20 Mar 2010 14:13:01 +0000 (15:13 +0100)]
Staging: go7007: fix dangling i2c pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Wolfram Sang [Sat, 20 Mar 2010 14:13:00 +0000 (15:13 +0100)]
Staging: dream: fix dangling i2c pointers
Fix I2C-drivers which missed setting clientdata to NULL before freeing the
structure it points to. Also fix drivers which do this _after_ the structure
was freed already.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vikram Dhillon [Mon, 15 Mar 2010 00:39:30 +0000 (20:39 -0400)]
Staging: arlan: arlan.h: Fixed some style issues
Fixed some style issues in accordance with checkpatch.pl. Before the
patch contained "total: 2 errors, 186 warnings, 535 lines checked" and
now it has: total: 0 errors, 170 warnings. Most of the warnings that
remain now are the line over 80 chars ones.
Steven Harms [Thu, 18 Mar 2010 14:15:59 +0000 (10:15 -0400)]
Staging: vt6655: Convert C99 style comments, remove spaces between function definitions and parenthesis
Converted C99 style comments to kernel style guideline complianet
comments. Removed spaces between function definitions and parenthesis.
These were indicated as problems by checkpatch tool.
Fixed typo found by Gabor Stefanik
Signed-off-by: Steven Harms <sharms@ubuntu.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Sun, 28 Mar 2010 11:48:10 +0000 (14:48 +0300)]
Staging: otus: hpani: using the wrong variable
We're updating the "HpPriv->ani" array here so we should use that to
determine the end of the for loop. "HpPriv->ani" has 50 elements and
"wd->regulationTable.allowChannel" has 59 elements.
Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Steven Harms [Sun, 14 Mar 2010 15:56:00 +0000 (11:56 -0400)]
Staging: otus: Remove mix of tabs and spaces with just tabs in ioctl.c
Previously defines had a mix of both tabs and spaces, causing an error
in the checkpatch tool. These tabs and spaces have been consolidated to
only tabs.
Signed-off-by: Steven Harms <sharms@ubuntu.com> Acked-by: Simon Horman <horms@verge.net.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ben Hutchings [Mon, 29 Mar 2010 00:24:45 +0000 (01:24 +0100)]
Staging: rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe
To avoid recurrence of bugs such as <http://bugs.debian.org/575726>,
change the type of the first parameter to linux_pci_{map,unmap}_single()
from void * to struct rt_rtmp_adapter *. Also do not define the macros
PCI_{MAP,UNMAP}_SINGLE() when building the rt2870sta driver; they are
not used and if they were that would be a bug.
Ruslan Pisarev [Sun, 14 Mar 2010 15:50:20 +0000 (17:50 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in inode.c
This is a patch to the inode.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Ruslan Pisarev [Sun, 14 Mar 2010 16:08:05 +0000 (18:08 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in netfs.h
This is a patch to the netfs.h file that fixed up a TAB and spaces
WARNING found by the checkpatch.pl tools, like
WARNING: please, no space before tabs
Ruslan Pisarev [Sun, 14 Mar 2010 16:00:08 +0000 (18:00 +0200)]
Staging: pohmelfs: fix comments, spaces and TAB coding style issue in netfs.h
This is a patch to the netfs.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: do not use C99 // comments
Ruslan Pisarev [Sun, 14 Mar 2010 15:39:46 +0000 (17:39 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in dir.c
This is a patch to the dir.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Ruslan Pisarev [Sun, 14 Mar 2010 15:11:03 +0000 (17:11 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in config.c
This is a patch to the config.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like:
ERROR: switch and case should be at the same indent
Ruslan Pisarev [Sun, 14 Mar 2010 15:25:09 +0000 (17:25 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in crypto.c
This is a patch to the crypto.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: switch and case should be at the same indent
and
spaces required around that '=' (ctx:VxV)
Staging: comedi: drivers: fix coding style issues in das08.c
This is a patch to the das08.c file that fixes up the following issues
found by the checkpatch.pl tool.
WARNING: line over 80 characters x 6
ERROR: code indent should use tabs where possible x 3
ERROR: spaces required around that '?' (ctx:VxV) x 4
ERROR: spaces required around that ':' (ctx:VxV) x 4
ERROR: that open brace { should be on the previous line x 1
WARNING: printk() should include KERN_ facility level x 9
WARNING: braces {} are not necessary for single statement blocks x 1
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable x 2
Staging: comedi: drivers: fix coding style issues in das16.c
This is a patch to the das16.c file that fixes up the following issues
found by the checkpatch.pl tool.
WARNING: line over 80 characters x 23
ERROR: spaces required around that '?' (ctx:VxV) x 2
ERROR: spaces required around that ':' (ctx:VxV) x 2
WARNING: printk() should include KERN_ facility level x 17
WARNING: braces {} are not necessary for single statement blocks x 8
Ruslan Pisarev [Tue, 16 Mar 2010 15:24:47 +0000 (17:24 +0200)]
Staging: hv: fix spaces coding style issue in vstorage.h
This is a patch to the vstorage.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that ':' (ctx:VxV)
Pavel Machek [Sat, 13 Mar 2010 11:20:05 +0000 (12:20 +0100)]
Staging: windbond: camelCase should be fixed
(BTW, winbond/README alias winbond/TODO doesn't mention it, but another
(trivial) step is going to be to change variable names and function
names from CamelCase to lower_case spelling.)
Signed-off-by: Pavel Machek <pavel@ucw.cz> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 13 Mar 2010 08:22:39 +0000 (09:22 +0100)]
Staging: dream: Kconfig fix for non-HTC hardware
> All of the Kconfig menu items under "config DREAM" should be listed
> indented under the 'DREAM' symbol, but they are not. (using xconfig)
> In menuconfig, the DREAM symbol isn't listed (since it depends on BROKEN),
> but the other (subordinate) symbols are still listed.
Ok, this should fix it ... or at least make it better an non-issue for
people with non-HTC hardware.
Signed-off-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
The wait_ibsyclr function is supposed to return the status of the I2C
cycle. Currently it will always return FALSE because the IIC_CSR2
register is not re-read in order to update the cached register value.
This results in the NEW_CYCLE bit still being 1.
The current code actually works correctly only because the return
value of {Read|Write}I2C is not checked in the driver.
Fix wait_ibsyclr by actually reading the IIC_CSR2 register to get the
updated status. While here, change the return type to be an actual
errno instead of the private TRUE/FALSE define and remove the now
obvious comments about the return value.
Also, remove the local variable 'writestat' in WriteI2C and just
return the result of wait_ibsyclr.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Scott Smedley <ss@aao.gov.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Wed, 10 Mar 2010 23:21:20 +0000 (00:21 +0100)]
Staging: crystalhd: Whitespace fixes, indentation fixes and 3 changed #includes
These patches fixes some whitspace and indentation warnings from
checkpatch.pl
Also these changed #includes:
bc_dts_glob_lnx.h:43: WARNING: Use #include <linux/param.h> instead of <asm/param.h>
rystalhd_lnx.h:45: WARNING: Use #include <linux/io.h> instead of <asm/io.h>
crystalhd_lnx.h:49: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
It all compiles fine, but I don't have the hardware to test with..
Signed-off-by: Lars Lindley <lindley@coyote.org> Cc: Jarod Wilson <jarod@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Patrick Rooney [Wed, 10 Mar 2010 08:46:30 +0000 (08:46 +0000)]
Staging: wlan-ng: Fixed 80-character line coding style issues in p80211req.c
This is a patch for p80211req.c. An 'if' statement that spanned 80
characters has been split onto 2 lines and one of the tabs preceding
a comment has been removed.
Signed-off-by: Patrick Rooney <candyguitar@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
projects / linux-beck.git / log