]> git.karo-electronics.de Git - linux-beck.git/commit
ovl: Copy up underlying inode's ->i_mode to overlay inode
authorVivek Goyal <vgoyal@redhat.com>
Fri, 1 Jul 2016 20:34:25 +0000 (16:34 -0400)
committerMiklos Szeredi <mszeredi@redhat.com>
Mon, 4 Jul 2016 14:49:48 +0000 (16:49 +0200)
commit07a2daab49c549a37b5b744cbebb6e3f445f12bc
treeb4f7c6d92ba68a6328c64d2ce28e48f9da99c78f
parentb99c2d913810e56682a538c9f2394d76fca808f8
ovl: Copy up underlying inode's ->i_mode to overlay inode

Right now when a new overlay inode is created, we initialize overlay
inode's ->i_mode from underlying inode ->i_mode but we retain only
file type bits (S_IFMT) and discard permission bits.

This patch changes it and retains permission bits too. This should allow
overlay to do permission checks on overlay inode itself in task context.

[SzM] It also fixes clearing suid/sgid bits on write.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reported-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
Cc: <stable@vger.kernel.org>
fs/overlayfs/inode.c
fs/overlayfs/overlayfs.h