]> git.karo-electronics.de Git - karo-tx-linux.git/commit
power: bq2415x_charger: Properly handle ENODEV from power_supply_get_by_phandle
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Wed, 15 Oct 2014 14:25:09 +0000 (16:25 +0200)
committerSebastian Reichel <sre@kernel.org>
Tue, 28 Oct 2014 02:30:08 +0000 (03:30 +0100)
commit0eaf437aa14949d2230aeab7364f4ab47901304a
tree3d9355d15ac668f0e8422d528f444c8bc3d03094
parent8000ebf76224a01adab9c1c16c341f54706292d5
power: bq2415x_charger: Properly handle ENODEV from power_supply_get_by_phandle

The power_supply_get_by_phandle() on error returns ENODEV or NULL.
The driver later expects obtained pointer to power supply to be
valid or NULL. If it is not NULL then it dereferences it in
bq2415x_notifier_call() which would lead to dereferencing ENODEV-value
pointer.

Properly handle the power_supply_get_by_phandle() error case by
replacing error value with NULL. This indicates that usb charger
detection won't be used.

Fix also memory leak of 'name' if power_supply_get_by_phandle() fails
with NULL and probe should defer.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Fixes: faffd234cf85 ("bq2415x_charger: Add DT support")
Cc: <stable@vger.kernel.org>
[small fix regarding the missing ti,usb-charger-detection info message]
Signed-off-by: Sebastian Reichel <sre@kernel.org>
drivers/power/bq2415x_charger.c