]> git.karo-electronics.de Git - karo-tx-linux.git/commit
tipc: advance the time of deleting subscription from subscriber->subscrp_list
authorYing Xue <ying.xue@windriver.com>
Tue, 28 Mar 2017 10:28:27 +0000 (12:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 Mar 2017 01:03:32 +0000 (18:03 -0700)
commit139bb36f754adbf6d3c836db09d6459e25167b38
tree67aaf23ea8b620ffeba8fd79273d480811b8cf5c
parent589a1a2e63163bdd59f983d6cd89cec5f9457823
tipc: advance the time of deleting subscription from subscriber->subscrp_list

After a subscription object is created, it's inserted into its
subscriber subscrp_list list under subscriber lock protection,
similarly, before it's destroyed, it should be first removed from
its subscriber->subscrp_list. Since the subscription list is
accessed with subscriber lock, all the subscriptions are valid
during the lock duration. Hence in tipc_subscrb_subscrp_delete(), we
remove subscription get/put and the extra subscriber unlock/lock.

After this change, the subscriptions refcount cleanup is very simple
and does not access any lock.

Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/subscr.c