]> git.karo-electronics.de Git - linux-beck.git/commit
ext4: wait on all pending commits in ext4_sync_fs()
authorTheodore Ts'o <tytso@mit.edu>
Mon, 3 Nov 2008 23:10:55 +0000 (18:10 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 3 Nov 2008 23:10:55 +0000 (18:10 -0500)
commit14ce0cb411c88681ab8f3a4c9caa7f42e97a3184
treed441a71e13e68cb7651888ced97dbaf90b45b9b5
parentd94e99a64c3beece22dbfb2b335771a59184eb0a
ext4: wait on all pending commits in ext4_sync_fs()

In ext4_sync_fs, we only wait for a commit to finish if we started it,
but there may be one already in progress which will not be synced.

In the case of a data=ordered umount with pending long symlinks which
are delayed due to a long list of other I/O on the backing block
device, this causes the buffer associated with the long symlinks to
not be moved to the inode dirty list in the second phase of
fsync_super.  Then, before they can be dirtied again, kjournald exits,
seeing the UMOUNT flag and the dirty pages are never written to the
backing block device, causing long symlink corruption and exposing new
or previously freed block data to userspace.

To ensure all commits are synced, we flush all journal commits now
when sync_fs'ing ext4.

Signed-off-by: Arthur Jones <ajones@riverbed.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: Eric Sandeen <sandeen@redhat.com>
Cc: <linux-ext4@vger.kernel.org>
fs/ext4/super.c