]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drivers/vlynq/vlynq.c: fix resource size off by 1 error
authorJulia Lawall <julia@diku.dk>
Wed, 23 Sep 2009 22:57:36 +0000 (15:57 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 24 Sep 2009 14:21:05 +0000 (07:21 -0700)
commit3354f73b24c6d392ed7fd5583cfcc7604c1934ae
treeb1c72139bef6d31eebcc72af5634f303c5242e69
parenta21f3c2a04d8a8d26b4bf3523368380feb8742b7
drivers/vlynq/vlynq.c: fix resource size off by 1 error

In this case, the calls to request_mem_region, ioremap, and
release_mem_region all have a consistent length argument, len, but since
in other files (res->end - res->start) + 1, equivalent to
resource_size(res), is used for a resource-typed structure res, one could
consider whether the same should be done here.

The problem was found using the following semantic patch:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
struct resource *res;
@@

- (res->end - res->start) + 1
+ resource_size(res)

@@
struct resource *res;
@@

- res->end - res->start
+ BAD(resource_size(res))
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/vlynq/vlynq.c