]> git.karo-electronics.de Git - karo-tx-linux.git/commit
af_unix: Avoid socket->sk NULL OOPS in stream connect security hooks.
authorDavid S. Miller <davem@davemloft.net>
Wed, 5 Jan 2011 23:38:53 +0000 (15:38 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jan 2011 23:38:53 +0000 (15:38 -0800)
commit3610cda53f247e176bcbb7a7cca64bc53b12acdb
treed780bc1e405116e75a194b2f4693a6f9bbe9f58f
parent44b8288308ac9da27eab7d7bdbf1375a568805c3
af_unix: Avoid socket->sk NULL OOPS in stream connect security hooks.

unix_release() can asynchornously set socket->sk to NULL, and
it does so without holding the unix_state_lock() on "other"
during stream connects.

However, the reverse mapping, sk->sk_socket, is only transitioned
to NULL under the unix_state_lock().

Therefore make the security hooks follow the reverse mapping instead
of the forward mapping.

Reported-by: Jeremy Fitzhardinge <jeremy@goop.org>
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/security.h
net/unix/af_unix.c
security/capability.c
security/security.c
security/selinux/hooks.c
security/smack/smack_lsm.c