]> git.karo-electronics.de Git - karo-tx-linux.git/commit
can: fix loss of CAN frames in raw_rcv
authorOliver Hartkopp <socketcan@hartkopp.net>
Sun, 21 Jun 2015 16:50:44 +0000 (18:50 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 21 Jun 2015 16:58:58 +0000 (18:58 +0200)
commit36c01245eb8046c16eee6431e7dbfbb302635fa8
treef53ded9bf6c16fdc6fcb5c9ef9633addf3945fea
parent7b48f45797be7c4bdbb772de80efe6bdcd78e81d
can: fix loss of CAN frames in raw_rcv

As reported by Manfred Schlaegl here

   http://marc.info/?l=linux-netdev&m=143482089824232&w=2

commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for
overlapping CAN filters" requires the skb->tstamp to be set to check for
identical CAN skbs.

As net timestamping is influenced by several players (netstamp_needed and
netdev_tstamp_prequeue) Manfred missed a proper timestamp which leads to
CAN frame loss.

As skb timestamping became now mandatory for CAN related skbs this patch
makes sure that received CAN skbs always have a proper timestamp set.
Maybe there's a better solution in the future but this patch fixes the
CAN frame loss so far.

Reported-by: Manfred Schlaegl <manfred.schlaegl@gmx.at>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/dev.c
drivers/net/can/slcan.c
drivers/net/can/vcan.c
net/can/af_can.c