]> git.karo-electronics.de Git - karo-tx-linux.git/commit
netlink: Use random autobind rover
authorHerbert Xu <herbert@gondor.apana.org.au>
Sun, 17 May 2015 02:45:34 +0000 (10:45 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 18 May 2015 03:43:31 +0000 (23:43 -0400)
commitb9fbe709de4dbe663613ebb852f35aef2467872c
tree028eeb771c3f596b66853dce3a22d93425848187
parentde133464c9e70808d3e5a861294bc55940988178
netlink: Use random autobind rover

Currently we use a global rover to select a port ID that is unique.
This used to work consistently when it was protected with a global
lock.  However as we're now lockless, the global rover can exhibit
pathological behaviour should multiple threads all stomp on it at
the same time.

Granted this will eventually resolve itself but the process is
suboptimal.

This patch replaces the global rover with a pseudorandom starting
point to avoid this issue.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c