]> git.karo-electronics.de Git - linux-beck.git/commit
mlxsw: switchx2: Fix memory leak at skb reallocation
authorArkadi Sharshevsky <arkadis@mellanox.com>
Thu, 12 Jan 2017 08:10:38 +0000 (09:10 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jan 2017 14:25:55 +0000 (09:25 -0500)
commit400fc0106dd8c27ed84781c929c1a184785b9c79
tree61efb523b2ab9f7f559cce38a385f23fa78a4f9b
parent36bf38d158d3482119b3e159c0619b3c1539b508
mlxsw: switchx2: Fix memory leak at skb reallocation

During transmission the skb is checked for headroom in order to
add vendor specific header. In case the skb needs to be re-allocated,
skb_realloc_headroom() is called to make a private copy of the original,
but doesn't release it. Current code assumes that the original skb is
released during reallocation and only releases it at the error path
which causes a memory leak.

Fix this by adding the original skb release to the main path.

Fixes: d003462a50de ("mlxsw: Simplify mlxsw_sx_port_xmit function")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/switchx2.c