]> git.karo-electronics.de Git - linux-beck.git/commit
can: fix NOHZ local_softirq_pending 08 warning
authorOliver Hartkopp <oliver@hartkopp.net>
Tue, 15 Sep 2009 08:31:34 +0000 (01:31 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 15 Sep 2009 08:31:34 +0000 (01:31 -0700)
commit481a8199142c050b72bff8a1956a49fd0a75bbe0
tree66bcd9798738a760c9982d62b9a39b57774e8349
parent0b6a05c1dbebe8c616e2e5b0f52b7a01fd792911
can: fix NOHZ local_softirq_pending 08 warning

When using nanosleep() in an userspace application we get a ratelimit warning

NOHZ: local_softirq_pending 08

for 10 times.

The echo of CAN frames is done from process context and softirq context only.
Therefore the usage of netif_rx() was wrong (for years).

This patch replaces netif_rx() with netif_rx_ni() which has to be used from
process/softirq context. It also adds a missing comment that can_send() must
no be used from hardirq context.

Signed-off-by: Oliver Hartkopp <oliver@hartkopp.net>
Signed-off-by: Urs Thuermann <urs@isnogud.escape.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/vcan.c
net/can/af_can.c