]> git.karo-electronics.de Git - karo-tx-linux.git/commit
vfs: Revert spurious fix to spinning prevention in prune_icache_sb
authorSuleiman Souhlal <suleiman@google.com>
Sat, 13 Apr 2013 23:03:06 +0000 (16:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 13 Apr 2013 23:13:55 +0000 (16:13 -0700)
commit5b55d708335a9e3e4f61f2dadf7511502205ccd1
tree83e4687e7be804ede22f993a901264dddb001018
parenta49b7e82cab0f9b41f483359be83f44fbb6b4979
vfs: Revert spurious fix to spinning prevention in prune_icache_sb

Revert commit 62a3ddef6181 ("vfs: fix spinning prevention in prune_icache_sb").

This commit doesn't look right: since we are looking at the tail of the
list (sb->s_inode_lru.prev) if we want to skip an inode, we should put
it back at the head of the list instead of the tail, otherwise we will
keep spinning on it.

Discovered when investigating why prune_icache_sb came top in perf
reports of a swapping load.

Signed-off-by: Suleiman Souhlal <suleiman@google.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: stable@vger.kernel.org # v3.2+
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/inode.c