]> git.karo-electronics.de Git - linux-beck.git/commit
pinctrl: sh-pfc: Do not unconditionally support PIN_CONFIG_BIAS_DISABLE
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Sat, 12 Nov 2016 16:04:24 +0000 (17:04 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Tue, 15 Nov 2016 10:01:09 +0000 (11:01 +0100)
commit5d7400c4acbf7fe633a976a89ee845f7333de3e4
treec49c3b910e3ef2f76d61dce3b4794746d48eec7b
parentcccc618a0b74867efb2211be6573ecf729a56ed0
pinctrl: sh-pfc: Do not unconditionally support PIN_CONFIG_BIAS_DISABLE

Always stating PIN_CONFIG_BIAS_DISABLE is supported gives untrue output
when examining /sys/kernel/debug/pinctrl/e6060000.pfc/pinconf-pins if
the operation get_bias() is implemented but the pin is not handled by
the get_bias() implementation. In that case the output will state that
"input bias disabled" indicating that this pin has bias control
support.

Make support for PIN_CONFIG_BIAS_DISABLE depend on that the pin either
supports SH_PFC_PIN_CFG_PULL_UP or SH_PFC_PIN_CFG_PULL_DOWN. This also
solves the issue where SoC specific implementations print error messages
if their particular implementation of {set,get}_bias() is called with a
pin it does not know about.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/sh-pfc/pinctrl.c