]> git.karo-electronics.de Git - linux-beck.git/commit
zram: avoid invalid memory access in zram_exit()
authorJiang Liu <liuj97@gmail.com>
Thu, 6 Jun 2013 16:07:22 +0000 (00:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Jun 2013 19:12:19 +0000 (12:12 -0700)
commit6030ea9b35971a4200062f010341ab832e878ac9
tree4428a72c07715d6c43c9ab2ae92f3e0ba3341b73
parent0ea0dcff90a4a186e3c5d51f1db4b277b3a0d228
zram: avoid invalid memory access in zram_exit()

Memory for zram->disk object may have already been freed after returning
from destroy_device(zram), then it's unsafe for zram_reset_device(zram)
to access zram->disk again.

We can't solve this bug by flipping the order of destroy_device(zram)
and zram_reset_device(zram), that will cause deadlock issues to the
zram sysfs handler.

So fix it by holding an extra reference to zram->disk before calling
destroy_device(zram).

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/zram/zram_drv.c