]> git.karo-electronics.de Git - linux-beck.git/commit
drm/i915: move i9xx dpll enabling into crtc enable function
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 16 Jun 2013 19:24:16 +0000 (21:24 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 1 Jul 2013 09:27:54 +0000 (11:27 +0200)
commit66e3d5c09940d08d94b03e65b420fadaa7484318
tree971c7ca3eb5324e1e073c36b6da213f510a81745
parent8bcc2795a68ad9c2010fd5a2548432fad930fcc1
drm/i915: move i9xx dpll enabling into crtc enable function

Now that we have the proper pipe config to track this, we don't need
to write any registers any more.

Note that for platforms without DPLL_MD (pre-gen4) which store the
pixel mutliplier in the DPLL register I've decided to keep the
seemingly "redundant" write: The comment right below saying "do this
trice for luck" doesn't instill confidence ...

v2: Drop a few now unnecessary local variables and switch the enable
function to take a struct intel_crtc * to simply arguments.

v3: Rebase on top of the newly-colored BUG_ON.

v4: Amend commit message to alliviate Imre's comment about the
redudant DPLL write for the pixel mutliplier.

Cc: Imre Deak <imre.deak@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c