]> git.karo-electronics.de Git - karo-tx-linux.git/commit
isci: fix isci_pci_probe() generates warning on efi failure path
authorDan Williams <dan.j.williams@intel.com>
Fri, 22 Jun 2012 18:31:14 +0000 (11:31 -0700)
committerDan Williams <dan.j.williams@intel.com>
Tue, 3 Jul 2012 19:09:30 +0000 (12:09 -0700)
commit6d70a74ffd616073a68ae0974d98819bfa8e6da6
tree5ad1db7feeabb7eb5bc6154f6a60db9ba5463167
parentf8f5701bdaf9134b1f90e5044a82c66324d2073f
isci: fix isci_pci_probe() generates warning on efi failure path

The oem parameter image embedded in the efi variable is at an offset
from the start of the variable.  However, in the failure path we try to
free the 'orom' pointer which is only valid when the paramaters are
being read from the legacy option-rom space.

Since failure to load the oem parameters is unlikely and we keep the
memory around in the success case just defer all de-allocation to devm.

Cc: <stable@vger.kernel.org>
Reported-by: Don Morris <don.morris@hp.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/scsi/isci/init.c
drivers/scsi/isci/probe_roms.c