]> git.karo-electronics.de Git - karo-tx-linux.git/commit
fs: Fix imbalance in freeze protection in mark_files_ro()
authorJan Kara <jack@suse.cz>
Wed, 5 Dec 2012 13:40:14 +0000 (14:40 +0100)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 20 Dec 2012 18:57:36 +0000 (13:57 -0500)
commit72651cac884b1e285fa8e8314b10e9f1b8458802
tree8872407cd5c36f52054c18f11b7b8470dccb1d6e
parent39e3c9553f34381a1b664c27b0c696a266a5735e
fs: Fix imbalance in freeze protection in mark_files_ro()

File descriptors (even those for writing) do not hold freeze protection.
Thus mark_files_ro() must call __mnt_drop_write() to only drop protection
against remount read-only. Calling mnt_drop_write_file() as we do now
results in:

[ BUG: bad unlock balance detected! ]
3.7.0-rc6-00028-g88e75b6 #101 Not tainted
-------------------------------------
kworker/1:2/79 is trying to release lock (sb_writers) at:
[<ffffffff811b33b4>] mnt_drop_write+0x24/0x30
but there are no more locks to release!

Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/file_table.c