]> git.karo-electronics.de Git - karo-tx-linux.git/commit
cifs: ensure that we always do cifsFileInfo_get under the spinlock
authorJeff Layton <jlayton@redhat.com>
Wed, 25 Jul 2012 18:59:54 +0000 (14:59 -0400)
committerSteve French <smfrench@gmail.com>
Wed, 25 Jul 2012 19:51:30 +0000 (14:51 -0500)
commit764a1b1acecedfe204cb2e80d8e2cc7c6df1b0b8
treeaf7744be5e620a924d057a8593babea75be5799d
parent29e20f9c65fae245d6fd4fce31cc5d01cde3d93f
cifs: ensure that we always do cifsFileInfo_get under the spinlock

The readpages bug is a regression that was introduced in 6993f74a5.
This also fixes a couple of similar bugs in the uncached read and write
codepaths.

Also, prevent this sort of thing in the future by having cifsFileInfo_get
take the spinlock itself, and adding a _locked variant for use in places
that are already holding the lock. The _put code has always done that
so this makes for a less confusing interface.

Cc: <stable@vger.kernel.org> # 3.5.x
Reviewed-by: Pavel Shilovsky <pshilovsky@samba.org>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <smfrench@gmail.com>
fs/cifs/cifsglob.h
fs/cifs/file.c