]> git.karo-electronics.de Git - linux-beck.git/commit
drm: Nerf DRM_CONTROL nodes
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 28 Oct 2016 08:10:50 +0000 (10:10 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 17 Nov 2016 07:41:31 +0000 (08:41 +0100)
commit8a357d10043c75e980e7fcdb60d2b913491564af
tree24d86524524b5ef2011e580cbc849da478de7e22
parentb7c0e47d98249c2ddf21ea197b651093c6aaee00
drm: Nerf DRM_CONTROL nodes

Looking at the ioctl permission checks I noticed that it's impossible
to import gem buffers into a control nodes, and fd2handle/handle2fd
also don't work, so no joy with dma-bufs.

The only way to do anything with a control node is by drawing stuff
into a dumb buffer and displaying that. I suspect control nodes are an
entirely unused thing, and a cursory check shows that there does not
seem to be any callers of drmOpenControl nor of the other drmOpen
functions using DRM_MODE_CONTROL.

Since I don't like dead uabi, let's remove it. But since this would be
a really big change I think it's better to start out small by simply
not registering anything. We can garbage-collect the dead code later
on, once we're sure it's really not used anywhere.

Acked-by: Dave Airlie <airlied@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20161028081050.1042-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_drv.c