]> git.karo-electronics.de Git - karo-tx-linux.git/commit
l2tp: Restore socket refcount when sendmsg succeeds
authorGuillaume Nault <g.nault@alphalink.fr>
Fri, 1 Mar 2013 05:02:02 +0000 (05:02 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Mar 2013 19:13:09 +0000 (14:13 -0500)
commit8b82547e33e85fc24d4d172a93c796de1fefa81a
tree549b58a0e731a1aa6a028c0200d065c125a1080d
parent32fcafbcd1c9f6c7013016a22a5369b4acb93577
l2tp: Restore socket refcount when sendmsg succeeds

The sendmsg() syscall handler for PPPoL2TP doesn't decrease the socket
reference counter after successful transmissions. Any successful
sendmsg() call from userspace will then increase the reference counter
forever, thus preventing the kernel's session and tunnel data from
being freed later on.

The problem only happens when writing directly on L2TP sockets.
PPP sockets attached to L2TP are unaffected as the PPP subsystem
uses pppol2tp_xmit() which symmetrically increase/decrease reference
counters.

This patch adds the missing call to sock_put() before returning from
pppol2tp_sendmsg().

Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_ppp.c