]> git.karo-electronics.de Git - karo-tx-linux.git/commit
virtio-blk: Fix hot-unplug race in remove method
authorAsias He <asias@redhat.com>
Fri, 4 May 2012 12:22:04 +0000 (20:22 +0800)
committerRusty Russell <rusty@rustcorp.com.au>
Tue, 22 May 2012 02:46:13 +0000 (12:16 +0930)
commitb79d866c8b7014a51f611a64c40546109beaf24a
treeb20a73e60302c74e9a3e0663819cac6c52470c2b
parent90e03207f468e84258270ad07095ef50f925c17d
virtio-blk: Fix hot-unplug race in remove method

If we reset the virtio-blk device before the requests already dispatched
to the virtio-blk driver from the block layer are finised, we will stuck
in blk_cleanup_queue() and the remove will fail.

blk_cleanup_queue() calls blk_drain_queue() to drain all requests queued
before DEAD marking. However it will never success if the device is
already stopped. We'll have q->in_flight[] > 0, so the drain will not
finish.

How to reproduce the race:
1. hot-plug a virtio-blk device
2. keep reading/writing the device in guest
3. hot-unplug while the device is busy serving I/O

Test:
~1000 rounds of hot-plug/hot-unplug test passed with this patch.

Changes in v3:
- Drop blk_abort_queue and blk_abort_request
- Use __blk_end_request_all to complete request dispatched to driver

Changes in v2:
- Drop req_in_flight
- Use virtqueue_detach_unused_buf to get request dispatched to driver

Signed-off-by: Asias He <asias@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/block/virtio_blk.c