]> git.karo-electronics.de Git - linux-beck.git/commit
powerpc/vio: Fix a dma_mask issue of vio
authorLi Zhong <zhong@linux.vnet.ibm.com>
Tue, 19 Nov 2013 08:11:37 +0000 (16:11 +0800)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Wed, 20 Nov 2013 23:33:43 +0000 (10:33 +1100)
commitc6102609289de268bcc6093e606483ea8bb35c84
tree55a2ace670f91db06363faee93a1f5b8409dbc1f
parentdc7a9bd3d0583bdc6ac291b4e1bf540dea398ea2
powerpc/vio: Fix a dma_mask issue of vio

I encountered following issue:
[    0.283035] ibmvscsi 30000015: couldn't initialize event pool
[    5.688822] ibmvscsi: probe of 30000015 failed with error -1

which prevents the storage from being recognized, and the machine from
booting.

After some digging, it seems that it is caused by commit 4886c399da

as dma_mask pointer in viodev->dev is not set, so in
dma_set_mask_and_coherent(), dma_set_coherent_mask() is not called
because dma_set_mask(), which is dma_set_mask_pSeriesLP() returned EIO.
While before the commit, dma_set_coherent_mask() is always called.

I tried to replace dma_set_mask_and_coherent() with
dma_coerce_mask_and_coherent(), and the machine could boot again.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/vio.c