]> git.karo-electronics.de Git - linux-beck.git/commit
staging/lustre/osc: Revert erroneous list_for_each_entry_safe use
authorOleg Drokin <green@linuxhacker.ru>
Wed, 7 Dec 2016 03:53:48 +0000 (22:53 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Dec 2016 10:41:16 +0000 (11:41 +0100)
commitcd15dd6ef4ea11df87f717b8b1b83aaa738ec8af
treeac4c77c30d7120cef6f6b6b149c2243e1959d2f6
parent0af72df267f2ed865c71a69fb2811ea6fa4736dc
staging/lustre/osc: Revert erroneous list_for_each_entry_safe use

I have been having a lot of unexplainable crashes in osc_lru_shrink
lately that I could not see a good explanation for and then I found
this patch that slip under the radar somehow that incorrectly
converted while loop for lru list iteration into
list_for_each_entry_safe totally ignoring that in the body of
the loop we drop spinlocks guarding this list and move list entries
around.
Not sure why it was not showing up right away, perhaps some of the
more recent LRU changes committed caused some extra pressure on this
code that finally highlighted the breakage.

Reverts: 8adddc36b1fc ("staging: lustre: osc: Use list_for_each_entry_safe")
CC: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Cc: stable <stable@vger.kernel.org> # 4.6+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/osc/osc_page.c