]> git.karo-electronics.de Git - karo-tx-linux.git/commit
i2c: omap: query STP always when NACK is received
authorGrygorii Strashko <grygorii.strashko@ti.com>
Fri, 7 Jun 2013 18:46:07 +0000 (21:46 +0300)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 19 Aug 2013 12:08:19 +0000 (14:08 +0200)
commitcda2109a26eb6fa58acfeae878eed87492480eae
tree4dce2af0e318dd77b33f0c279d8be066def96409
parent869c6a3ededbb108b03a11a7c9d4c8a4fb607063
i2c: omap: query STP always when NACK is received

According to I2C specification the NACK should be handled as folowing:
"When SDA remains HIGH during this ninth clock pulse, this is defined as the Not
Acknowledge signal. The master can then gene rate either a STOP condition to
abort the transfer, or a repeated START condition to start a new transfer."
[http://www.nxp.com/documents/user_manual/UM10204.pdf]

The same is recomened by TI I2C wiki:
 http://processors.wiki.ti.com/index.php/I2C_Tips

Currently, the OMAP I2C driver interrupts I2C trunsfer in case of NACK, but
It queries Stop condition OMAP_I2C_CON_REG.STP=1 only if NACK has been received
during the last message transmitting/recieving.
This may lead to stuck Bus in "Bus Busy" until I2C IP reset (idle/enable).

Hence, fix it by querying Stop condition (STP) always when NACK is received.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Hein Tibosch <hein_tibosch@yahoo.es>
Acked-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-omap.c