]> git.karo-electronics.de Git - karo-tx-linux.git/commit
minstrel: fix warning if lowest supported rate index is not 0
authorChristian Lamparter <chunkeey@web.de>
Mon, 22 Dec 2008 14:35:31 +0000 (15:35 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 12 Jan 2009 19:24:55 +0000 (14:24 -0500)
commitd57854bb1d78ba89ffbfdfd1c3e95b52ed7478ff
treec92947608e8457129a97c6ac43dad460a9a4cab0
parentd3a1db1c67735063921d9186145fc86164cf9781
minstrel: fix warning if lowest supported rate index is not 0

This patch fixes the following WARNING (caused by rix_to_ndx): "
>WARNING: at net/mac80211/rc80211_minstrel.c:69 minstrel_rate_init+0xd2/0x33a [mac80211]()
>[...]
>Call Trace:
> warn_on_slowpath+0x51/0x75
> _format_mac_addr+0x4c/0x88
> minstrel_rate_init+0xd2/0x33a [mac80211]
> print_mac+0x16/0x1b
> schedule_hrtimeout_range+0xdc/0x107
> ieee80211_add_station+0x158/0x1bd [mac80211]
> nl80211_new_station+0x1b3/0x20b [cfg80211]

The reason is that I'm experimenting with "g" only mode on a 802.11 b/g card.

Therefore rate_lowest_index returns 4 (= 6Mbit, instead of usual 0 = 1Mbit).
Since mi->r array is initialized with zeros in minstrel_alloc_sta,
rix_to_ndx has a hard time to find the 6Mbit entry and will trigged the WARNING.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
Acked-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/rc80211_minstrel.c