]> git.karo-electronics.de Git - karo-tx-linux.git/commit
regulator: core: Request GPIO before creating sysfs entries
authorKrzysztof Adamski <krzysztof.adamski@tieto.com>
Mon, 22 Feb 2016 08:24:00 +0000 (09:24 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 22 Feb 2016 10:51:05 +0000 (19:51 +0900)
commitdaad134d66492a9f641163c94510549770b39657
tree3ac745f3cbc2b851ba6186667634ec0770cd2478
parent92e963f50fc74041b5e9e744c330dca48e04f08d
regulator: core: Request GPIO before creating sysfs entries

regulator_attr_is_visible (which is a .is_visible callback of
regulator_dev_group attribute_grpup) checks rdev->ena_pin to decide if
"status" file should be present in sysfs. This field is set at the end
of regulator_ena_gpio_request so it has to be called before
device_register() otherwise this test will always fail, causing "status"
file to not be visible.

Since regulator_attr_is_visible also tests for is_enabled() op, this
problem is only visible for regulators that does not define this
callback, like regulator-fixed.c.

Signed-off-by: Krzysztof Adamski <krzysztof.adamski@tieto.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c