]> git.karo-electronics.de Git - karo-tx-linux.git/commit
md/raid5: fix calculate of 'degraded' when a replacement becomes active.
authorNeilBrown <neilb@suse.de>
Wed, 19 Sep 2012 02:52:30 +0000 (12:52 +1000)
committerNeilBrown <neilb@suse.de>
Wed, 19 Sep 2012 02:52:30 +0000 (12:52 +1000)
commite5c86471f933608db5d43679f84cb4346c32033e
treee596b35a134b9cc4e308f90090ecf9998a5b58a4
parenta852d7b8a0cf29499905c9243fa6d3fb93898b82
md/raid5: fix calculate of 'degraded' when a replacement becomes active.

When a replacement device becomes active, we mark the device that it
replaces as 'faulty' so that it can subsequently get removed.
However 'calc_degraded' only pays attention to the primary device, not
the replacement, so the array appears to become degraded, which is
wrong.

So teach 'calc_degraded' to consider any replacement if a primary
device is faulty.

This is suitable for -stable as an incorrect 'degraded' value can
confuse md and could lead to data corruption.
This is only relevant for 3.3 and later.

Cc: stable@vger.kernel.org
Reported-by: Robin Hill <robin@robinhill.me.uk>
Reported-by: John Drescher <drescherjm@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c