]> git.karo-electronics.de Git - linux-beck.git/commit
svcrpc: fix list-corrupting race on nfsd shutdown
authorJ. Bruce Fields <bfields@redhat.com>
Wed, 29 Jun 2011 20:49:04 +0000 (16:49 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Fri, 15 Jul 2011 22:58:46 +0000 (18:58 -0400)
commitebc63e531cc6a457595dd110b07ac530eae788c3
tree36f0775d56a045f54389dc7559e0ce3b5295a5e5
parent058c5c99999609e3de7e15b49049665f02d06577
svcrpc: fix list-corrupting race on nfsd shutdown

After commit 3262c816a3d7fb1eaabce633caa317887ed549ae "[PATCH] knfsd:
split svc_serv into pools", svc_delete_xprt (then svc_delete_socket) no
longer removed its xpt_ready (then sk_ready) field from whatever list it
was on, noting that there was no point since the whole list was about to
be destroyed anyway.

That was mostly true, but forgot that a few svc_xprt_enqueue()'s might
still be hanging around playing with the about-to-be-destroyed list, and
could get themselves into trouble writing to freed memory if we left
this xprt on the list after freeing it.

(This is actually functionally identical to a patch made first by Ben
Greear, but with more comments.)

Cc: stable@kernel.org
Cc: gnb@fmeh.org
Reported-by: Ben Greear <greearb@candelatech.com>
Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
net/sunrpc/svc_xprt.c